Repository navigation
knowledge: move seven bodies into inferrsi.knowledge and revise the manifest (K01) - #418
Conversation
…anifest Move the seven Knowledge implementations into inferrsi.knowledge, leave static exact-forwarding shells at the old root names, and add the _repo_pack_data leaf for REPO_TYPES and repository_pack. Rewire infra.inspection to that leaf. Revise the legacy manifest at the K01 base (hashes, public exports, technical leaf) and protect the new paths. Root shells and the three root protected paths stay until R01. overall isolation_complete stays false. Agent-assisted-by: Claude Code / claude-opus-5-5 effort=xhigh (author) Signed-off-by: GUOGUO <xwdong1998@163.com>
Dong1017
left a comment
There was a problem hiding this comment.
PR review verdict — DO NOT PASS
Reviewed base 34c81b0dfa1b4c21f9d54c715d73dd462e0f321e and head be86c658319ee28133575aae71dff0e44cfa7df2 (full diff, first review). prior-reviews.md lists no APPROVED review on this head and no outstanding CHANGES_REQUESTED.
Blocker
Root compatibility shells re-bind injectable names, and the moved bodies read the globals of the defining module. Patching the root name leaves record loading, research, and bundle identity on the original functions.
src/inferrsi/catalog.py:13and:31re-exportfiles.src/inferrsi/knowledge/catalog.py:7binds its ownfiles, andknowledge_recordscalls it at:91.docs/legacy-knowledge-manifest.jsonstill recordstests/test_cli_catalog.py(L189) andtests/test_knowledge_tiers.py(L89) as patchingcatalog.files. A patch ofinferrsi.catalog.filesdoes not change that call.src/inferrsi/knowledge/research.py:11doesfrom .catalog import knowledge_records, search_knowledge, andresearch_knowledgecalls that binding at:72. The same manifest entry recordstests/test_research.py(L91, L120) as patchingcatalog.knowledge_records. The call site that must be patched isinferrsi.knowledge.research.knowledge_records.src/inferrsi/knowledge_operations.py:2says to patch_jsonand_hashon the implementation module, and:12-:13only re-export them.Bundle/KnowledgeReaderinsrc/inferrsi/knowledge/knowledge_operations.pycall_hash(:88, used at:173) and_json(:51). The manifest audited sentence still says those names are “re-exported for test injection (D1, D2)”, and consumer evidence still saystests/test_bundle_manifest.py(L73) patches_hashandtests/test_collect_limit_serialization.py(L39-L47) patches_json. Re-export does not make a root-module monkeypatch visible insideBundle.manifestorcollect.
Expected correction: retarget those patches to the defining modules (inferrsi.knowledge.catalog.files, inferrsi.knowledge.research.knowledge_records, inferrsi.knowledge.knowledge_operations._hash / _json), and revise the D1/D2 sentence so the injection module is the implementation module. The line references at base e2f4cd1e39b369f06835cdd655ad5dc9f6808918 can stay as history; the head tests need to match the shells.
The diff text available here ends inside the knowledge_operations.py shell hunk (declared 35 lines; __all__ and everything after it were cut off), so this pass did not see knowledge_store.py, research.py, or skill_catalog.py shells, nor any test hunks. tools/skill_eval_snapshot.py still imports _skill_name and _unique_fields through the root skill leaf; that shell has to re-export them. I will re-read the full head after you push, including a confirmation that those private names are on the skill_catalog shell.
Verified on the visible move
- Blob-identical bodies:
_skill_selection(c696ef571),_source_snapshot(3ced2e330),knowledge_operations(cff710c26). Relative imports resolve insideinferrsi.knowledgewith the same text. REPO_TYPES/repository_packlive once insrc/inferrsi/_repo_pack_data.py(noinferrsiimport; fragment matches the old catalog function). Root catalog andknowledge/catalog.pyboth bind that sameREPO_TYPEStuple.knowledge/catalog.pydoes not definerepository_pack.src/inferrsi/infra/inspection.pychanges onlyfrom .._repo_pack_data import repository_pack.src/inferrsi/knowledge/__init__.pystays import-free.- Protected-path list adds
knowledge/catalog.py,knowledge/skill_catalog.py, andknowledge/knowledge_operations.pyin both.github/knowledge-model-policy.jsonanddocs/knowledge-model-policy.md. - Manifest skill-catalog line refs L279 / L317 / L435 and the call sites L281 / L319 / L438 / L439 / L442 / L445 match the moved
knowledge_operations.pybody. The#389task-lexical-v1collect path matches the new audited sentence (TASK_RELEVANCEis the thirdRELEVANCE_METHODSelement;skill_scorerejects it).
Not verified here
file_sha256values were not recomputed againste2f4cd1e39b369f06835cdd655ad5dc9f6808918or against the new_repo_pack_data.pybytes.- Tests were not executed. CI results were not in the review seed.
Optional
Root catalog.py used to bind the _source_snapshot module via from inferrsi import _source_snapshot. The shell does not re-export it. Callers that patched inferrsi.catalog._source_snapshot need inferrsi.knowledge._source_snapshot (the module knowledge/catalog.py actually uses).
This review does not approve the head and does not change K01 scope. I will re-read after the author pushes.
|
完整 review:base 已核对,没问题
问题
仅供参考,不阻塞
这次只是模块搬迁加文档和 manifest 修订,行为不变,不需要精度或性能实验。 Reviewed: |
Revise the Knowledge compatibility manifest: injection points are on inferrsi.knowledge.knowledge_operations / catalog, not the root shells; record the current test patch modules; note that OBS (#413) removes the TASK_RELEVANCE edge from observability/knowledge_capture. Update the K01-5 isolation test for #338: runtime resource loaders keep new_core_closure_isolated false, while Knowledge violations stay empty and overall isolation_complete stays false. Refs #407 Signed-off-by: GUOGUO <xwdong1998@163.com>
Dong1017
left a comment
There was a problem hiding this comment.
PR review verdict — DO NOT PASS
Reviewed incremental range be86c658319ee28133575aae71dff0e44cfa7df2..18271323cd4360809ed25b4cb7ac4689e794eca4 on base fa3d6421c71cad3be6a918733dfacde1824b1a5e. Prior review on be86c658: #418 (review) (COMMENT / DO NOT PASS). prior-reviews.md lists no APPROVED review on this head and no outstanding CHANGES_REQUESTED.
This review does not approve the head.
Blocker
docs/legacy-knowledge-manifest.json still records the root-shell patch targets, and the sentences added on this head do not name the module global the research call reads.
- Catalog
consumer_evidence(hunk@@ -41,7 +41,7 @@, file ~L44) still saystests/test_cli_catalog.py(L189) andtests/test_knowledge_tiers.py(L89) patchcatalog.files, andtests/test_research.py(L91, L120) patchcatalog.knowledge_records. The same string then says those tests at L191, L91, L92, and L121 patchinferrsi.knowledge.catalog. Both claims are present tense. On the prior head,research_knowledgecallsknowledge_recordsbound insrc/inferrsi/knowledge/research.py(from .catalog import knowledge_records). The call site to patch isinferrsi.knowledge.research.knowledge_records. A patch ofinferrsi.knowledge.catalogleaves that binding on the original function, which is the same failure path as the prior review. knowledge_operations(hunk@@ -200,10 +200,10 @@, file ~L203–L209):audited_definitionsnow says_jsonand_hashinjection is oninferrsi.knowledge.knowledge_operations, and a root-shell patch leavesBundle.manifestandKnowledgeReader.collecton the original functions.consumer_evidencestill saystests/test_bundle_manifest.py(L73) patches_hashandtests/test_collect_limit_serialization.py(L39–L47) patches_json, then adds that L74–L75 and L48–L49 patch the implementation module.
Expected correction: one live patch target per injectable name, matching the module global the body reads. For research, that target is inferrsi.knowledge.research.knowledge_records unless research.py looks the name up on the catalog module at the call. Include the test edits and any shell or body edits in the diff.
Verified
- Those manifest hunks are the K01 edits present in the readable prefix of
pr/diff.patch. The prior root-shell binding failure is still what the updated catalog sentence describes for research. - No formal Approve on
18271323.
Not verified here
pr/diff.patchends mid-line inside addedsrc/inferrsi/benchmark/tasks/moe-forward-npu/benchmark.py(except (OSErr). Later paths are absent from the seeded patch, includingsrc/inferrsi/knowledge/**, the root shells, andtests/test_cli_catalog.py,tests/test_knowledge_tiers.py,tests/test_research.py,tests/test_bundle_manifest.py, andtests/test_collect_limit_serialization.py. The new line numbers are unchecked.- Tests were not executed. Benchmark, docs, and CLI additions in this range were not reviewed past that cutoff.
I will re-read after the author pushes a patch that includes those files.
amy-why-3459
left a comment
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
增量 review:be86c658319ee28133575aae71dff0e44cfa7df2 → 18271323cd4360809ed25b4cb7ac4689e794eca4(新 base fa3d6421c71cad3be6a918733dfacde1824b1a5e)。中间是 merge main 的 c5b626a65083ed54c87a4d01d88dce07b88394ef(带进 #415/#401/#338)和修复提交 18271323。
上次三点都已解决
docs/legacy-knowledge-manifest.json里knowledge_operations的audited_definitions改了:注入点在inferrsi.knowledge.knowledge_operations,根壳只是同名透传。catalog 和knowledge_operations的consumer_evidence保留了 base 上的 patch 位置作为历史,又补了 head 上实际 patch 的模块和行号。- PR 描述补了七叶哈希对照表(P0b
0da7e2f9→ K01 basee2f4cd1e),还附了计算命令。五行没变,两行在 #389 里改过,和我上次复算的结果一致。 _skill_selection的consumer_evidence补了一句:observability/knowledge_capture对TASK_RELEVANCE的导入由 OBS(#413)删除,K01 只保留根壳透传。
增量核对
- merge 没有改到七个根叶、
knowledge/**和 manifest。manifest 只有18271323里的 4 行文字修改,七个file_sha256和base_commit都没变。#338 带进来的代码里,唯一新的 Knowledge 引用是tests/test_optimization_session.py里from inferrsi.knowledge_operations import KnowledgeReader,走根壳透传,没问题。 docs/module-layout.md的冲突按并集解决了,K01 和 #338 benchmark 的描述都在。- K01-5 测试(
tests/test_knowledge_compatibility_shells.pyL74–L89)改成断言runtime resource loaders这个 blocker,且new_core_closure_isolated为 false,violations仍为空,isolation_complete仍为 false。这和 #338 之后first_wave_report()的结果一致,不是 Knowledge 闭包退化。 - head 上 CI 全绿:
full-check3.10/3.11、installed-package3.10/3.11、lint-and-smoke、pr-references、knowledge-model-policy。declarations第一次失败、更新描述里的head_sha后重跑通过。
关于 Dong1017 在这个 head 上的 DO NOT PASS,我逐条核对过,不构成阻塞
- research 的绑定:
src/inferrsi/knowledge/research.pyL12 绑定的knowledge_records只在 L73 用来算catalog_size。真正的检索在 L84 调用search_knowledge,它读的是inferrsi.knowledge.catalog模块里的knowledge_records,正是tests/test_research.pyL117/L136 patch 的那个,所以测试 patch 的是有效的注入点。base 上根research.py也是这个结构,K01 没有改变行为,CI 也通过了。 consumer_evidence里同时有 base 的位置和 head 的位置:manifest 记录的是base_commit上的证据,新加的句子明确写了 “On this K01 head”,并说明根壳 patch 已经无效,不会有歧义。
不阻塞,可以顺手改
- 描述里 K01-1 那一行的 “CI on this new head is still running” 和 “CI lanes on this new head are not yet complete” 已经过时了,可以换成 head 上的 CI 链接。
这次只是文档、manifest 和一个测试的期望值修改,行为不变,不需要精度或性能实验。
david6666666
left a comment
There was a problem hiding this comment.
Looks good. The six unchanged bodies and the catalog split preserve the existing call paths. I checked all 32 changed files and ran focused export-identity, leaf-hash, and injection-binding checks; I did not rerun the full suite. CI for this head is green.
zengchuang-hw
left a comment
There was a problem hiding this comment.
Independent post-merge review of head 18271323cd4360809ed25b4cb7ac4689e794eca4 against base fa3d6421c71cad3be6a918733dfacde1824b1a5e. This PR was already merged when reviewed; this is a COMMENT, not a merge approval.
No actionable defects identified in the reviewed changes. I compared all seven relocated Knowledge implementations with the original root modules: six are byte-for-byte unchanged, while catalog changes are confined to routing the source-snapshot import and extracting REPO_TYPES/repository_pack into the neutral data leaf. I also inspected the compatibility exports, lazy optional-dependency paths, package discovery, resource paths, infra import rewrite, and protected-path policy updates. Root-shell monkeypatching no longer changes implementation globals; the changed tests and documentation explicitly reflect that boundary.
Checks run on the clean exact-head checkout:
- 16 focused test files covering compatibility, policy/architecture, manifests, catalog/CLI, collect serialization/selection, store/readers, research, skill parsing and optional dependencies: 431 passed, 2 skipped, plus 4 subtests passed.
ruff check src tests: passed.git diff --checkagainst the base: passed.
Limits: the full repository test suite, fresh wheel-install validation, and platform-specific skipped cases were not executed in this review. One pytest-plugin deprecation warning was emitted. Review conclusions are limited to the code and checks above; other reviewers' opinions were not consulted.
zengchuang-hw
left a comment
There was a problem hiding this comment.
Historical human-request follow-up — K01 relocation checks passed within the scope below; full acceptance remains unverified.
Explicitly answering 6825142663, updated 2026-11-12T13:37:50Z. The request's technical opinions and author/reviewer retellings were not read. Requirements came from the isolated original K01 scope.
Reviewed current retained head 1827132 against base fa3d642. The source's historical locator was an earlier revision; the checks below apply to the current head only. PR remains closed.
My previous COMMENT 5923779106 is on this same head but does not explicitly reference this request. Same-head/content overlap was not taken as coverage. This revision-bound COMMENT provides the explicit response without reopening the PR or changing the earlier review.
Independent code assessment:
- Assessed the 32-file relocation diff (2,271 additions / 1,936 deletions). Compared comment/docstring-free ASTs of each old module with its new Knowledge implementation.
- _source_snapshot, skill_catalog, _skill_selection, research, knowledge_store and knowledge_operations retain identical executable ASTs in that old-to-new comparison. catalog changes the _source_snapshot import route and delegates REPO_TYPES / repository_pack to the new neutral _repo_pack_data leaf; its repository_pack implementation and data path remain the original implementation.
- Read all seven root forwarding shells and the new leaf. The shells forward the listed public/private compatibility names directly, rather than wrapping functions; tests verify object identity and all against the manifest. Infra inspection routes to the neutral leaf, and the fresh-process test verifies importing Knowledge/inspection does not eagerly load Knowledge implementation bodies.
- The production package data/pack.json layout is not relocated in this diff. It does not retire root shells or complete the remaining whole-project isolation work.
- The model-policy JSON delta adds the three moved protected module paths while retaining their original protected paths. That is a source-level observation, not authorization to accept a policy amendment or change GitHub security settings.
Actually executed on an isolated exact-head archive:
- Eleven affected test modules: compatibility shells, bundle manifest, CLI catalog, collect limit serialization, knowledge model policy, knowledge store, knowledge tiers, research, skill library readers, architecture closed loop and optional-dependency tests.
- Result: 305 passed, 1 skipped, 4 subtests passed. The skip is the knowledge-store export test requiring Git metadata, absent from the archive. It is NOT a passed export test.
- Ruff on the moved implementations, shells, leaf, inspection and compatibility test passed; git diff --check passed.
- Exact-head check-run metadata returned nine entries: eight success and one failure. I did not inspect the failed job's log or infer its cause, and did not verify required-check configuration.
- Read the applicable AGENTS delta; the review skill is unchanged from the version already read.
Limits and remaining evidence:
I did not run the full repository suite, the skipped Git-backed export, or build/install a wheel outside the checkout. Thus this pass does not establish all outside-checkout packaging/resource compatibility. It also does not establish authenticated acceptance of the revised legacy manifest or policy scope: the clean handoff explicitly lacks complete original AC/decision provenance. Passing tests that consume the revised manifest cannot by themselves authorize that revision. The remaining global isolation blockers are outside the seven-module relocation slice, not evidence that K01 completes the entire architecture transition.
No new blocking defect was identified in the exercised relocation subset. This is not a blanket approval of every compatibility, packaging or policy obligation, nor a claim that the failed CI entry is resolved. Verify the remaining evidence before using this follow-up as overall acceptance. No repository code, labels, permissions, policy configuration, merge/closed state or previous review state was changed; no paid model/device work or stopped task was resumed.
Governing Issue and delivery slice
Refs #407
Accepted scope / delegation: Confirmed 2026-11-12 11:35–11:36 Asia/Shanghai: K01 moves the seven Knowledge bodies and revises
docs/legacy-knowledge-manifest.jsonin this same PR, for formal review by @amy-why-3459 and @zengchuang-hw. The implementer has not self-approved the manifest revision. The coordinator has not self-approved it either.What this PR delivers: The seven Knowledge implementations live under
src/inferrsi/knowledge/; six are byte-identical to the bodies at basee2f4cd1e39b369f06835cdd655ad5dc9f6808918, andcatalog.pyapplies only the D020 split (REPO_TYPES/repository_packgo to the newinferrsi._repo_pack_dataleaf). Root modules remain static exact-forwarding shells.infra.inspectionimportsrepository_packfrom that leaf, not fromcatalog. The manifestbase_commitis revised to this K01 base, withrevision_historyfor the P0b base; the two Review measured request profiles and decisions across optimization rounds #389 leaf hashes, three public exports (TASK_RELEVANCE,task_score,record_context), and the leaf file hash are updated. New Knowledge paths are added toprotected_paths; the three root paths stay until R01. D1–D8 test seams and a compatibility-shell test are updated accordingly.This head also merges current
main(fa3d6421c71cad3be6a918733dfacde1824b1a5e, PRs docs: InferRSI × vLLM-Omni Optimization Results #415, Compare stage timings and inspect knowledge searches for each profile #401, and feat: share RSI optimization management across project and benchmark tasks #338). The only conflict wasdocs/module-layout.md, resolved as a union: it records both the K01 Knowledge move and the feat: share RSI optimization management across project and benchmark tasks #338benchmark/contribution. Review comments from @amy-why-3459 are addressed in18271323cd4360809ed25b4cb7ac4689e794eca4(manifest injection-point wording, current test-patch modules, the TASK_RELEVANCE / OBS (task: OBS — 解散 observability 过渡包并归位记录与展示 #413) note, and the seven-leaf hash table below). The K01-5 test now matches the post-feat: share RSI optimization management across project and benchmark tasks #338first_wave_report().What it does not deliver: Residual cleanup; moving
data//pack.json(K02); retiring the root shells (R01); splittingskill_evaluation; OBS; registeringNEW_H_ENTRIES; settingoverall isolation_completeto true.@amy-why-3459 @zengchuang-hw: formal review request for this K01 PR, including the manifest revision and the new
protected_paths. Please review this head (18271323cd4360809ed25b4cb7ac4689e794eca4).Knowledge authorship declaration
Local implementation (commit
be86c658319ee28133575aae71dff0e44cfa7df2) used Claude Code with--model claude-opus-5-5and--effort xhigh. A CLI exit code is not independent proof of backend model identity. The merge (c5b626a65083ed54c87a4d01d88dce07b88394ef) and the review-comment commit (18271323cd4360809ed25b4cb7ac4689e794eca4) were written by the coordinator, not by Claude.Seven-leaf hashes (P0b → K01 base)
Computed from raw
git showbytes (no trailing-whitespace strip), for @zengchuang-hw:0da7e2f960cd4ec994ae8eddea5b71023c5379cae2f4cd1e39b369f06835cdd655ad5dc9f6808918src/inferrsi/catalog.pye3241a3203595f116925ebb3fa6b4e2c0cb588b4c3a3575369bf50f253a3a947e3241a3203595f116925ebb3fa6b4e2c0cb588b4c3a3575369bf50f253a3a947src/inferrsi/_source_snapshot.pyba6b799731a73cca55f211813d512fcaf46a123ce3997ad3ff918ce65ea7f39bba6b799731a73cca55f211813d512fcaf46a123ce3997ad3ff918ce65ea7f39bsrc/inferrsi/skill_catalog.py86d465e245b4cd6b72ca175d05124dbb88d510a78568b6bc4c44b332870c08a386d465e245b4cd6b72ca175d05124dbb88d510a78568b6bc4c44b332870c08a3src/inferrsi/_skill_selection.pyacbec7c91bfa05bc2008b939e009fe600a40518051229fb7618c56b092ad36b97bcf1930b73e09fcadf78e7c9e384b30411ed599d83c32e6837f04ca25cbda77src/inferrsi/research.py9bfe59dd17b5476c18ce50d671711053c62800521c50d6b710e8140a2b4dca049bfe59dd17b5476c18ce50d671711053c62800521c50d6b710e8140a2b4dca04src/inferrsi/knowledge_store.py70dfca059b0a682579206d4376d191667934b3ca869ae847098c4c6964d86abe70dfca059b0a682579206d4376d191667934b3ca869ae847098c4c6964d86abesrc/inferrsi/knowledge_operations.py3725781bcedb308af6ad9edc0b970c63f82accf6b04ebee4008c1081b63bed9c686b196e03ca0a1dba5ff5e246563f305ba2bea412172833905af41a6c6ad886On this head, the six moved files under
src/inferrsi/knowledge/are SHA-256-identical to the K01-base root files above.knowledge/catalog.pydiffers only by the D020 split. The new technical leafsrc/inferrsi/_repo_pack_data.pyhasfile_sha256a14edac8283b1f7b6b5794381c44d7c2632dda5cc01f03c557dc293d05523afd(not one of the seven leaves).Changed artifacts and evidence
Independent coordinator checks at base
e2f4cd1e39b369f06835cdd655ad5dc9f6808918(2026-11-12 Asia/Shanghai) and again on this merged head18271323cd4360809ed25b4cb7ac4689e794eca4. A local pass is not CI and is not branch protection.__all__/ signaturesREPO_TYPESis one tuple on three routesinferrsi.knowledge.*. Focused suite includestest_root_names_are_the_moved_objectsand__all__checks — see focused run belowdata/change; D1–D8 seams retargetedsrc/inferrsi/data,plugins,pyproject.toml,MANIFEST.in; focused set includes bundle, store, contract, snapshot testsrepository_pack/ infracheck_installed.py,check_k01_installed.py) and recorded as exit 0. Ubuntu evidence: installed-package 3.10 and 3.11 succeeded onbe86c658319ee28133575aae71dff0e44cfa7df2first_wave_report()on this head:violationsempty;residualsonlyinferrsi.harness.skill_evaluation -> inferrsi.knowledge_operations;blockersareabsent: apps/,allowlist: 9 compatibility pairs, that residual,harness reaches model/infra(inferrsi.harness.agent_sessions -> inferrsi.infra, 41 hits), andruntime resource loaders: 5.absent: knowledge/andabsent: benchmark/are gone.new_core_closure_isolatedis false solely because of those loaders (added by #338); Knowledge has no closure violation.isolation_completeremains false. The K01-5 test now asserts this post-#338 reportdata/and plugin layout untouchedsrc/inferrsi/data,plugins,pyproject.toml,MANIFEST.indocs/legacy-knowledge-manifest.json:base_commite2f4cd1e…,revision_history, two #389 hashes, three public exports, leaffile_sha256a14edac8283b1f7b6b5794381c44d7c2632dda5cc01f03c557dc293d05523afd. Review follow-up: audited sentence for_json/_hashnow states that injection points are oninferrsi.knowledge.knowledge_operationsand that the root shell is a same-name pass-through (patching the root does not affectBundle.manifestorKnowledgeReader.collect); catalog andknowledge_operationsconsumer_evidencekeep the base-era patch locations as history and add the current-head modules and lines (tests/test_cli_catalog.pyL191,tests/test_knowledge_tiers.pyL91,tests/test_research.pyL92 and L121 patchinferrsi.knowledge.catalog;tests/test_bundle_manifest.pyL74–L75 andtests/test_collect_limit_serialization.pyL48–L49 patchinferrsi.knowledge.knowledge_operations). The_skill_selectionevidence notes that theobservability/knowledge_captureimport ofTASK_RELEVANCEis removed by OBS (#413); K01 only keeps the root-shell pass-through of that nameprotected_paths.github/knowledge-model-policy.jsonanddocs/knowledge-model-policy.mdadd the threeknowledge/paths; root paths keptinfra.inspection → catalogrewired_repo_pack_datamainc5b626a65083ed54c87a4d01d88dce07b88394ef; onlydocs/module-layout.mdconflicted_repo_pack_dataparagraph is the K01 “K01 created… formal review” wordingChecks and dependencies
git diff --checkon the merged head: clean.ruff checkon the K01-changed Python (tests/test_knowledge_compatibility_shells.py): all checks passed. A full-treeruff check src tests toolson the merged head reports five F811 findings intests/test_engineering_benchmark_plugins.py, which arrived from feat: share RSI optimization management across project and benchmark tasks #338 and are already onmain; they are not part of this PR's review-comment commit. feat: share RSI optimization management across project and benchmark tasks #338's own full-check had passed.first_wave_report()on the merged head: result in the K01-5 row above;isolation_completeis false.pytest -q -p no:cacheprovider -rfE -n 8 --dist loadfile): 630 tests, 0 failures, 0 errors, 9 skipped, 2026-11-12 Asia/Shanghai.be86c658319ee28133575aae71dff0e44cfa7df2(this is the Ubuntu evidence for that implementation; it supersedes earlier local Windows full-suite figures): full-check 3.10, full-check 3.11, installed-package 3.10, installed-package 3.11, pr-references, declarations, and lint-and-smoke all succeeded. CI on this new head will re-run and is not yet the evidence.harness.skill_evaluation → knowledge_operationsresidual stay. Root shells stay until R01. Theobservability/knowledge_captureimport ofTASK_RELEVANCEis left for OBS (task: OBS — 解散 observability 过渡包并归位记录与展示 #413); K01 only keeps the root-shell pass-through.#397is untouched. This PR must not be read as settingoverall isolation_completetrue. After feat: share RSI optimization management across project and benchmark tasks #338,new_core_closure_isolatedis false because of runtime resource loaders; that is not a Knowledge-closure regression.Remaining work and Issue closure
protected_pathsafter retirement evidence. K02 moves packaged resources. Other first-wave slices are out of scope.#407is not closed by merging this PR.The
knowledge-model-policyrequired status is the admission check for protected paths; the import-gate result above is attached evidence and is not branch protection.