Repository navigation
refactor(apps): move Harness handoff adapters into apps.handoff - #496
zengchuang-hw wants to merge 2 commits into
Conversation
Signed-off-by: zengchuang <zengchuang3@huawei.com> Agent-assisted-by: Codex (author)
|
@Dong1017 @david6666666 请独立检视当前 head 请 Dong1017 以 Harness 接口 owner 角色检查 #475 的 CPU 封存调用路径、原 attempt 与 request_digest 保留、 本地 Apps/Harness 等回归 377 项和 330 个子用例通过;三个插件相关验证 55 项通过;sdist 构建的 wheel 在仓库外新环境安装检查通过,930 项资源摘要一致。当前提交 CI 正在运行,Windows 已有文件锁限制仍由 #494 跟踪。发现问题后先修正;达到条件时请提交首行 按请求方要求,需两份来自独立且有 write 或更高权限账号的有效审批和通过的 CI 才执行 squash。Cursor 的技术意见可以参考, |
Dong1017
left a comment
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base 76ca44a and head e7beb10 (full diff, first review). prior-reviews.md seeds no formal reviews and no outstanding CHANGES_REQUESTED, so this is the first formal review on this head.
Verified from the diff:
- Pure move, no behavior change.
handoff/context_provider.pyhas blob58fdc682, identical to the oldapps/context_provider.pyblob.handoff/bridge.pymatches the removed body line for line. The only change is the imports:.storage.*became..storage.*.handoff/candidate_provider.pydiffers from the old file only in import ordering and relative paths..bridgenow resolves insidehandoff, which keeps the private-helper imports valid.
- Shims.
apps/bridge.py,apps/context_provider.pyandapps/candidate_provider.pyre-export the registered public names with explicit__all__.- Classes keep canonical
__module__, so old-path pickles resolve through the shim.test_delivered_context_draft_loads_a_legacy_instance_picklecovers this.
- Single class identity.
apps.apinow importsCandidateProviderfromhandoff.candidate_provider.EvaluationPortstays defined inapps.api. Both are asserted incheck_installed.pyand intest_public_candidate_provider_is_the_one_canonical_class. - Layering.
handoffimportsstorage, and storage does not import back.handoff/__init__.pyis docstring-only. - Consumers and docs.
views/attempt.py,api.pyand the tests moved to canonical paths.docs/apps-module-migrations.jsonhas the three new entries (bridge, context_provider, candidate_provider) and the updated consumer lists. The architecture, module-layout, operations and apps-output docs describe the move and keep the Harness ownership boundaries. - Tests.
- The initializer/no-I/O test is generalized to cover both
storageandhandoff. - The cold-storage test is filtered to storage entries.
- A new cold-handoff test checks that import performs no file reads, process launches, sqlite or socket use.
- The initializer/no-I/O test is generalized to cover both
Not verified here (no execution environment):
- I did not run the test suite and I have no CI results.
- I did not run the installed-wheel check in
check_installed.py. It assumes packaging picks upapps/handoffautomatically, as it did forstorage.pyproject.tomlis not in the diff. - I did not grep the full repo for other consumers of the old private names (
inferrsi.apps.bridge._*). The shims intentionally re-export only the registered public names.
Non-blocking: confirm CI is green, including the installed-wheel job, before merge. The ruleset's second qualifying approval is still required.
Posted by Dong-bot, an automated agent acting on behalf of @Dong1017 (always-on-bot, model claude-sonnet-5-5).
|
已收到 Dong1017 对当前提交的独立 diff 检视,感谢确认迁移、类身份和 Harness 边界。安装包 CI 的 Python 3.10/3.11 两条检查均已通过,仓库外本地 sdist→wheel 检查也已通过;其余当前提交 CI 继续跟进。 补充消费者核对范围:迁移测试逐个解析 src / tests / tools / plugins 的静态导入,禁止活跃代码导入已迁移旧模块,并要求 canonical 消费者登记在 JSON。完整相关回归中的该项检查已通过。原私有 bridge helper 只在 canonical 目前仍等待 david6666666 的独立实现复核。当前只有一份符合账号权限条件的审批,暂不执行合入。 |
|
@david6666666 当前提交 现在仍需你对该提交的实现复核和结论,有意见先处理。通过时请用当前提交的 Approve 和首行 |
|
@david6666666 再跟进一次。截至 请复核当前实现,有问题先处理,通过后请提交符合项目格式的 Approve。请求方约定的“一小时无进展提醒介入”已在会话中触发,现等待协调完成第二份有效审批,PR 保持打开,尚未执行合入。#493 的事后独立复核也仍待补充,之前的合入审批历史保持如实记录。 |
|
@amy-why-3459 PTAL |
|
@amy-why-3459 请补充独立检视当前 head 请重点核对 ContextProvider 的 Knowledge → Harness 交付字节和 pins、DeliveredContextDraft 旧 pickle 兼容、CandidateProvider 的公开与 canonical 类身份、三份静态 shim 和迁移 JSON。代码是三个实现归位及导入调整,非导入 AST 保持不变。Dong1017 已完成当前提交的 diff 检视并批准,H 的 #475 封存回归包含在 377 项本地回归中;三个插件 55 项及仓库外 wheel 验证也通过,当前 ready CI 全绿。 @david6666666 你的复审请求继续保留,请复核 #496,并补充 #493 的事后实现复核。有意见先处理;通过时请用当前提交的 Approve、首行 |
Signed-off-by: zengchuang <zengchuang3@huawei.com> Agent-assisted-by: Codex (integration)
|
已同步最新 main 当前 CI 和聚焦的 handoff、Dashboard、独立包检查正在重跑。旧审批已因提交更新而失效,当前审批数重新按新 head 计算。@Dong1017 @amy-why-3459 @david6666666 请检视新提交,原有检视可结合此次 main 合入增量复核;请以新 head 的实际结论记录 Approve / Request changes。满足两份独立有效审批且检查通过后由本会话 squash 合入。 |
Governing Issue and delivery slice
Refs #490
Refs #371
Apps execution binding and generation adapters still lived at the package root. This second #490 slice places them under
apps.handoff, repoints active consumers, and preserves the registered old public imports andapps.apisurface.Scope is accepted in the #490 design decision, with the Apps owner's instruction to continue handoff after storage. Codex implements this slice under the Apps owner's account. Independent implementation and Harness-owner review are requested separately.
Changed artifacts and evidence
apps/handoff/; adjust storage imports and API/fixed-view consumersapps.api.CandidateProviderexports the canonical class whileEvaluationPortstays in APIChecks and dependencies
Current base is
cf671a880ac8037e01922e1be0b701771fb9922f, integrated in head3874328aa263f475118c032253cf552f13351c46. Local verification uses Windows and Python 3.12. The handoff diff against the new base is unchanged; the refresh brings in the upstream round-decision Dashboard resources and its browser coverage.python -I check_installed.pyoutside the checkout.e7beb107, including Python 3.10/3.11 full-check and installed-package, browser and Windows/macOS lanes. Current head3874328ais rerunning CI after the base refresh; focused handoff, Dashboard and distribution rechecks are in progress. The upstream Dashboard change owns its added browser coverage; this handoff slice adds no workflow, exception list or gate change.Storage dependency #493 is merged. Its approval-record correction remains explicit: the merge occurred with one eligible approval, and the requested post-merge independent review is still pending. That process gap is not represented as two valid pre-merge approvals.
Remaining work and Issue closure
Workflows, integrations and integrated acceptance remain in #490; it stays open. Apps and affected interface owners confirm whole-Issue completion.
Please have the Harness interface owner inspect the migrated #475 sealing path and public provider identities. This slice still requires two independent, current-head approvals from eligible accounts and passing CI before integration. A bot approval without the required account permission does not fill that requirement.