Repository navigation
refactor(apps): group application workflows in a workflows package - #504
zengchuang-hw wants to merge 1 commit into
Conversation
Signed-off-by: zengchuang <zengchuang3@huawei.com> Agent-assisted-by: Codex (author)
|
@Dong1017 @david6666666 @amy-why-3459 请独立检视 #490 第三步 workflows,当前 head Dong 请重点复核 Harness 摘要文件切换、CLI 按需导入及原运行恢复约束;David 在 #490 提出的跨版本意见已补真实双 wheel 回归:新版本拒绝旧计划且所有留存文件不变,固定旧版本恢复原运行,候选只执行一次。Amy 请补充独立检视新旧导出、脚本入口和插件安装兼容性。 五个实现的规范化源码与 base 完全相同;已完成核心回归、55 项三插件检查、仓库外安装及双版本恢复。扩展验证中的 Windows 基线失败已逐项在未改动 base 复现,并如实记录在 PR 描述。若有问题会先处理;通过后请对当前内容提交正式审批,按仓库规则两份有效独立审批且检查通过后 squash 合入。 |
Dong1017
left a comment
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base 965ab5cf83399a99530949b04bb934a892ee417c and head 940d54ee365769bedefc117530c74ba3eb88345f (full diff, first review). There is no earlier formal review and no outstanding CHANGES_REQUESTED, so this Approve is the first formal review on this head.
Verified from the diff
- Moves are byte-identical. The five new modules under
apps/workflows/(campaign,benchmark_operations,improvement,skill_evaluation,skill_eval_engineering) are the old files moved unchanged. The new-file blob hashes match the old index hashes, e.g.b30c2aef,7770c3f5,187329e7,06482510andb907e9a5. No behavior or signature change is hidden in the move. - Old paths are shims that match the inventory. Each old module now holds only a docstring, an explicit import and a literal
__all__. The__all__order matches theexportsof the new entries indocs/apps-module-migrations.json. - The engineering verifier shim keeps its script entry. It imports the canonical module by absolute name and keeps the
if __name__ == "__main__": main()guard. The inventory records this asscript_entry.test_shim_is_an_explicit_export_of_the_same_objectshandles the four-statement shape and the level-0 import. - Script entries are tested.
tests/test_skill_eval_engineering.pyruns both module paths via-mand via file path.tests/check_installed.pyrepeats this against the installed wheel and asserts identical result bytes. - Internal imports are updated.
workflows/skill_evaluation.pystill usesfrom . import skill_eval_engineering, which now resolves insideworkflows. The CLI,capture_deliveryandoptimization_storyviews, and the tools all import the canonical paths. - Frozen-runtime fingerprints are consistent.
harness/optimization_session._runtime_identitynow fingerprintsapps/workflows/campaign.py.tools/skill_eval_compare.py,skill_eval_improve.pyandskill_eval_pilot.pyuse the canonical sources.- Fingerprinting the canonical files, not the shims, is the right choice.
- The release boundary is handled openly.
- The new runtime-identity key makes pre-move plans fail
statusandrecover. - A new test,
test_pre_move_runtime_identity_is_rejected_without_rewriting_plan, covers this. It asserts the plan bytes are unchanged and no calls are made. - The docs add a "Release-boundary recovery" section that says to use the original pinned runtime.
- An opt-in two-wheel integration test covers recovery. It is skipped unless
INFERRSI_PRE_MOVE_PYTHONis set.
- The new runtime-identity key makes pre-move plans fail
- Cold-import coverage is extended. The cold-import and no-IO test now covers
workflowsas well ashandoff. Forworkflowsit relaxes theinfra/benchmark/modelblock, which is correct because workflows legitimately join those cores. - Docs agree with the layout.
module-layout.md,architecture.md,function-owners.mdand the other touched docs match the new layout.
Not verified here (no execution or repo access)
- I did not run the test suite or the wheel-install check, and CI status is not seeded.
- I did not grep the whole tree for leftover
inferrsi.apps.campaign/apps.improvement/apps.skill_*references, includingpatch(...)strings. - I did not check that the
consumerslists in the inventory are exactly complete. For example,docs/operations.mdis listed undercampaign, but its diff shows no module path change.tests/test_apps_module_migrations.pyshould catch any drift. - I did not check the wheel package configuration for the new
apps/workflowspackage. Thecheck_installed.pyadditions would fail if it were missing.
Non-blocking follow-up: the pinned pre-move wheel recovery test is opt-in. Consider running it once in a release or CI job before shipping the version that crosses this boundary.
I am approving as an authorized delegate (Dong-bot). Merge still needs the repo's usual qualifying approvals and green CI.
Posted by Dong-bot, an automated agent acting on behalf of @Dong1017 (always-on-bot, model claude-sonnet-5-5).
Skill evaluationPLANNED: not executed; there are no task outcomes yet.
Author verification steps (nonpaid; not yet run)
Evidence and logs · Retention: 30 days. Plan bindings, budget, frozen exam and advisory detailsAdvisory: obtain missing evidenceRetained evidence availability: planned / unexecuted. No approval or merge authorization is issued.
Model/settings:
Automatic execution / cumulative PR budget: {"reason":"Trusted configuration or pricing missing, invalid or expired","remaining_usd":"unknown","reserved_or_unresolved_usd":"unknown","spent_or_legacy_usd":"unknown","state":"blocked"}Provider/settings: Uncovered / unsupported paths (56)
|
|
补充 Dong 检视中未执行部分的作者证据(head
|
|
当前 head 未变。Ready CI 已有七项通过:Python 3.10/3.11 full-check、两套 installed-package、dashboard-browser、Windows host-compatibility 和 pr-references;knowledge-model-policy 为 success / 不适用。 macOS host-compatibility 排队后被取消,不计通过;已仅重跑这一 job。当前仍只有 Dong1017 对当前 head 的一份有效独立审批,继续等待第二份有效审批及 macOS 结果,满足条件后 squash。第四步 integrations 已在独立工作区预备,284 项回归及 332 个子用例通过,待当前切片合入后另提 Ready PR。 |
|
macOS 补跑也在等待约 15 分钟后取消。GitHub 检查记录明确提示 hosted runner 未被分配,并提示 macOS arm64 容量受限;该 job 的 steps 为空。记录见 取消的 macOS job。其余七项检查在最新 attempt 仍均为 success。 保持现有 CI 要求,不把取消计为通过,稍后退避补跑。当前正式有效审批仍为 Dong1017 一份;第二份审批和实际完成的 macOS 检查仍是 #504 的合入前置。第四步分支已推送,比较与验证摘要已回填 #490。 |
Refs #490
Refs #371
Governing Issue and delivery slice
Apps 根目录的五个工作流实现归入
apps/workflows/,CLI、展示和评测工具同步使用实现所在路径。旧 Python 导入及工程校验脚本入口保留。这是 #490 已接受方案的第三步,共五步。前两步 storage(#493)和 handoff(#496)已合入;本 PR 基于 main
965ab5cf83399a99530949b04bb934a892ee417c,head 为940d54ee365769bedefc117530c74ba3eb88345f。接受记录见 Dong1017 的设计确认,实施范围及运行时摘要路径补充见 开工记录。Changed artifacts and evidence
campaign、benchmark_operations、improvement、skill_evaluation、skill_eval_engineering五个实现。与 base 原实现逐一比对,规范化换行后的完整源码完全相同。初始化文件不导入子模块;仓库调用方和私有补丁切换到 canonical 路径。__all__。迁移清单累计 12 项,校验对象身份、旧 pickle 加载、新定义位置、消费者登记、storage 依赖方向及导入副作用。python -m和按文件执行;其 shim 使用静态绝对导入及__main__guard,清单用script_entry: main登记这一入口。仓库外 wheel 检查覆盖新旧两个模块、两种启动方式,比较退出码、空标准流及 result.json 字节。_runtime_identity()中 campaign 源文件路径,改为apps/workflows/campaign.py;评测工具的 controller 快照也指向实际实现。完整摘要表校验继续拒绝不匹配的 runtime。Checks and dependencies
Windows / Python 3.12 本地验证,以下为独立运行结果,存在覆盖重叠:
-I check_installed.py扩展回归的 Windows 基线缺口未改动:
write_text转换换行,合成判定中的 LF 字符串不匹配;同样五项在 base 复现。构建依赖的联网下载遇到间歇 TLS 失败,随后使用已缓存的公开依赖完成隔离构建与安装验证。没有修改依赖、CI 车道、冻结证据或历史 validator。当前变更不触及 Knowledge authorship policy 的受保护路径。
Remaining work and Issue closure
本 PR 交付 workflows 切片。#490 第四步 integrations 和第五步集成验收仍待实施,#371 仍跟踪整体 Apps 落地及生产联调。Issue 完成由 Apps 负责人结合接口 owner 的检视确认;本 PR 不宣告整个 Issue 完成。
请 Dong1017 复核 Harness 摘要路径与恢复边界,david6666666 复核跨版本意见的落实;Amy 可补充独立检视。Ready 状态提交,合入依现行两份有效独立审批及检查结果执行 squash。