Repository navigation
feat: support ReduceScatter for NCCL backend - #80
Merged
Merged
Conversation
whjthu
force-pushed
the
refactor/modern-infini-stack-review
branch
from
October 18, 2026 13:23
8e3ecf0 to
6f329f8
Compare
ReduceScatter for NCCL backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
ReduceScattersupport for the NCCL backend using the existing NCCL API surface.Changes
CclReduceScatterImplinsrc/backends/ccl/common/impl/reduce_scatter.h. It checks the intra-communicator, mapsDataType/ReductionOpTypeto backend types, and calls the backendReduceScatter.ncclReduceScatterinsrc/backends/ccl/nccl/api.h.src/backends/ccl/nccl/impl/reduce_scatter.hviaBackendEnabled<ReduceScatter, BackendType::kNccl>, so the generated bridge emits real dispatch instead of a stub.Platform and Backend Affected
Platform
Backend
Performance Impact
N/A.
Known Issues & Future Work
ReduceScatterexample yet (examples/ccl_mpi_hybrid/), which may or may not be supplied in the future.Test Results
Test Involved Platform
Test Involved Backend
NVIDIA + NCCL (Single Node):
Environment: single node, 8× NVIDIA L40
ccl_reduce_scatter.log
ccl_send_recv.log
ccl_all_gather.log
ccl_all_reduce.log
Checklist
Title, Branch, and Commits
feat: …,fix(nccl): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).master— the branch is rebased cleanly on top of the currentmaster.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).the `AllReduce` implementation) (CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General; §Python).C++ Specific (if C++ files changed)
clang-format(version 16, per.github/workflows/clang-format.yml) has been run against all modified applicable files; the diff is clean.assertwith messages that include at least__FILE__,__LINE__, and__func__(CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).Python Specific (if Python files changed)
Testing
Build, CI, and Tooling
CMakeLists.txtunderif(AUTO_DETECT_DEVICES)or toif(AUTO_DETECT_BACKENDS)if applicable.clang-format.yml,ruff.yml) are green locally (or expected to be green on CI).Documentation
README.md,CONTRIBUTING.md, or inline docs updated when behavior, build flags, or developer workflow changed.!orBREAKING CHANGE:footer.Security and Safety