Repository navigation
refactor: modularize CMake discovery - #81
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR keeps the high-level build flow visible in the root
CMakeLists.txtwhile moving platform- and backend-specific detection and dependency setup into focused modules undercmake/devicesandcmake/backends.This PR also standardizes device auto-detection so a device explicitly enabled with
WITH_*=ONremains enabled while auto-detection adds other detected devices.No runtime API, collective algorithm, or intended platform behavior changes.
Changes
Central CMake Orchestration
CMakeLists.txt.Device-specific Modules
infiniccl_resolve_device_detectionto preserve explicitWITH_*=ONselections and probe only devices that were not explicitly requested.Backend-specific Modules
Behavior Preservation and Documentation
PrintResulthelper inexamples/ccl/reduce_scatter.ccto avoid the compiler's missing-return warning.Platform and Backend Affected
Platform
Backend
Performance Impact
N/A. This PR reorganizes configure-time discovery and preserves existing build behavior; it does not change runtime communication paths or collective algorithms.
Known Issues & Future Work
Test Results
Test Involved Platform
Test Involved Backend
NVIDIA+MetaX+Moore with OMPI:
mpi_all_gather.log
mpi_all_reduce.log
mpi_all_to_all.log
mpi_broadcast.log
mpi_gather.log
mpi_reduce.log
mpi_reduce_scatter.log
mpi_scatter.log
mpi_send_recv.log
Iluvatar with NCCL:
ccl_all_gather.log
ccl_all_reduce.log
ccl_reduce_scatter.log
ccl_send_recv.log
HYGON with RCCL+OMPI:
ccl_mpi_hybrid_all_gather.log
ccl_mpi_hybrid_all_reduce.log
ccl_mpi_hybrid_send_recv.log
T-Head with NCCL:
ccl_all_gather.log
ccl_all_reduce.log
ccl_reduce_scatter.log
ccl_send_recv.log
Cambricon with CNCL:
ccl_mpi_hybrid_all_gather.log
ccl_mpi_hybrid_all_reduce.log
ccl_mpi_hybrid_send_recv.log
Checklist
Title, Branch, and Commits
feat: …,fix(nccl): …).<type>/xxx-yyyy-zzzzwhere<type>matches the PR title's Conventional Commits type and words are joined with hyphens (seeCONTRIBUTING.md§Branches).CONTRIBUTING.md§Pull Requests).master— the branch is rebased cleanly on top of the currentmaster.fixup!/squash!/wipcommits remain.Scope and Design
CONTRIBUTING.md§Code/General).printf/std::cout/print(...)left behind, orTODOwithout an owner and issue link.General Code Hygiene
CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).the `AllReduce` implementation) (CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General).CONTRIBUTING.md§Code/General; §Python).C++ Specific (if C++ files changed)
clang-format(version 16, per.github/workflows/clang-format.yml) has been run against all modified applicable files; the diff is clean.assertwith messages that include at least__FILE__,__LINE__, and__func__(CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).CONTRIBUTING.md§C++).Python Specific (if Python files changed)
Testing
Build, CI, and Tooling
CMakeLists.txtunderif(AUTO_DETECT_DEVICES)or toif(AUTO_DETECT_BACKENDS)if applicable.clang-format.yml,ruff.yml) are green locally (or expected to be green on CI).Documentation
README.md,CONTRIBUTING.md, or inline docs updated when behavior, build flags, or developer workflow changed.!orBREAKING CHANGE:footer.Security and Safety