Repository navigation
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FusedQkNormRope.fused_qk_norm_rope, includingforced_token_heads_per_warp = -1for automatic scheduling.qkvtensors of shape[tokens, (Hq + Hk + Hv) * D], with separate one-dimensionalq_weightandk_weighttensors. The V section is preserved unchanged.dfce2a5f0ec2a2a9428cb4cc897a344eb7a8f725, which includes the dynamic source-index lowering fix required by the paired-weight expression.Current Fast Path
The NineToothed provider currently supports NVIDIA, BF16,
head_dim == 128, full-dimension RoPE, NeoX layout, contiguous packed QKV, contiguous int64 positions, and automaticforced_token_heads_per_warp == -1. Explicit positive forced-warp values are intentionally reported unsupported because scheduling remains delegated to this provider.Validation
16b6639on latest master3fac025.580.105.08, CUDA12.6.77.pytest -q tests/test_fused_qk_norm_rope.py --devices cuda: 4 passed.seq_len=1,17, 16 Q heads, 8 K heads, 8 V heads, BF16, D128, full NeoX RoPE, and both omitted and explicitforced_token_heads_per_warp=-1.ruff format --check,ruff check,clang-format --dry-run --Werror, andgit diff --checkpassed.