Repository navigation
Cast RMSNorm epsilon for AOT - #108
Merged
Merged
Conversation
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NineToothed represents floating-point scalar arguments as
fp64in shared Triton AOT signatures. RMSNorm added that scalar directly to an FP32 accumulator before callingsqrt, so Ascend Triton rejected the operation because itssqrtdoes not acceptfp64.Cast epsilon to FP32 before adding it to the FP32 accumulator. This preserves the public scalar ABI while keeping the square-root input in the accumulator dtype.
pytestoutput:Ascend validation used 910B4, Python 3.11.13, Torch/torch_npu 2.6.0, triton-ascend 3.2.0, NineToothed PR #240 plus stacked PR
ssen0829/ninetoothed#2:triton-adapter-optwith SIGSEGV; this is a compiler-level limitation independent of the epsilon cast.