COMP: Link ITK::ITKVtkGlueModule in examples that include QuickView.h - #478
Draft
hjmjohnson wants to merge 1 commit into
Draft
COMP: Link ITK::ITKVtkGlueModule in examples that include QuickView.h#478hjmjohnson wants to merge 1 commit into
hjmjohnson wants to merge 1 commit into
Conversation
Fifty examples include "QuickView.h" under #ifdef ENABLE_QUICKVIEW, but
forty-nine never linked ITK::ITKVtkGlueModule, the module that provides
that header. Its include directory therefore never reached the compile
line and the build failed with:
Code.cxx:23:12: fatal error: 'QuickView.h' file not found
src/CMakeLists.txt defines ENABLE_QUICKVIEW only when VTK is found, so a
configure without VTK compiles the guarded include out and the omission
is invisible. It appears only in a build that has VTK available.
Bridge/VtkGlue/VTKImageToITKImage already linked the module and supplied
the spelling used here.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01S5zzoU6yyUwdLEvjM2s6iS
dzenanz
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forty-nine of the fifty examples that
#include "QuickView.h"never linkedITK::ITKVtkGlueModule, the module that provides that header, so the build fails withfatal error: 'QuickView.h' file not foundwhenever VTK is present. One line added per example; no other changes.Why this is not visible in a normal build
src/CMakeLists.txtsetsENABLE_QUICKVIEWandadd_definitions(-DENABLE_QUICKVIEW)only when VTK is found. Every affectedCode.cxxguards the include:Without VTK the include is compiled out and the missing link is harmless. With VTK the include fires, but because the target never links
ITK::ITKVtkGlueModule, that module's include directory is absent from the compile line:Bridge/VtkGlue/VTKImageToITKImagewas the single example already linking the module, and supplied the spelling used throughout this change.Shape of the change
Pure insertions — 49 files, one identical line each, nothing removed:
if(ENABLE_QUICKVIEW)link block; the entry is added beside${VTK_LIBRARIES}.pre-commit run --all-filespasses,gersemiincluded, so the additions match the project's CMake formatting.How it was found and verified
Surfaced by a downstream build testbed that builds ITKSphinxExamples against a locally built ITK with VTK available, so
ENABLE_QUICKVIEWis on. Before the change the build stopped insrc/Core/Common/IterateLineThroughImageand two sibling examples; after it, the suite configures and builds through to its test phase.Verified against ITK
mainwithModule_ITKVtkGlue=ON.🤖 Generated with Claude Code
https://claude.ai/code/session_01S5zzoU6yyUwdLEvjM2s6iS