Repository navigation
[MAINT] Add chron job for updating OS compiler dependencies - #2408
ndgrigorian wants to merge 1 commit into
Conversation
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2408/index.html |
|
coverage: 74.989%. remained the same — chron-job-to-update-os-compiler-dependencies into master |
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
A couple of minor nits. In overall, LGTM,
| with: | ||
| path: | | ||
| /home/runner/work/sycl_bundle | ||
| key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('/home/runner/work/sycl_bundle/bundle_id.txt') }} |
There was a problem hiding this comment.
The cache is saved once and never refreshed. After every pin bump, each run downloads the deps again. Keying on hashFiles('.github/sycl-build-deps.env') would fix it.
| [[ "${LLVM_REF}" =~ ^[A-Za-z0-9._/-]+$ ]] || fail "invalid intel/llvm ref: ${LLVM_REF}" | ||
| LLVM_SHA=$(gh api "repos/intel/llvm/commits/${LLVM_REF}" --jq .sha) |
There was a problem hiding this comment.
The input's pattern allows .., which can point the gh api call at another path. The SHA that comes back isn't checked either. Only people who can run the workflow manually can supply the input.
As an option we can add [[ $LLVM_SHA =~ ^[0-9a-f]{40}$ ]], and optionally reject ...
This PR proposes the addition of a chron job for updating the dependencies of the OS compiler workflow