Repository navigation
Add sycl_platform::has_aspect properties - #2412
Open
ndgrigorian wants to merge 2 commits into
Open
ndgrigorian wants to merge 2 commits into
ndgrigorian wants to merge 2 commits into
Conversation
ndgrigorian
requested review from
antonwolfy and
vlad-perevezentsev
as code owners
November 3, 2026 21:05
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2412/index.html |
Collaborator
|
coverage: 74.93% (+0.04%) from 74.893% — add-sycl-platform-info-queries into master |
There was a problem hiding this comment.
🟡 Changes recommended
The three new extension-aspect properties are missing from both Python and C++ test lists, leaving their property smoke checks and platform/device agreement checks uncovered.
1 open issue
What changed in this PR
This PR adds platform-wide aspect queries to dpctl.SyclPlatform, exposing capabilities supported by all devices on a platform.
Changes:
- Adds a C API aspect query and its Cython binding.
- Exposes 22
has_aspect_*properties with docstrings and refreshes the documentedlsplatformoutput. - Adds Python and C++ checks for standard aspects, platform/device agreement, and null-platform handling.
| File | Description |
|---|---|
| libsyclinterface/tests/test_sycl_platform_interface.cpp | Tests aspect queries against device capabilities and null platforms. |
| libsyclinterface/source/dpctl_sycl_platform_interface.cpp | Implements the platform aspect query with error handling. |
| libsyclinterface/include/syclinterface/dpctl_sycl_platform_interface.h | Declares and documents the new C API. |
| dpctl/tests/test_sycl_platform.py | Adds property checks and platform/device agreement tests. |
| dpctl/_sycl_platform.pyx | Adds aspect properties and updates output examples in documentation. |
| dpctl/_backend.pxd | Declares the C API function for Cython use. |
Review effort: Balanced
antonwolfy
reviewed
Nov 4, 2026
antonwolfy
left a comment
antonwolfy
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, this looks good overall. A few points inline. The main one is that three of the new properties aren't covered by the tests. Could you also add a line to CHANGELOG.md under [dev] / Added for the new SyclPlatform.has_aspect_* properties?
antonwolfy
reviewed
Nov 4, 2026
Cover is_component, is_composite and ext_oneapi_ipc_memory in the Python and C-API platform aspect tests, note empty platforms in the docstrings, document the false-on-error return, and add a changelog entry.
ndgrigorian
force-pushed
the
add-sycl-platform-info-queries
branch
from
November 4, 2026 19:21
8560194 to
efd37c7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes the addition of the
sycl_platform::has_aspectproperties todpctl.SyclPlatform