Repository navigation
Drop -fno-sycl-id-queries-fit-in-int from dpctl extensions - #2413
Merged
Merged
Conversation
The option was added for dpctl.tensor kernels in 9af90dd (gh-1184) and stayed in build_dpctl_ext and dpctl/utils after dpctl.tensor moved to dpnp. None of these modules launches a kernel over a range: _sycl_queue, dpctl.memory and _device_queries contain no device kernels, and _seq_order_keeper only submits an empty single_task. Starting with DPC++ 2026.2 the ID range is recorded at the device link step, so passing the option only at compile time has no effect anyway.
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
November 4, 2026 11:49
There was a problem hiding this comment.
🟢 Approval recommended
The compile-option cleanup has no active review issues.
No open issues 🎉
What changed in this PR
Removes the unnecessary -fno-sycl-id-queries-fit-in-int compile option from dpctl extensions following the move of dpctl.tensor to dpnp. Runtime kernel compilation remains unchanged.
Changes:
- Removes the option from SYCL-enabled Cython extensions and utility pybind11 extensions.
- Records the cleanup in the changelog.
| File | Description |
|---|---|
dpctl/utils/CMakeLists.txt |
Removes the option from utility pybind11 targets. |
dpctl/CMakeLists.txt |
Removes the option from build_dpctl_ext(... SYCL) targets. |
CHANGELOG.md |
Documents the compile-option removal under Maintenance. |
Review effort: Balanced
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Collaborator
|
coverage: 74.893%. remained the same — drop-id-queries-fit-in-int into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dpctl passes
-fno-sycl-id-queries-fit-in-intas a compile option to the Cython extensions built bybuild_dpctl_ext(... SYCL)(_sycl_queue,dpctl.memory) and to the pybind11 extensions indpctl/utils(_device_queries,_seq_order_keeper). The option was added fordpctl.tensorkernels in 9af90dd to fix gh-1184, and it stayed in these files afterdpctl.tensormoved to dpnp.None of these modules launches a kernel over a range.
_sycl_queue,dpctl.memoryand_device_queriescontain no device kernels (their SYCL offload section is an empty stub), and_seq_order_keeperonly submits an emptysingle_task. So the option has no effect on them.Starting with DPC++ 2026.2, the ID range is recorded at the device link step (see IntelPython/dpnp#3089), so passing the option only at compile time would not allow launches over
INT_MAXwork-items even if these modules had such kernels. Instead of also adding it as a link option, this PR removes it. A kernel added later that can run over more thanINT_MAXwork-items will need it at both compile and link time.This doesn't change kernels compiled at runtime by
dpctl.compiler.create_kernel_bundle_from_sycl_source, which don't use these build options.