Repository navigation
Revert gh-2411 - #2417
Merged
Merged
Revert gh-2411#2417
Conversation
The tarball extracts read-only directories, so removing a stale install failed silently and the cached runtime was used.
ndgrigorian
requested review from
antonwolfy and
vlad-perevezentsev
as code owners
November 4, 2026 17:29
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Collaborator
|
coverage: 74.893%. remained the same — revert-gh-2411 into master |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the dependency rollback and workflow-hardening changes.
No open issues 🎉
What changed in this PR
Reverts the SYCL dependency update from gh-2411 to avoid the reported CPU runtime shutdown crash, and hardens dependency replacement in the OS compiler workflow.
Changes:
- Rolls back oclcpuexp to 2026-WW28 and oneTBB to 2023.1.0.
- Restores write permissions before removing cached dependency installs.
- Makes removal, extraction, and OpenCL library copy failures stop the workflow.
| File | Description |
|---|---|
.github/workflows/os-llvm-sycl-build.yml |
Hardens cached dependency cleanup and installation error handling. |
.github/sycl-build-deps.env |
Restores the previous oclcpuexp and oneTBB pins. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts gh-2411, which bumped oclcpuexp to 2026-WW42 and broke the OS compiler workflow
The workflow passed on gh-2411 only because the run restored the previous sycl bundle cache and kept using the old CPU runtime (
rm -rf oclcpuexpfailed silently and the new tarball was never extracted). Every run since installed the new runtime and aborts at exit withThe abort comes from libsycl releasing cached sub-devices in its own destructor. When a library depending on libsycl is loaded after SYCL starts up, libsycl's destructor runs after the CPU runtime's, and the new runtime returns
CL_INVALID_OPERATIONfromclReleaseDevice. This has been reproduced in SYCL.Additionally fixes the workflow so that a pin change replaces the cached oclcpuexp and oneTBB installs, and fails if it can't