Skip to content

Revert gh-2411 - #2417

Merged
ndgrigorian merged 2 commits into
masterfrom
revert-gh-2411
Nov 4, 2026
Merged

ndgrigorian merged 2 commits into
masterfrom
revert-gh-2411

Conversation

@ndgrigorian

@ndgrigorian ndgrigorian commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

This PR reverts gh-2411, which bumped oclcpuexp to 2026-WW42 and broke the OS compiler workflow

The workflow passed on gh-2411 only because the run restored the previous sycl bundle cache and kept using the old CPU runtime (rm -rf oclcpuexp failed silently and the new tarball was never extracted). Every run since installed the new runtime and aborts at exit with

python: /__w/llvm/llvm/src/unified-runtime/source/adapters/opencl/device.hpp:51: ur::opencl::ur_device_handle_t_::~ur_device_handle_t_(): Assertion `Res == CL_SUCCESS' failed.

The abort comes from libsycl releasing cached sub-devices in its own destructor. When a library depending on libsycl is loaded after SYCL starts up, libsycl's destructor runs after the CPU runtime's, and the new runtime returns CL_INVALID_OPERATION from clReleaseDevice. This has been reproduced in SYCL.

Additionally fixes the workflow so that a pin change replaces the cached oclcpuexp and oneTBB installs, and fails if it can't

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

oclcpuexp 2026-WW42 fails clReleaseDevice on sub-devices at process exit, aborting the OS compiler workflow.
The tarball extracts read-only directories, so removing a stale install failed silently and the cached runtime was used.
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 74.893%. remained the same — revert-gh-2411 into master

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the dependency rollback and workflow-hardening changes.

No open issues 🎉

What changed in this PR

Reverts the SYCL dependency update from gh-2411 to avoid the reported CPU runtime shutdown crash, and hardens dependency replacement in the OS compiler workflow.

Changes:

  • Rolls back oclcpuexp to 2026-WW28 and oneTBB to 2023.1.0.
  • Restores write permissions before removing cached dependency installs.
  • Makes removal, extraction, and OpenCL library copy failures stop the workflow.
File Description
.github/​workflows/​os-llvm-sycl-build.yml Hardens cached dependency cleanup and installation error handling.
.github/​sycl-build-deps.env Restores the previous oclcpuexp and oneTBB pins.

Review effort: Balanced

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndgrigorian
ndgrigorian merged commit 620238f into master Nov 4, 2026
141 checks passed
@ndgrigorian
ndgrigorian deleted the revert-gh-2411 branch November 4, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants