Repository navigation
Declare the test C extension free-threading compatible - #2421
Open
ndgrigorian wants to merge 1 commit into
Open
ndgrigorian wants to merge 1 commit into
ndgrigorian wants to merge 1 commit into
Conversation
_c_ext uses multi-phase init with Py_mod_gil, so loading it no longer re-enables the GIL, and test_headers errors if it does.
ndgrigorian
requested review from
antonwolfy and
vlad-perevezentsev
as code owners
November 5, 2026 17:59
Collaborator
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2421/index.html |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the warning emitted by
test_c_headerson free-threaded builds of CPython, where loading the_c_exttest extension re-enabled the GIL for the rest of the test session_c_extnow uses multi-phase initialization and declaresPy_mod_gilasPy_MOD_GIL_NOT_USED, as thepy_sycl_lsC example already does, and the fixture loading it turns theRuntimeWarninginto an error so that this does not regress