Repository navigation
Remove the legacy backend RNG - #3163
Open
ndgrigorian wants to merge 1 commit into
Open
ndgrigorian wants to merge 1 commit into
ndgrigorian wants to merge 1 commit into
Conversation
ndgrigorian
requested review from
antonwolfy and
vlad-perevezentsev
as code owners
November 4, 2026 19:46
This was referenced Nov 4, 2026
ndgrigorian
force-pushed
the
feature/remove-legacy-rng
branch
from
November 4, 2026 19:47
68eef44 to
d7cce7f
Compare
ndgrigorian
force-pushed
the
feature/device-rng-random-state
branch
from
November 4, 2026 19:47
315889e to
142a3d8
Compare
dpnp.random no longer uses dpnp_backend_c, so drop the dpnp_algo_random Cython module, the backend RNG kernels, DPNPRandomState, the DPNP_FN_RNG_* function pointers, the backend engines and their examples and tests, and the now-unused parts of the backend, including its GTest suite, the DPNP_BACKEND_TESTS option and call_origin. The conda recipes no longer pin onemkl-sycl-rng.
ndgrigorian
force-pushed
the
feature/remove-legacy-rng
branch
from
November 4, 2026 19:50
d7cce7f to
71b2060
Compare
ndgrigorian
force-pushed
the
feature/device-rng-random-state
branch
from
November 4, 2026 19:50
142a3d8 to
160719a
Compare
Contributor
|
Array API standard conformance tests for dpnp=0.22.0dev0=np2py314h8d9cdd5_33 ran successfully. |
Collaborator
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/3163/index.html |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the legacy RNG implementation of
dpnp.randomfromdpnp_backend_c, along with the newly-dead code in the backend, as the last part of the series splitting #3147. It is stacked on #3162Removes
dpnp_algo_randomCython module, the backend RNG kernels,DPNPRandomState, theDPNP_FN_RNG_*function pointers and the mt19937/mcg59 engines ofbackend_syclDPNP_BACKEND_TESTSCMake optioncall_originand the other helpers that only the RNG usedonemkl-sycl-rngpin in the conda recipesdpnp_backend_citself stays, sincedpnp.partitionstill uses it (#3138 removes that)