Skip to content

Remove the legacy backend RNG - #3163

Open
ndgrigorian wants to merge 1 commit into
feature/device-rng-random-statefrom
feature/remove-legacy-rng
Open

ndgrigorian wants to merge 1 commit into
feature/device-rng-random-statefrom
feature/remove-legacy-rng

Conversation

@ndgrigorian

@ndgrigorian ndgrigorian commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

This PR removes the legacy RNG implementation of dpnp.random from dpnp_backend_c, along with the newly-dead code in the backend, as the last part of the series splitting #3147. It is stacked on #3162

Removes

  • The dpnp_algo_random Cython module, the backend RNG kernels, DPNPRandomState, the DPNP_FN_RNG_* function pointers and the mt19937/mcg59 engines of backend_sycl
  • The backend's C++ examples, its GTest suite and the DPNP_BACKEND_TESTS CMake option
  • The NumPy fallback helper call_origin and the other helpers that only the RNG used
  • The onemkl-sycl-rng pin in the conda recipes

dpnp_backend_c itself stays, since dpnp.partition still uses it (#3138 removes that)

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

dpnp.random no longer uses dpnp_backend_c, so drop the dpnp_algo_random
Cython module, the backend RNG kernels, DPNPRandomState, the
DPNP_FN_RNG_* function pointers, the backend engines and their examples
and tests, and the now-unused parts of the backend, including its GTest
suite, the DPNP_BACKEND_TESTS option and call_origin. The conda recipes
no longer pin onemkl-sycl-rng.
@ndgrigorian
ndgrigorian force-pushed the feature/remove-legacy-rng branch from d7cce7f to 71b2060 Compare November 4, 2026 19:50
@ndgrigorian
ndgrigorian force-pushed the feature/device-rng-random-state branch from 142a3d8 to 160719a Compare November 4, 2026 19:50
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Array API standard conformance tests for dpnp=0.22.0dev0=np2py314h8d9cdd5_33 ran successfully.
Passed: 1491
Failed: 0
Skipped: 6

@coveralls

coveralls commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Status

Coverage is 82.849% — feature/remove-legacy-rng into feature/device-rng-random-state. No base build found for feature/device-rng-random-state.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/3163/index.html

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants