Skip to content

Pass depends to the _place call in dpnp.tensor.place #3164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonwolfy merged 4 commits into from
Nov 5, 2026
Merged

Pass depends to the _place call in dpnp.tensor.place #3164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a80c5c5
Pass depends to the _place call in dpnp.tensor.place
ndgrigorian Nov 5, 2026
ef842c0
Add PR number to the changelog entry
ndgrigorian Nov 5, 2026
aa09cc6
Reword the place changelog entry to describe event ordering
ndgrigorian Nov 5, 2026
d6b1055
Merge branch 'master' into fix-place-missing-depends
antonwolfy Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

* Fixed `flags[key]` of `dpnp.ndarray` and `dpnp.tensor.usm_ndarray` to raise `KeyError` for an unknown key [#3141](https://github.com/IntelPython/dpnp/pull/3141)
* Released the GIL around the oneMKL VM calls in the VM extension, which deadlocked on an in-order queue of a CPU device [#3156](https://github.com/IntelPython/dpnp/pull/3156)
* Fixed `dpnp.place` and `dpnp.tensor.place` to order the write after the cast of `vals` to the array's data type, which could put wrong values into the array on an out-of-order queue [#3164](https://github.com/IntelPython/dpnp/pull/3164)

### Security

Expand Down
1 change: 1 addition & 0 deletions dpnp/tensor/_indexing_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ def place(arr, mask, vals):
axis_end=mask.ndim,
rhs=rhs,
sycl_queue=exec_q,
depends=_manager.submitted_events,
Comment thread
ndgrigorian marked this conversation as resolved.
Resolved
)
_manager.add_event_pair(hev, pl_ev)

Expand Down
Loading