Skip to content

test: remove unnecessary null-forgiving operators after IsNotNull asserts #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BenjaminMichaelis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: remove unnecessary null-forgiving operators after IsNotNull asserts #1603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions EssentialCSharp.Web.Tests/McpApiTokenServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public async Task CreateTokenAsync_WithoutExpiry_UsesSixMonthDefault()
(_, var entity) = await tokenService.CreateTokenAsync(userId, "default-expiry");

await Assert.That(entity.ExpiresAt).IsNotNull();
await Assert.That(entity.ExpiresAt!.Value)
await Assert.That(entity.ExpiresAt.Value)
.IsEqualTo(McpApiTokenService.GetDefaultExpirationUtc(entity.CreatedAt));
}

Expand All @@ -58,7 +58,7 @@ public async Task CreateTokenAsync_WithExpiryWithinSixMonths_UsesRequestedExpiry
(_, var entity) = await tokenService.CreateTokenAsync(userId, "custom-expiry", requestedExpiry);

await Assert.That(entity.ExpiresAt).IsNotNull();
await Assert.That(entity.ExpiresAt!.Value).IsEqualTo(requestedExpiry);
await Assert.That(entity.ExpiresAt.Value).IsEqualTo(requestedExpiry);
}

[Test]
Expand All @@ -83,7 +83,7 @@ public async Task CreateTokenAsync_WithExplicitCreatedAt_UsesReferenceTimeForDef

await Assert.That(entity.CreatedAt).IsEqualTo(createdAtUtc);
await Assert.That(entity.ExpiresAt).IsNotNull();
await Assert.That(entity.ExpiresAt!.Value)
await Assert.That(entity.ExpiresAt.Value)
.IsEqualTo(McpApiTokenService.GetDefaultExpirationUtc(createdAtUtc));
}

Expand Down
2 changes: 1 addition & 1 deletion EssentialCSharp.Web.Tests/PwnedPasswordValidatorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public async Task ValidateAsync_SendsCorrectKAnonymityRequest()
await validator.ValidateAsync(manager, new IdentityUser("testuser"), "password");

await Assert.That(capturedRequest).IsNotNull();
await Assert.That(capturedRequest!.RequestUri!.PathAndQuery).IsEqualTo("/range/5BAA6");
await Assert.That(capturedRequest.RequestUri!.PathAndQuery).IsEqualTo("/range/5BAA6");
await Assert.That(capturedRequest.Headers.Contains("Add-Padding")).IsTrue();
await Assert.That(capturedRequest.Headers.GetValues("Add-Padding").Single()).IsEqualTo("true");
}
Expand Down
Loading