Skip to content

feature(ci, nightly-dispatcher): improve nightly dispatcher with yanked and unmaintained crates verification - #3613

Merged
turmelclem merged 2 commits into
mainfrom
ctl/3589-detect-yanked-crates-in-the-CI
Oct 12, 2026
Merged

turmelclem merged 2 commits into
mainfrom
ctl/3589-detect-yanked-crates-in-the-CI

Conversation

@turmelclem

@turmelclem turmelclem commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Content

improve nightly dispatcher with yanked and unmaintained crates verification :

  • add a advisories section in the existing deny.toml (no impact for the current cargo-deny check licenses execution)
  • add a job in the nightly-dispatcher.yml to run cargo-deny check advisories
    • it will put in error any yanked and vulnerabilities that are not in ignore section
    • we can flag in ignore section known crates that we want to replace in the future
  • introduce a new weekly job running a full check advisories for yanked, unmaintained and vulnerabilities (no ignore)

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Comments

Can be manually run :

  • installation : cargo install --locked cargo-deny
  • run : cargo deny check advisories

Issue(s)

his PR relates to or closes #3589

@turmelclem turmelclem self-assigned this Oct 8, 2026
@turmelclem turmelclem added CI/CD 🏭 CI/CD feature 🚀 New implemented feature labels Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Test Results

     5 files  ±0     226 suites  ±0   47m 32s ⏱️ -33s
 3 983 tests ±0   3 983 ✅ ±0  0 💤 ±0  0 ❌ ±0 
12 596 runs  ±0  12 596 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e75fbdd. ± Comparison against base commit b57fd15.

♻️ This comment has been updated with latest results.

@turmelclem
turmelclem deployed to testing-preview October 8, 2026 15:36 — with GitHub Actions Active
@turmelclem
turmelclem deployed to testing-2-preview October 8, 2026 15:36 — with GitHub Actions Active
@turmelclem
turmelclem force-pushed the ctl/3589-detect-yanked-crates-in-the-CI branch from 5f86b4b to 781ac6c Compare October 9, 2026 13:07
@turmelclem
turmelclem deployed to testing-preview October 9, 2026 13:38 — with GitHub Actions Active
@turmelclem
turmelclem deployed to testing-2-preview October 9, 2026 13:38 — with GitHub Actions Active
@turmelclem
turmelclem force-pushed the ctl/3589-detect-yanked-crates-in-the-CI branch 2 times, most recently from 7f256b3 to 646281a Compare October 9, 2026 14:38
@turmelclem
turmelclem deployed to testing-preview October 9, 2026 14:55 — with GitHub Actions Active
@turmelclem
turmelclem deployed to testing-2-preview October 9, 2026 14:55 — with GitHub Actions Active
@turmelclem
turmelclem marked this pull request as ready for review October 9, 2026 15:25
@jpraynaud
jpraynaud requested a lite review from Copilot October 9, 2026 15:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The weekly workflow contains an invalid step that prevents the check from running.

2 open findings
What changed in this PR

Adds cargo-deny advisory checks for nightly and weekly CI, covering yanked, vulnerable, and unmaintained crates.

Changes:

  • Adds advisory policies and known exceptions.
  • Adds nightly advisory validation.
  • Adds a strict weekly advisory scan.
File Description Review note
deny.toml Advisory handling and ignores Clarify the rationale for the direct rustls dependency exception.
.github/​workflows/​weekly-dispatcher.yml Weekly full advisory check Fix the invalid step lacking run or uses.
.github/​workflows/​nightly-dispatcher.yml Nightly advisory check —
.config/​deny-full.toml Strict weekly advisory configuration —

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/weekly-dispatcher.yml Outdated
Comment thread deny.toml Outdated

@Alenar Alenar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, about the ignore list, maybe we should raise an error instead of a warning if an ignore advisories go unused (which may after every-time we update our dependencies).
Else I fear that the list will grow indefinitly.

Comment thread .github/workflows/weekly-dispatcher.yml
Comment thread .github/workflows/weekly-dispatcher.yml Outdated
Comment thread deny.toml Outdated

@jpraynaud jpraynaud left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@turmelclem
turmelclem force-pushed the ctl/3589-detect-yanked-crates-in-the-CI branch from 646281a to 349caf6 Compare October 12, 2026 09:09
@turmelclem
turmelclem force-pushed the ctl/3589-detect-yanked-crates-in-the-CI branch 2 times, most recently from 02793a2 to 5baffd5 Compare October 12, 2026 09:23
@turmelclem
turmelclem force-pushed the ctl/3589-detect-yanked-crates-in-the-CI branch from 5baffd5 to e75fbdd Compare October 12, 2026 09:26
@turmelclem
turmelclem deployed to testing-2-preview October 12, 2026 09:39 — with GitHub Actions Active
@turmelclem
turmelclem deployed to testing-preview October 12, 2026 09:39 — with GitHub Actions Active
@turmelclem
turmelclem merged commit 303db73 into main Oct 12, 2026
101 checks passed
@turmelclem
turmelclem deleted the ctl/3589-detect-yanked-crates-in-the-CI branch October 12, 2026 10:06

This branch was successfully deployed

2 active deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD 🏭 CI/CD feature 🚀 New implemented feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect yanked crates in the CI

4 participants