Repository navigation
feature(ci, nightly-dispatcher): improve nightly dispatcher with yanked and unmaintained crates verification - #3613
Merged
Conversation
turmelclem
force-pushed
the
ctl/3589-detect-yanked-crates-in-the-CI
branch
from
October 9, 2026 13:07
5f86b4b to
781ac6c
Compare
turmelclem
force-pushed
the
ctl/3589-detect-yanked-crates-in-the-CI
branch
2 times, most recently
from
October 9, 2026 14:38
7f256b3 to
646281a
Compare
turmelclem
marked this pull request as ready for review
October 9, 2026 15:25
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The weekly workflow contains an invalid step that prevents the check from running.
2 open findings
What changed in this PR
Adds cargo-deny advisory checks for nightly and weekly CI, covering yanked, vulnerable, and unmaintained crates.
Changes:
- Adds advisory policies and known exceptions.
- Adds nightly advisory validation.
- Adds a strict weekly advisory scan.
| File | Description | Review note |
|---|---|---|
deny.toml |
Advisory handling and ignores | Clarify the rationale for the direct rustls dependency exception. |
.github/workflows/weekly-dispatcher.yml |
Weekly full advisory check | Fix the invalid step lacking run or uses. |
.github/workflows/nightly-dispatcher.yml |
Nightly advisory check | — |
.config/deny-full.toml |
Strict weekly advisory configuration | — |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Alenar
approved these changes
Oct 12, 2026
Alenar
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, about the ignore list, maybe we should raise an error instead of a warning if an ignore advisories go unused (which may after every-time we update our dependencies).
Else I fear that the list will grow indefinitly.
jpraynaud
reviewed
Oct 12, 2026
turmelclem
force-pushed
the
ctl/3589-detect-yanked-crates-in-the-CI
branch
from
October 12, 2026 09:09
646281a to
349caf6
Compare
…ed and unmaintained crates verification
turmelclem
force-pushed
the
ctl/3589-detect-yanked-crates-in-the-CI
branch
2 times, most recently
from
October 12, 2026 09:23
02793a2 to
5baffd5
Compare
…d, unmaintained, vulnerabilities)
turmelclem
force-pushed
the
ctl/3589-detect-yanked-crates-in-the-CI
branch
from
October 12, 2026 09:26
5baffd5 to
e75fbdd
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Content
improve nightly dispatcher with yanked and unmaintained crates verification :
advisoriessection in the existingdeny.toml(no impact for the currentcargo-deny check licensesexecution)nightly-dispatcher.ymlto run cargo-denycheck advisoriesignoresectionignoresection known crates that we want to replace in the futurecheck advisoriesfor yanked, unmaintained and vulnerabilities (no ignore)Pre-submit checklist
Comments
Can be manually run :
cargo install --locked cargo-denycargo deny check advisoriesIssue(s)
his PR relates to or closes #3589