Skip to content

docs: fix DMQ node SRV record prefix - #3619

Merged
jpraynaud merged 1 commit into
mainfrom
jpraynaud/fix-dmq-node-doc
Oct 12, 2026
Merged

jpraynaud merged 1 commit into
mainfrom
jpraynaud/fix-dmq-node-doc

Conversation

@jpraynaud

@jpraynaud jpraynaud commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Content

This PR includes a fix of the SRV record prefix that SPOs publish to declare their DMQ relay node as a ledger peer (CIP-155):

  • Replace _mithril._tcp with _dmq._mithril._cardano._tcp in the signer guide (current and maintained versions)
  • Update the DNS record template, the example and the info box on _cardano._tcp coexistence

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update documentation website (if relevant)

Issue(s)

Closes #3620

Use the '_dmq._mithril._cardano._tcp' prefix registered in CIP-155 and used by the DMQ node, in the current and maintained versions of the signer guide.
Copilot AI lite review requested due to automatic review settings October 12, 2026 08:11
@jpraynaud jpraynaud self-assigned this Oct 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Documentation changes are consistent and no unresolved review issues remain.

0 open findings

What changed in this PR

Updates signer-node documentation to use the CIP-155 DMQ SRV prefix.

Changes:

  • Replaced _mithril._tcp with _dmq._mithril._cardano._tcp.
  • Updated DNS templates, examples, and coexistence guidance.
  • Synchronized current and maintained documentation.
File Description
docs/​website/​versioned_docs/​version-maintained/​manual/​operate/​run-signer-node.md Updated maintained signer guide
docs/​website/​root/​manual/​operate/​run-signer-node.md Updated current signer guide

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@turmelclem turmelclem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions

Copy link
Copy Markdown

Test Results

     5 files  ±0     226 suites  ±0   44m 52s ⏱️ - 18m 3s
 3 983 tests ±0   3 983 ✅ ±0  0 💤 ±0  0 ❌ ±0 
12 596 runs  ±0  12 596 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3b49202. ± Comparison against base commit 6b964a3.

@jpraynaud
jpraynaud deployed to testing-2-preview October 12, 2026 08:23 — with GitHub Actions Active
@jpraynaud
jpraynaud deployed to testing-preview October 12, 2026 08:23 — with GitHub Actions Active
@jpraynaud
jpraynaud merged commit b57fd15 into main Oct 12, 2026
54 checks passed
@jpraynaud
jpraynaud deleted the jpraynaud/fix-dmq-node-doc branch October 12, 2026 08:30

This branch was successfully deployed

2 active deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix DMQ node SRV record prefix in the signer documentation

4 participants