Repository navigation
tako: avoid panic when worker group is missing in multi-node solver - #1153
Closed
pranav-sivaraman wants to merge 1 commit into
Closed
pranav-sivaraman wants to merge 1 commit into
pranav-sivaraman wants to merge 1 commit into
Conversation
Signed-off-by: Pranav Sivaraman <pranavsivaraman@gmail.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Collaborator
|
Good catch. The bug is real but your fix is not correct. The unwrap should stay in the place and multi-node tasks should not be passed into query schedule round. I have fixed it in #1155. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: AI helped investigate and solve this issue.
While testing multi-node tasks, I found that autoscaling crashed the server. Autoscaling uses fake workers whose groups aren't registered in
worker_groups. When a multi-node task was waiting and enough real workers were free, the solver calledunwrap()on that missing group and panicked. This PR skips those workers instead.Added a regression test in
tests/test_query.rs.