Repository navigation
Merge upstream openai/codex main (1,176 commits, past rust-v0.169.0) - #10
Merged
Merged
Conversation
…0637) ## What changed - Replace footer chord hints with a floating guide that shows available completions after a 350 ms delay, including custom prefixes. - Share guide rendering across conversations, transcript overlays, the session picker, startup drafts, hook review, and daemon recovery. Preserve workspace-specific pane labels and filter startup drafts to supported actions. - Adapt the guide to short inline viewports, retain `Esc` cancellation, and redraw when pending chords clear. Consume clicks on the guide so they do not activate controls beneath it. ## Testing Extend tests and snapshots for delayed reveal, timeout, custom prefixes, compact and inline layouts, startup-safe completions, and picker redraws after chord completion or cancellation. GitOrigin-RevId: afa2fe3ae1b5fbea4cd871c17d35206e749c842c
## Why MCP tools marked with `readOnlyHint: true` could still require approval in automatic mode when `destructiveHint` was also true. ## What changed Give `readOnlyHint` precedence over `destructiveHint` and `openWorldHint` when deciding whether annotations require approval. Explicit prompt mode and strict automatic review continue to require their respective approval checks. ## Testing Update unit tests for conflicting annotations, prompt mode, and strict automatic review. Extend app integration coverage to verify that read-only calls proceed while writes prompt in both automatic and writes approval modes. GitOrigin-RevId: 11a930b857886bf41d09fd54c3a38607ae3d1b4e
## Why Holding the session MCP gate during `tools/list` blocks other runtime access. Releasing it requires preventing stale refresh results from publishing after configuration or authentication changes. ## What changed - Capture the Apps client under the session gate, then release the gate before fetching tools. - Validate runtime and authentication state before publishing the shared cache and client catalog; retry a superseded refresh once. - Wait for in-flight Apps refreshes before capturing model tools, preparing Apps calls, or shutting down the runtime. ## Testing Add regression coverage for stale refreshes after runtime invalidation or logout, publication validation after call preparation drains, and a model step that waits for refreshed Apps tools while MCP status queries remain available. GitOrigin-RevId: 42d4be8c4a9218933f8e3d07fc7f32f2da9cbd9d
…0644) ## Why Waiting for host acceptance of a service-tier update in the submission loop can block interrupts while the host receipt is pending. ## What changed Move the host acceptance wait out of the submission loop while keeping explicit thread settings replies pending until acceptance completes. Report handoff failures to the caller while preserving the locally committed settings, and allow a subsequent explicit request for the same tier to retry a failed handoff. ## Testing Add a WebSocket regression test covering interrupts with pending host receipts, failure reporting, same-tier retries, and continued thread operation after startup caller cancellation. GitOrigin-RevId: 1b27d156eba3ebb47e717a987f41f4f595635be8
Pass `can_save: true` when opening the consent dialog and assert that the popup displays “Include logs and session history?”. GitOrigin-RevId: d6035a9a1b3e5114a6e92a6fd31547f02c4980fc
## Why User-configured model catalogs can supply Guardian prompt templates that omit policy slots or add conflicting instructions. Managed rules need a trusted template to reach the reviewer. ## What changed - Use the bundled Guardian policy template when managed policy or additional rules are present, while preserving explicit host-provided templates. - Remove `auto_review.extra_policy` and `auto_review.experimental_policy_template` from configuration and the schema. Warn when they are used, directing additional rules to `guardian_extra_policy` in managed `requirements.toml`. ## Testing Add regression coverage for managed rules with user-supplied catalog templates, explicit host templates, and migration warnings for the removed settings. GitOrigin-RevId: 7f00bfaa85051272ed70ceb2fcb64ffc297b8755
## Why When a workspace has an unreadable ancestor, PowerShell can start with `$PWD` unset and its filesystem drive at the root, breaking relative paths. ## What changed Prefix PowerShell commands in the MXC sandbox with a guarded workaround that restores the location from the process working directory when `$PWD` is unset. Preserve locations already initialized by startup or a profile. ## Testing Extend the MXC PowerShell integration test to cover an unreadable ancestor, checking that `$PWD` matches the process working directory, relative file access works, and the parent and sibling file remain inaccessible. GitOrigin-RevId: 4fb067db52a7f3c6e819169016fe6bd104a277a1
…penai#60651) ## Why Cloud conversations previously used the model returned on activation without exposing model discovery or supporting model changes from the TUI. ## What changed - Fetch the account-scoped Cloud catalog on demand through `/v2/models`, independently of the submission and attachment queue. - Let users stage a supported model and reasoning effort for the next new turn in the current conversation. Send these settings with the user message and show acceptance after successful admission. - Show a loading picker when the catalog is empty, preserve compatibility with Cloud servers that lack discovery, and discard stale catalog results and selections when the account changes. ## Testing Add coverage for catalog request parameters and queue bypass, deferred discovery and compatibility, model and effort serialization, admission outcomes, account invalidation, and opening the picker after discovery. GitOrigin-RevId: 2cd0e7fe5f760d4da9258eefe9f0dcbcd23f9b07
## What changed Add experimental `environments` fields to `turn/settings/update` and `thread/settings/update`. Turn updates apply to later steps of the running turn; thread updates apply to future turns. Omission or `null` preserves the selection, while `[]` clears it. Providing `cwd` in a thread update without an environment list selects the defaults for that directory. Include the ordered environment selection in `thread/settings/updated`. Wait for Core to accept thread settings updates before returning success, and return rejections as request errors. ## Testing Add integration coverage for attaching, replacing, preserving, and clearing environments; rejected updates; and the distinction between later steps and future turns. GitOrigin-RevId: bfebeda57c676be94427aeb0c567c0b94fd9c387
…60662) ## Why Gateway sign-in needs a way to complete authentication over SSH or when no local browser is available. ## What changed - Prefer device authentication for gateways that support it in SSH sessions, headless Linux environments, or when no browser handler is available. - Check the selected session's provider and complete required gateway sign-in before requesting models, including when resuming a thread. - Display the verification URL, one-time code, and cancellation instructions. Handle sign-in results, cancellation, and connection failures while the prompt is open. - Skip device login for older servers that do not support it while preserving errors from current servers. ## Testing Add protocol tests for early sign-in completion, connection loss, provider selection, resumed threads, and legacy-server compatibility, plus snapshots of the device prompt and gateway sign-in loading text. GitOrigin-RevId: 4f3675ab2fc7fccafbad17796c72a7736ebb86b5
…0663) ## Why Remote commands can use workspace paths from a different operating system. Preparing them on the client should preserve those paths and command arguments for the execution host. ## What changed - Build exec-server requests directly, carrying the native command and sandbox context without applying the client's sandbox transform. - Resolve workspace permissions and runtime read access in `SandboxManager` on the execution host, including helper binaries and validated managed-network CA bundles. - Add explicit backend selection and required platform sandbox selection, rejecting launches when the required sandbox is unavailable. ## Testing Extend request tests to cover foreign workspace paths, Unicode arguments, and empty arguments. Extend the remote process test on Unix to verify that restricted reads allow the sandbox helper and validated CA bundle while denying an untrusted certificate file. GitOrigin-RevId: 5fc02ac4208912ecefb80a212742389afc14ac05
…0665) ## Why Code Mode needs a way to forward mixed MCP tool results while preserving their content types and order. ## What changed Add `content(block)` and `content(iterable)` so callers can forward tool output with `content(result.content)`. Text, image, and audio blocks become their corresponding output items; resource links and embedded resources are serialized as text. Invalid blocks and encrypted text are rejected, and iterators are closed when a block is rejected. Share MCP block conversion and image detail types with the protocol layer, while preserving existing `image()` and `audio()` input handling. ## Testing Add coverage for mixed content ordering, iterator behavior and cleanup, invalid blocks, image metadata, short audio clips, and output suppression after exit. Add an integration scenario verifying that MCP text and image blocks reach the model in order. GitOrigin-RevId: 83832ec6c530dd35ea1e3373680627997c6e13c1
…i#60669) ## Why Submodule worktree scans can execute clean filters selected by task-writable Git configuration. ## What changed Pass `--ignore-submodules=dirty` to `git status` in `get_has_changes_in_repo` to skip uncommitted submodule contents while retaining gitlink changes. ## Testing Add a regression test that configures a submodule clean filter and verifies the repository change check does not execute it. The test also confirms that `git status` without the option executes the filter. GitOrigin-RevId: 5330402f0354c3bf9613358575f8bedc9f312886
…i#60670) ## What changed Expose history initialization and the effective history mode to thread-ready contributors. Add `EvidenceCursor::at_thread_ready` with paginated-history validation: - Start new or cleared threads at position zero without requiring an existing rollout. - Start resumed, forked, or supplied-history threads at the durable tail to avoid backfilling existing evidence. - Skip the initial `SessionMeta` header when capturing evidence from position zero. ## Testing Extend evidence tests to cover initialization before a rollout exists, capture of the first original record, rejection of resume without a rollout, and exclusion of existing records on resume. GitOrigin-RevId: 32aa8e2afb71eb4e882b5f1fb107ac8616b33c8e
## What changed - Add a `sign-only` operation to sign macOS CLI packages without notarization. - Validate the configured signing certificate before signing both standard and provisioned packages. - Require the configured team ID for every executable during verification and extend leaf certificate fingerprint checks to standard packages. ## Testing Add coverage for signing a standard package without notarization and rejecting unexpected signing certificates in both standard and provisioned packages. GitOrigin-RevId: 0794c7666abfe981b59b47311e3a9108223b8f57
## Why An accepted agent message may never appear in a later inference request or compaction snapshot. Rollout traces need to retain the delivery and its interaction edge even when the receiving agent makes no further request. ## What changed Capture agent message payloads in `HistoryItemAccepted` events and create conversation items when those receipts are replayed. Reuse each item's ID when it later appears in a request or checkpoint, updating its body to the model-visible representation. Repeated receipts preserve that representation without duplicating the item. ## Testing Extend the spawn-edge regression test to cover delivery before any child inference, stable item IDs across a later request, and preservation of trimmed content after a repeated receipt. GitOrigin-RevId: c193d691e8240645800ce004c11f21e3f1c82915
…enai#60675) ## Why A live parent thread continues receiving lifecycle notifications while its side chat has focus, so returning to it does not need another liveness read. ## What changed - Skip the parent liveness read when returning from a side chat while the parent is still attached and online. Keep the read when reattachment is needed. - Stop scheduling a deferred screen clear when handling a transcript reset that preserves the screen. ## Testing Add regression coverage for parent `thread/read` requests with and without reattachment, and assert that side-chat navigation leaves no deferred screen clear. GitOrigin-RevId: a07f161ec86b0ae51250c5a0156402d328c42bdf
## Why Composer hints could replace configured status content, and mode indicators and warnings reduced the width available to status extensions. ## What changed - Give enabled status content a dedicated area below the composer in both inline and fullscreen layouts, preserving it during transient hint states. - Keep shortcuts, queue hints, mode indicators, and warnings in the hint row. - Measure extension status content at the full available width, allowing up to four rows while yielding space to the composer when height is limited. - Suppress composer hints behind centered dialogs. ## Testing Update layout assertions and snapshots for status persistence, extension resizing and clipping, warning placement, and reasoning-effort transitions. GitOrigin-RevId: f11c2e4fb53c35b69c2fbdbe80cef31bb28faca4
…0681) ## Why Status content and footer hints need to fit within the composer's height budget while preserving room for editing and active search controls. ## What changed - Share row allocation between composer measurement and rendering. Cap status and hints at two rows in inline scrollback, and scale the fullscreen cap from two to four rows with the available budget. - Reserve space for active footer controls, give suggestions and image previews priority over additional status rows, and avoid reserving an empty hints row when status is enabled. - Keep textarea row counts and scroll offsets as `usize`, saturating only the terminal height so very tall drafts remain scrollable with a visible caret. ## Testing Add layout and snapshot coverage for constrained height budgets, status and hints, image previews, slash suggestions, and transcript search cursors. Add a regression test for rendering a draft beyond the `u16` row limit. GitOrigin-RevId: 20fb0384ffc976dfd12e648004763feff0597dda
…0682) ## Why Long built-in status lines were truncated to a single row even when the footer had room for more content. ## What changed - Wrap status text to the available width and row budget, preserving styles and hyperlink targets across rows. - Show an unlinked ellipsis when content exceeds the available space. - Refresh wrapped content when the status text, agent label, or width changes. - Keep reasoning-effort transitions on one row and restore wrapping after the final animation frame. ## Testing Add coverage for wrapping and hyperlink boundaries across footer layouts, content and agent-label updates, resizing, and wrapping restoration after an effort transition. Update transcript and startup snapshots for multiline status text. GitOrigin-RevId: 30e0795c473efd62fc4d0dca4deb6029b625a9e8
## Why Narrow composer footers can clip hints or crowd out mode indicators and actions. ## What changed Use a shared layout for navigation, actions, mode indicators, context, and warnings. Shorten or drop whole labels in priority order instead of clipping them. Add a second row when input modes and queue or active side-conversation actions fit separately but not together, keeping navigation and modes above actions. ## Testing Add coverage for fullscreen and scrollback layouts, narrow Plan mode hints, active side-conversation actions, oversized goal indicators, and warning hit areas. GitOrigin-RevId: 849a53d45ef1b36b40c52282e329b48ec7d7d12e
## What changed Allow `APPLE_NOTARIZATION_BACKEND=signer-service` to sign Apple notarization JWTs through `grpcurl`, using GitHub OIDC authentication. Validate the returned signing key and algorithm, and redact transport and signing failure details. Keep Azure Key Vault as the default backend and skip its configuration requirements when Signer Service is selected. ## Testing Add coverage for JWT refresh with fresh OIDC tokens and for the binary wrapper running without Azure configuration. All six notarization tests pass. GitOrigin-RevId: e38ea90e94639d87c11ab075c999d85b61b37c17
…#60697) ## Why MCP request metadata could forward a client-supplied `product_sku` to unrelated servers and connectors. ## What changed Remove `product_sku` from turn metadata before forwarding it. For Node REPL-backed servers and the browser connector, populate it from the turn's `apps_mcp_product_sku` configuration, mapping unrecognized values to `other` and omitting empty or missing values. ## Testing Add regression coverage for configured REPL and browser attribution, unrelated servers and connectors, unrecognized or absent configuration, and spoofed client metadata. GitOrigin-RevId: bc24062526048ea1c1621099e609053cf167602f
## Why An aborted turn could remain active, and a late abort for an unknown turn could interrupt a different turn with an explicit ID. ## What changed Finalize the active turn after applying an abort. Only fall back to the active turn when the abort lacks a turn ID or the active turn has a generated ID. ## Testing Extend regression coverage to verify that a late abort preserves a review turn's ID and completed status, and that repeating `turn/interrupt` returns `no active turn to interrupt`. GitOrigin-RevId: 73072dda7879bd50b1013f4a0bbf1b68546f2619
…#60702) ## What changed Move permission selection into `codex-config` with a shared `PermissionConfig` representation for legacy sandbox settings and named profiles. Resolve selectors using config layer precedence while preserving explicit session profile selection and sandbox mode overrides. Share legacy permission translation between config derivation and core loading, preserving merged workspace roots, network access, temporary-directory exclusions, and platform sandbox availability without modifying source layers or field origins. ## Testing Add coverage for mixed selector precedence, merged legacy settings, unchanged source metadata, and the Windows read-only fallback. Extend the managed preferences loader test to verify settings merged across layers and the absence of an active named profile for legacy permissions. GitOrigin-RevId: a435be7af38424ac33711e6a7557f52b9b672577
…penai#60708) ## What changed - Canonicalize home paths before sending sandbox provisioning and desktop registration requests. - Resolve saved junction paths when restoring the sandbox owner, holding the setup lock and pinning target directories while validating existing sandbox accounts. Skip migration for retiring runtimes. - Persist the resolved home and clear desktop home ownership so uninstall cannot delete a historical junction's target. ## Testing Add a Windows junction test verifying that a saved alias resolves to its physical target and an already canonical path needs no migration. GitOrigin-RevId: 9bac672273694e5a0353fec72a6bcba120e57255
## Why Background plugin cache refreshes fetched recommendations even when plugin recommendations were disabled. ## What changed Pass the effective recommendation feature state into `PluginsConfigInput` and skip recommendation cache warming unless apps, plugins, and either `tool_suggest` or `recommended_plugins` are enabled. Installed-plugin cache refreshes continue independently. Disable `tool_suggest` and `recommended_plugins` by default in core and app-server test helpers, with explicit overrides for recommendation tests. ## Testing Update cache-warming and external-login recommendation tests to opt in explicitly. Update config RPC assertions to verify the test helpers' session flag overrides. GitOrigin-RevId: dc04e2847c94e2b15842fcd95cc0cf1f104e1fac
## Why MCP config refreshes previously retained session app overrides, leaving connector approval changes unapplied in existing sessions. ## What changed - Refresh explicit session `apps` overrides alongside `plugins`, allowing updated link approval settings to take effect on the next turn. - Preserve overrides for omitted sections and restore inheritance when a section is an empty table. - Validate app overrides and the effective app configuration, rejecting refreshes that expose invalid inherited settings. ## Testing Add coverage for independent and combined app/plugin updates, clearing overrides, and rejecting invalid inherited app settings. Add an integration test verifying that changing a link's approval mode from `approve` to `prompt` requests approval before executing the next turn's tool call. GitOrigin-RevId: 3fa36744a9ccd9e735e4cda7f061ccff1cf2a269
…60732) ## Why Resuming an ID sequence from a persisted ID requires its allocation position before shuffling. Previously, IDs stored only their salt and shuffled value. ## What changed - Store the allocation `ordinal` in `ModelFacingId`, expose `salt()` and `ordinal()`, and derive `JsonSchema`. - Add `ModelFacingIdGenerator::starting_at()` and `next_ordinal()` so callers can resume with the original seed and salt at the next allocation position without a generator snapshot. ## Testing Update serialization coverage for the allocation fields and add a test that resumes from a serialized ID across the three-digit pool boundary, matching the uninterrupted sequence. GitOrigin-RevId: 6cbb725c0bd08356c0dc5458021b9bf58a489522
## Why Converting message content to tool output previously reduced file-backed audio to a text file ID, losing its audio type. ## What changed - Allow `input_audio` tool output items to carry either `audio_url` or `file_id`, preserving both forms during content conversion. - Account for file-backed tool audio in history estimates and output truncation, and prepare only inline audio data. - Reject uploaded audio in raw function and custom tool output injection, extending the existing requirement to submit uploaded audio through typed turn input. - Regenerate app-server schemas and TypeScript/Python types while preserving the Python inline audio class name. ## Testing Add coverage for tool audio wire-format round trips, repeated file audio sharing text and audio output budgets, and rejection of raw uploaded audio injection across messages and tool outputs. Extend Python SDK coverage for the inline tool audio shape. GitOrigin-RevId: f4704466e6151662d2c8b8dc3f5ca2ab2f5710a2
…openai#61579) ## What changed - Add a positive, finite `features.rollout_budget.limit_budget` allowance while retaining `limit_tokens` compatibility. Reject configurations that specify both. - Preserve fractional balances in reminders and compare thresholds without rounding the balance down. - Accumulate charges with compensated summation and allow spending exactly the allowance, including floating-point rounding tolerance for cases such as `0.1 + 0.2` against `0.3`. - Add `reminder_at_context_start`, defaulting to `true`. Set it to `false` to suppress reminders at thread start and after compaction; combine it with an empty threshold list to disable budget reminders entirely. ## Testing Extend configuration and rollout-budget tests to cover fractional allowances, legacy integer persistence, invalid limits, threshold-only reminders, and enforcement at decimal equality and after overspending. GitOrigin-RevId: b8e7a2faa8d39e562bcae196364de419698bc67d
…i#61580) ## What changed Allow successful synchronous `PostModelRequest` MCP hooks to return `extra_codex_rollout_budget_units` in `structuredContent`. Add these charges to rollout spending while preserving provider usage separately, including completed responses without token usage and incomplete responses with reported usage. Validate prices as finite and nonnegative. Preserve valid sibling charges when another hook reports an invalid price, and surface accounting failures without retrying inference. Carry hook charges and overflow information through host accounting and enforce local budget limits. ## Testing Extend coverage for hook-driven budget exhaustion, failed hooks, overflow, interrupted responses, and foreground and background compaction accounting. GitOrigin-RevId: dc54ba53478d82848bcafb55ecef88215019d09f
…61581) ## Why Turns stopped by an exhausted rollout budget need a history marker without attributing the interruption to the user. ## What changed - Record and flush a `<turn_aborted>` marker before the terminal event for `SessionBudgetExceeded`, respecting the interrupt-message setting. - Use neutral guidance in a `developer` message for automatic budget stops. - Centralize tool-start budget checks across parallel dispatch, tool handlers, and MCP handoff, retaining the check after tool-start observers finish waiting. - Share interruption classification and history recording across turn and compaction paths. ## Testing Extend the rollout-budget integration test to assert that both the budget-crossing turn and a later denied turn persist `developer` interruption markers. GitOrigin-RevId: 2a49ac9824a4e95e4799f2d0f638f8c46889e8e8
## Why A budget can be exhausted while another thread waits to start work. New requests, tools, and automatic turns must observe that stop without discarding an already-consumed response whose cost exhausted the budget. ## What changed - Share a work gate across the rollout tree while preserving native and host accounting ownership. - Recheck the budget before HTTP and WebSocket requests, hook execution, tool dispatch, and compaction. Prevent automatic wakeups and late input from restarting stopped work, leaving pending input queued. - Record response costs without rejecting the consumed response solely because its bill exhausts the budget, and stop new work when enforced accounting overflows. - Expose a thread-registration receipt that remains committed after unload. ## Testing Extend rollout-budget coverage to verify that accepted response text remains in history after exhaustion and that waiting tools observe the shared stop while completed tools retain their results. GitOrigin-RevId: e583d657c6f29e374d374cdb014bf23fd6c28614
## What changed - Centralize generation admission checks before request contributors run for HTTP and non-warmup WebSocket requests. - Route pending input and inline compaction through dedicated budget checks, and centralize post-compaction budget handling. - Preserve whether any checkpoint was installed when remote compaction combines a background candidate with foreground compaction. - Track accepted final answers separately from trailing commentary and encapsulate the response state shared by stop and after-agent hooks. ## Testing Update the plan-mode contributor test to verify that contributed commentary is tracked separately from final answers, and adapt stream-event assertions to the phase-aware assistant text representation. GitOrigin-RevId: 43b663e92bfd24ec7e5a0778b711938f16a7fea4
) ## Why Model request hooks need to correlate attempts belonging to the same generation across retries and model fallback. ## What changed Add `request_id` and one-based `attempt_number` fields to `PreModelRequest` and `PostModelRequest` inputs and their generated schema. Keep the request ID stable across retries and increment the attempt number for each call to open a response stream. ## Testing Extend hook tests to verify matching request IDs and increasing attempt numbers across retries. Extend the background compaction scenario to verify that its pre/post hooks share an ID distinct from the ordinary sampling request. GitOrigin-RevId: 2d85ad6fd630505a89a712cebab6ca0f731610c9
## Why Item IDs are unique only within a turn. Reusing an ID across turns can misplace completion boundaries or hide unrelated items when loading older history. ## What changed Carry turn IDs with paginated history items and key completion grouping and hidden review prompt lookups by both turn ID and item ID. Skip completion boundaries that would move backward through the page. ## Testing Extend regression coverage to reuse item IDs across turns, checking completion ordering, visibility of unrelated tool items, and pagination without overlapping completion footers. GitOrigin-RevId: 6cc8e16a1731d5aad4cbfb1c27e51c4665b0a655
## Why Switching backends while an overview refresh is pending can lose queued pagination or let a late page consume another backend's refill budget. ## What changed - Track queued refreshes, “Show more” requests, refill counts, and refresh failures per backend. - Preserve pending work across backend switches and use registered live request handles to refresh the owning backend. - Cancel stale reads for the affected backend after mutations, event lag, or disconnects, and hide “Show more” when its backend is disconnected. ## Testing Add regression coverage for pagination across focus changes, backend-specific refills, pin completion, stale reads after event lag, and connection registration during reconnect. GitOrigin-RevId: 3429b2b3ac93156b4dc4234ad042431d26c84525
…nai#61599) ## Why Cloud stream failures previously used a generic reopen message even when the conversation was missing, access was denied, or sign-in had changed. Abandoned turn and item list requests could also keep the native worker occupied. ## What changed - Report specific disconnect reasons for missing conversations, lost access, and changed or expired sign-in, including failures during idle reconnection. - Report exhausted reconnect attempts and other nontransient recovery failures with dedicated messages. - Cancel in-flight `ThreadTurnsList` and `ThreadItemsList` requests when their callers drop, matching `ThreadList` behavior. ## Testing Add regression coverage for abandoned history reads, changed sign-in during accepted idle recovery, and access-denied stream errors. GitOrigin-RevId: 29923b46c2d377f2247d699757553777a31d08ca
## Why Cloud conversations previously skipped TUI title generation, leaving them without automatically saved names. ## What changed - Generate structured titles using the selected Cloud account and its backend routing, without agent tools or a temporary conversation. - Read and save names outside the conversation command queue without replacing the active attachment. Preserve an existing name if it no longer matches the expected value. - Fall back to the first-message title when generation is unavailable, and allow up to three seconds for pending saves during shutdown. - Report a retryable error when a manual rename encounters an automatic save in progress, keeping the UI responsive. ## Testing Add coverage for selected-account title generation, saved-name reads without attachment, first-message fallback persistence, and manual rename retries after automatic saves. GitOrigin-RevId: 48030cc0b75e790a2004af018f54e5751665b760
## Why Archiving the current task waits for the server response before returning to the command center, blocking navigation while the request is pending. ## What changed - Run the archive request in the background after side chat and voice cleanup, hiding the task while it is pending. - Preserve drafts and approvals until archiving succeeds. On failure, show an error and make the task visible again. - Keep archive completions across reconnects and route dynamic tool replies through their original reply handles. - Show `Archiving…` during side chat cleanup. On exit, wait up to five seconds for pending archives and report failures or unconfirmed outcomes. ## Testing Add coverage for navigation before the archive response, success and failure handling across event channel replacement, preserved drafts, side chat cleanup failures, and exit warnings. GitOrigin-RevId: 7b6e35cb11159f5be1d0b9fb2082dbd8c7826a94
## What changed Direct agents to use `history.list_windows` to find valid window IDs for the agent they want to inspect. Replace the namespace description's ordering and unknown-window guidance, and update the bundled tool contract snapshots to match. GitOrigin-RevId: 37050cc3b2311f1d8f3b5676dca8d1261423c4c5
Build `config/read` responses from the latest loaded configuration's layer stack so requests with a relative `cwd`, such as `.`, succeed and reflect external configuration edits. Reuse that configuration for feature overrides and preserve precedence for layer read and decoding errors over full-config validation errors. Add a regression test that reads with `cwd: "."` before and after an external model configuration edit and checks that both values are returned. GitOrigin-RevId: 82eb835f2eac4e53414b01fc9286c2aac71babf2
…penai#61686) ## Why Marketplace listings read plugin manifests for entries later discarded by policy, product visibility, or duplicate selection across project scopes. This causes unnecessary reads and can emit parse warnings for plugins that never appear in the listing. ## What changed Separate marketplace entry validation from plugin manifest loading. Apply marketplace policy, visibility, and path and plugin ID deduplication before loading metadata, preserving first-source and first-scope precedence. ## Testing Add a regression test covering repeated marketplace paths and shadowed plugin IDs across scopes. Verify that the selected malformed manifest is read once, the discarded manifest is never read, and the visible plugin IDs and local versions are preserved. GitOrigin-RevId: 00b1d50593fb6546aafdc2089e6fccec1b4e5f42
## What changed - Add an `OWNERS` file for `codex-rs/tui` with `tempest::evaluate-only`. - Add `TEMPEST_REVIEW` guidance requiring inspection of `codex-rs/tui/styles.md`, identifying local rendering and copy fixes with focused snapshots as eligible for automatic approval, and requesting human approval for changes to input actions or app-server-dependent thread and turn state. GitOrigin-RevId: 6440f1a5a96fa4979292171d0c88c0b5d4d464bd
## Why Pasted goal text was stored in separate files, leaving file references in the goal editor instead of the pasted content. ## What changed Expand pending pastes into the goal objective before processing image attachments and checking the objective length. Short goals now retain their text inline; oversized expanded objectives still use the managed `goal-objective.md` file. ## Testing Update goal tests to cover oversized Unicode pastes, inline text without new attachment files, and pastes combined with image attachments. Add a snapshot showing `Use hello` when reopening a pasted goal in the editor. GitOrigin-RevId: afd8e8de1ca12fe81bdfd526a0ad9e92a43addc2
## Why When status details exceed the line limit, character-based truncation can make the final line overflow its available terminal width. ## What changed Use display-width-aware truncation on the entire final line, including its indentation and trailing ellipsis. ## Testing Extend the status details test with wide Unicode characters, checking that every line fits within 10 columns and snapshotting the truncated output. GitOrigin-RevId: 89c6cfb7cf36cdf0d63b6f732c59acd96128f9fd
## What changed Close the experimental features popup without saving pending edits when the user presses `Esc`, `Ctrl+C`, or a remapped cancel key. Keep saving on the accept action (`Enter` by default), and update the footer from `esc save/close` to `esc cancel`. ## Testing Update tests to assert that cancellation discards toggles without emitting save events, including after a failed write and with a remapped cancel key. Refresh popup snapshots for the new hint. GitOrigin-RevId: d7640edaeca1db371a7087312179a001d7528b9a
## Why Releasing TUI input modes previously disabled alternate scrolling unconditionally, overriding terminals where it was initially enabled. ## What changed - Query alternate-scroll mode (`1007`) during the Unix startup probe and filter its replies from replayed input. - Restore the recorded mode during editor handoff and exit, defaulting to disabled when the initial state is unknown. - Retry scroll-mode restoration after a failed cleanup write. ## Testing Extend startup probe tests to parse enabled and disabled reports. Add coverage for preserving both initial states across handoff and exit, and retrying failed restoration. GitOrigin-RevId: 786a44c04da6e2c9cb9af73c096d8df92ded88e9
## What changed - Use `AppServerClient` throughout exec and extract turn completion into `finish_turn`, including handling for server and thread-stream disconnections. - Move remote address parsing and auth-token resolution into `codex-app-server-client`, with re-exports from the TUI. - Allow human-readable exec output to be initialized without a local `Config`. ## Testing Move remote address and auth-token tests into `codex-app-server-client`, retaining coverage for WebSocket and Unix socket addresses, invalid addresses, and missing, empty, or whitespace-padded tokens. GitOrigin-RevId: 465b17a1c03392a7d4e7700d83ce67c2cf5ef021
## What changed Allow `codex exec --remote <ADDR>` to run a noninteractive turn using an existing app server's configuration and credentials. Support starting a new thread or resuming one by UUID, with human-readable or JSON output and optional bearer-token authentication through `--remote-auth-token-env`. Accept remote options before or after `exec`, and reject conflicting endpoints. Reject unsupported agent configuration overrides and active threads, and report an error if the server disconnects before the turn completes. ## Testing Extend CLI integration coverage for remote execution and resume using server authentication, JSON completion events, human-readable thread IDs, and conflicting endpoints. Add a snapshot for `--remote` help text. GitOrigin-RevId: d4c3b16fb80eb6e8c523aff92110eaa878cbd3ee
## Why Listing even one turn of a legacy thread replays its entire rollout. Overview refreshes should avoid that work just to populate previews. ## What changed - Fetch saved prompt and reply previews only for threads with paginated history. - Update legacy prompt previews from user-message notifications and preserve them across refreshes and reverts. - Retain the latest observed reply preview when a thread closes. ## Testing Extend overview tests to reject legacy turn-list requests, verify paginated previews, preserve live prompts across stale refreshes and reverts, and retain reply previews after thread closure. GitOrigin-RevId: 85130adda155c5ea93c5a5c2b3f89a945170ba51
## Why Restricted input dismissed the slash-command popup when a thread was unavailable, preventing users from selecting recovery commands from partial input. ## What changed Keep the command popup available while editing an unavailable thread's draft. Allow navigation, Tab completion, and submission of eligible recovery and local commands, including with custom submit keys. For example, typing `/sub` and pressing Enter selects `/subagents`. Continue to reject commands unavailable in this state and invalid command arguments. Preserve Vim escape and search behavior without reopening the popup during search. ## Testing Add regression tests and a popup snapshot covering highlighted recovery completion, blocked commands, custom submit keys, and Vim escape and search behavior. GitOrigin-RevId: 38021db8cdcd9f7ec7c62cfa0efd8819bf8057da
…nai#61711) ## What changed Launch desktop session URLs with PowerShell's `Start-Process` instead of resolving and starting the packaged executable directly. Restrict the installed `OpenAI.Codex` package check to the two supported publisher IDs and select the first match. GitOrigin-RevId: 350029a2101ff048de52fa9f9444e4b5dbdcc12e
## Why An editor's suspend/resume cycle can change terminal settings while crossterm still considers raw mode enabled, preventing Codex from restoring raw mode on return. ## What changed On Unix, clear crossterm's raw-mode cache before reapplying TUI terminal modes after an external program exits. ## Testing Extend the external-editor PTY test to simulate an editor restoring canonical mode with `stty sane` and verify that canonical input and echo are disabled after returning to Codex. GitOrigin-RevId: 4ae151deaf073bddf5a1c7fdfb5a1b5f4a480375
…169.0) Brings the fork from its 2026-10-21 base (c7234c1) up to upstream aea4c6e: 1176 upstream commits. Conflict resolution: - linux-sandbox: upstream added transparent TCP (ProxyRouting, tcp_namespace, tcp_net_setup, the relay handshake in the inner stage) on the same code the fork's Unix socket allowlist enforcement touches. Both are kept: the seccomp entry point takes upstream's `proxy_routing: Option<ProxyRouting>` plus the fork's `UnixSocketEnforcement`; the proxy-routed filter builds upstream's socket rules (including the NETLINK_ROUTE allowance) and then the fork's AF_UNIX admission and datagram denial through upstream's add_syscall_rules helper; the child enters the supervisor before waiting for the relay, matching the order the parent serves them in. - Upstream's new seccomp tests pass UnixSocketEnforcement::NotEnforced. - blocking-ci.yml: bazel, bazel-result and sdk stay out (no runners here). - rust-ci.yml: upstream made the prebuilt argument-comment lint advisory, so the fork's skipped-result special case is dropped; its upstream-only `if` stays. - .codespellignore: union. The renamed plugin-install snapshot is upstream's.
test_install_sh.py fakes a running helper by copying /bin/sleep to codex-code-mode-host. On the current ubuntu-latest image /bin/sleep is the uutils multi-call binary, which exits with "unknown program" under that name, so test_standalone_retains_previous_and_running_releases_across_installs fails. ubuntu-24.04 ships GNU coreutils.
The package builder builds every binary in one cargo invocation. Upstream added codex-exec-server to the package, so three thin-LTO links now overlap and the hosted runner was lost after 70 minutes of the build-only run on this branch. Resolve the V8 artifacts up front, export them, and prebuild each binary sequentially so the builder's own cargo run is a no-op. The smoke test also checks for bin/codex-exec-server.
A hosted-runner release build takes about an hour per attempt and has been lost mid-build twice. scripts/fork-release-local.sh builds the same package and assets on a developer machine in a throwaway worktree, smoke tests them, and with --publish tags fork-v<version> and creates the GitHub release. The workflow no longer runs on tag push. It stays as a manual fallback and as the way to get a glibc 2.35 build from ubuntu-22.04.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the fork from its 2026-10-21 base up to upstream
openai/codexmain ataea4c6ee4b(2026-11-15, pastrust-v0.169.0): 1,176 upstream commits, merged, not rebased, so the fork's signed history is unchanged.What upstream added (0.164 to 0.169)
codex doctor --network-only, opt-in system proxy settings, hardened sandbox checks.codex exec: project config and MCP servers stay disabled in untrusted directories;--trustsaves project trust forexecandreview.model_provider = "gcp"), GPT-6.1 Terra, custom model providers editable from the terminal, Bedrock wizard on by default./presets, inline/modeland/permissionsarguments, keyboard transcript selection and search, image previews (Kitty/Sixel, tmux passthrough), opt-in side-chat workspace with tabs, collapsible turn details, agent command center search.codex queue --resume, packages now shipcodex-exec-server.Conflicts and how they were resolved
linux-sandbox(the fork's feature): upstream's transparent TCP landed in the same functions as the Unix socket allowlist. Both are kept. The seccomp entry point takes upstream'sproxy_routing: Option<ProxyRouting>plus the fork'sUnixSocketEnforcement; the proxy-routed filter keeps upstream's rules (including theNETLINK_ROUTEallowance) and then applies the fork'sAF_UNIXadmission and datagram denial; the child enters the supervisor before waiting for the TCP relay, in the order the parent serves them.UnixSocketEnforcement::NotEnforced.blocking-ci.yml:bazel,bazel-result,sdkstay out.rust-ci.yml: upstream made the prebuilt lint advisory, so the fork's special case is dropped..codespellignore: union.Fork changes that merged cleanly and were re-verified:
daemon_auto_startoff,--trust-folder, the+forkupdate-check skip, the V8 mirror default (stillrusty-v8-v152.2.0), the fork release pipeline.Verification (WSL2, merged tree)
cargo check --testsforcodex-linux-sandbox,codex-features,codex-tui: clean.codex-linux-sandbox: 264 passed, 2 failed. Both failures (wslg_mask_is_omitted_when_policy_already_hides_an_ancestor,proc_mount_denial_preserves_legacy_fallback_and_explicit_pid_inheritance) are upstream tests that fail identically on a pureupstream/maincheckout on the same machine, so they are WSL-environment issues, not merge regressions.--trust-folder, fork-version and features tests pass.codex+codex-code-mode-host, thenatrium-smoke/unix-socket-smoke.shagainst it: 6/6 pass.