Skip to content

Glance compatibility expansion - #11

Closed
JSYoo5B wants to merge 4 commits into
codex/09-cinder-compatibility-expansionfrom
codex/10-glance-compatibility-expansion
Closed

JSYoo5B wants to merge 4 commits into
codex/09-cinder-compatibility-expansionfrom
codex/10-glance-compatibility-expansion

Conversation

@JSYoo5B

@JSYoo5B JSYoo5B commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Expands Glance-compatible APIs for image data, members, staged import, and tasks.
  • Builds on the earlier image update and repository update operations.

Main Review Points

  • Image data upload/download behavior.
  • Member and task DTO compatibility.
  • Import endpoint behavior and current MVP limitations.

Verification

  • go test ./...
  • Checked each commit from this slice onward with go test ./...

image.SizeBytes = int64(len(data))
image.UpdatedAt = now.Format(time.RFC3339)

if _, err := s.repository.Update(image); err != nil {

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image data and image metadata are stored separately. The metadata update happens before the blob write here, so a future durable data store may need transactional handling if partial failures become important.

return nil
}

func (s *Service) StageData(id string, data []byte) error {

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StageData intentionally leaves the image in uploading state while storing the staged bytes. ImportData below is the separate compatibility step that marks the image active.

return err
}

func (s *Service) DownloadData(id string) ([]byte, error) {

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Download checks image existence before reading data. That keeps missing image semantics separate from missing blob semantics in the data repository.

@JSYoo5B
JSYoo5B marked this pull request as draft July 2, 2026 21:10
@JSYoo5B
JSYoo5B force-pushed the codex/09-cinder-compatibility-expansion branch from 6c507e9 to 9ee66c6 Compare July 5, 2026 12:50
@JSYoo5B
JSYoo5B force-pushed the codex/10-glance-compatibility-expansion branch from 264e59a to 7864e35 Compare July 5, 2026 12:50
@JSYoo5B

JSYoo5B commented Oct 15, 2026

Copy link
Copy Markdown
Owner Author

Closing without merge. The repository was reset to a new root that keeps only the retained design decisions (see docs/decisions/). This branch is kept for reference, and the full stack is archived at tag archive/pre-reset-pr-stack.

@JSYoo5B JSYoo5B closed this Oct 15, 2026
@JSYoo5B
JSYoo5B deleted the codex/10-glance-compatibility-expansion branch October 16, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant