feat: support existing PDF signature fields - #65
Merged
vitormattos merged 1 commit intoSep 17, 2026
Merged
Conversation
Signed-off-by: vikas-kushwaha-dev <vikaskushwaha.dev00@gmail.com>
vikas-kushwaha-dev
requested review from
jeidison and
vitormattos
as code owners
September 17, 2026 19:16
vitormattos
approved these changes
Sep 17, 2026
vitormattos
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. I checked the implementation against #62, including the parser, signature field selection, error handling, temporary file cleanup and the integration tests.
The implementation follows the JSignPdf 3.2 behavior without adding PDF or selector logic in PHP, and the current CI is passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds typed support for inspecting and selecting existing PDF signature fields using the JSignPdf 3.2 CLI capabilities.
SignatureFieldmodel exposing field name, page, coordinates, signed/blank state, hidden state, and rectangle visibilityJSignService::getSignatureFields()and facade support for inspecting existing fields--list-sig-fieldsoutput, including Unicode names, spaces, hidden fields, zero-size rectangles, and selector-shadow messagesJSignParam::setSignatureField()/getSignatureField()for selecting an existing field during signing--sig-fieldwithout implementing selector semantics in PHPTesting
composer cs:checkcomposer test:unitcomposer psalmcomposer test:integrationAll checks pass.
Closes #62