Repository navigation
fix(mobile): compact seat approvals and whole-card question taps in the Inbox - #1019
Merged
Merged
Conversation
…he Inbox The Inbox's seat approvals used upstream's thread approval card, whose actions wrap to two rows on a phone; the Inbox now draws its own card with one row of small actions, and the thread keeps upstream's card. An agent question's card opens the question wherever it is tapped, not only on its link text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Pre-merge checks:
|
Jacksondr5
commented
Nov 11, 2026
Jacksondr5
left a comment
Owner
Author
There was a problem hiding this comment.
Combined review: reviewer-opus and reviewer-sol (Claude Opus 5.5 and GPT Sol 6.1), head 69dc3d1
Both of us reviewed the PR independently. Neither found anything that blocks merge.
- Nothing upstream's card did for Inbox requests is lost.
toPendingApprovalalways setsresponseCapability: "live", so the card's "provider process … no longer available" branch could never show for an Inbox item.reasonandfullAccessOverridewere never carried.- Kept: the provider's options, or upstream's defaults; the warning; the
appNameorrequestKindheading with the detail; and the can't-respond note. - Kept: the permission and busy gating, the response destination, and the refusal-then-reread handling.
- Only the "Approval needed" eyebrow goes; the section title covers it.
- The question card. It's one
Pressablelink to the question's environment and thread, disabled and without a chevron while its server is offline, and it says "Its server is offline."
It's visual only, so no redundant tests were run.
Code approval: the panel has no open code findings. Still pending: the Android and iOS captures, the tester's verdict and green J5 CI.
Jacksondr5
added a commit
that referenced
this pull request
Nov 11, 2026
This was referenced Nov 11, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two layout findings from Jackson at Checkpoint 4, on the mobile Inbox's Crew rows. Part of #1010 (items 1 and 2).
PendingApprovalCard(feat(mobile): seat approvals and agents' questions in the Inbox, counted on the bell #985), whose Allow once / Allow session / Decline wrap onto two rows on a phone and take too much room.What changed
InboxCrewRequests.tsx, styled like the ask cards. It shows:Tests: none. These are layout changes, proved by the tester's before/after captures.
UI changes
Android, base (before) and this PR (after), with the same pending real Haiku approval and question on both.
After: tapping the question card's title opens its thread.
question-card-69dc-after-published.mp4
After: Allow once from the compact row clears the approval, and the bell drops.
approval-answer-69dc-after-published.mp4
Live testing
Android: PASS at
69dc3d13a6, this PR's head, by the crew tester (Sol 6.1), with a real Haiku 5.5 Crew seat approval and a real Haiku provider question.Not exercised:
Checklist
PendingApprovalCardis no longer used by the InboxBuilt by Claude Opus 5.5 in Claude Code (J5 crew seat builder-identity).
🤖 Generated with Claude Code