Skip to content

fix(mobile): compact seat approvals and whole-card question taps in the Inbox - #1019

Merged
Jacksondr5 merged 1 commit into
j5/mainfrom
j5code/inbox-crew-rows-1010
Nov 11, 2026
Merged

Jacksondr5 merged 1 commit into
j5/mainfrom
j5code/inbox-crew-rows-1010

Conversation

@Jacksondr5

@Jacksondr5 Jacksondr5 commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Problem

Two layout findings from Jackson at Checkpoint 4, on the mobile Inbox's Crew rows. Part of #1010 (items 1 and 2).

  1. A seat approval used upstream's PendingApprovalCard (feat(mobile): seat approvals and agents' questions in the Inbox, counted on the bell #985), whose Allow once / Allow session / Decline wrap onto two rows on a phone and take too much room.
  2. On an agent question's card, only the "Open question" text could be tapped.

What changed

  • Seat approvals. The Inbox draws its own card, in J5's InboxCrewRequests.tsx, styled like the ask cards. It shows:
    • the Crew and seat, with "Open thread";
    • the request kind (or app) and its detail in small monospace;
    • one row of small actions: the provider's options, or upstream's three defaults.
    • Upstream's card in the seat's own thread is untouched. The answer, the refusal reason above the list, and the reread after an answer all work as before.
  • Agent questions. The whole card is the link that opens the question, with a chevron. While its server is offline, the card is disabled and says so.

Tests: none. These are layout changes, proved by the tester's before/after captures.

UI changes

Android, base (before) and this PR (after), with the same pending real Haiku approval and question on both.

State Before After
A Crew seat's approval Crew seat approval actions in the Inbox, Android before Crew seat approval actions in one row, Android after
An agent's question Agent question card in the Inbox, Android before Agent question card as one link, Android after

After: tapping the question card's title opens its thread.

Agent question thread opened from the card, Android after

question-card-69dc-after-published.mp4

After: Allow once from the compact row clears the approval, and the bell drops.

Inbox after the approval was answered, Android after

approval-answer-69dc-after-published.mp4

Live testing

Android: PASS at 69dc3d13a6, this PR's head, by the crew tester (Sol 6.1), with a real Haiku 5.5 Crew seat approval and a real Haiku provider question.

  • The actions fit on one row.
  • Tapping the question card's title opened its thread, where the question was answered.
  • Allow once from the compact row resumed the seat's command (its output file was checked), and the bell went from 3 to 2.

Not exercised:

Checklist

  • One concern: the mobile Inbox's Crew rows (approval actions, question taps)
  • Tests: none; layout, proved by captures
  • UI changes: before/after stills and videos above
  • Live testing: Android passed; the section above says what was not exercised
  • Upstream-owned files: none edited; upstream's PendingApprovalCard is no longer used by the Inbox
  • Upstream product: no change
  • Surfaces: the mobile Inbox only. Web keeps its row of approval buttons and its question rows. No contract change.
  • Docs: none needed

Built by Claude Opus 5.5 in Claude Code (J5 crew seat builder-identity).

🤖 Generated with Claude Code

…he Inbox

The Inbox's seat approvals used upstream's thread approval card, whose actions
wrap to two rows on a phone; the Inbox now draws its own card with one row of
small actions, and the thread keeps upstream's card. An agent question's card
opens the question wherever it is tapped, not only on its link text.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
j5-code Ready Ready Preview Nov 11, 2026 10:18pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Pre-merge checks: Inconclusive 2

Failed Failed checks: 2 inconclusive

Check name Status Explanation Resolution
Title check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
Description check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@Jacksondr5 Jacksondr5 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combined review: reviewer-opus and reviewer-sol (Claude Opus 5.5 and GPT Sol 6.1), head 69dc3d1

Both of us reviewed the PR independently. Neither found anything that blocks merge.

  • Nothing upstream's card did for Inbox requests is lost.
    • toPendingApproval always sets responseCapability: "live", so the card's "provider process … no longer available" branch could never show for an Inbox item.
    • reason and fullAccessOverride were never carried.
    • Kept: the provider's options, or upstream's defaults; the warning; the appName or requestKind heading with the detail; and the can't-respond note.
    • Kept: the permission and busy gating, the response destination, and the refusal-then-reread handling.
    • Only the "Approval needed" eyebrow goes; the section title covers it.
  • The question card. It's one Pressable link to the question's environment and thread, disabled and without a chevron while its server is offline, and it says "Its server is offline."

It's visual only, so no redundant tests were run.

Code approval: the panel has no open code findings. Still pending: the Android and iOS captures, the tester's verdict and green J5 CI.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 effective changed lines (test files excluded in mixed PRs). labels Nov 11, 2026
@Jacksondr5
Jacksondr5 merged commit 08ce5fe into j5/main Nov 11, 2026
32 checks passed
@Jacksondr5
Jacksondr5 deleted the j5code/inbox-crew-rows-1010 branch November 11, 2026 23:13

This branch was successfully deployed

1 active deployment
Preview — 69dc3d13 Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant