Repository navigation
fix(j5): toggling a persona leaves the rest of Agent Setup alone - #1029
Conversation
Each toggle set the screen's busy flag while it saved, and every row that follows it, including Import persona file and Import a folder of personas, dimmed and came back. Toggles now keep their own one-at-a-time guard, which doesn't render, so the rest of Agent Setup stays put. Closes #1027 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Jacksondr5
left a comment
There was a problem hiding this comment.
Combined panel review (reviewer-opus + reviewer-sol) at 03ab2a6
Verdict: no findings, and the panel approves the source. Still pending: the tester's recording showing the import, folder and header rows stay steady while a persona toggles, and that single, double and failed toggles still settle. Also J5 CI.
- Cause and fix.
toggleAgentno longer sets the screen'sbusy, solockeddoesn't flip and the rows it disables (Import persona file, Import a folder, the folder rows, Add folder, the header menu) no longer dim toopacity-45and back during a toggle. - One toggle at a time. A
useRefis set synchronously before the save and cleared after it.useAtomCommand→runAtomCommandturns a rejected request into a typed failure, so a failed save can't leave the guard stuck. A toggle still refuses while another action holdsbusy. The per-row pending value from #986 and #1017 is unchanged. - Other actions now run during a toggle. That's safe: on the server, every library mutation (
setEnabled, import, remove, create, edit) takes the same process-wideimportPermit.withPermitinagentPersonaLibrary.ts, so a toggle and an import or removal are serialized and can't lose each other's write. - Web unchanged. Web's Agent Setup keeps
busyon toggle, since only the phone was reported. That's fine. - It changes one J5-owned file, so no FORK.md record is needed.
Reviewer-run: reactCompilerCoverage.test.ts passes (1093), mobile vp run typecheck exits 0, and lint and git diff --check are clean. It's a visual fix, so no UI test is asked for.
Reviewed by Claude Opus 5.5 (reviewer-opus) and Sol 6.1 (reviewer-sol) in J5 Code.
Web's toggle also held the screen's busy flag while it saved, disabling every other control. Both clients now leave busy alone on a toggle and drop the client-side one-at-a-time guard: the server already serializes persona library writes, so toggles on different rows can save together. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Jacksondr5
left a comment
There was a problem hiding this comment.
Panel delta check (reviewer-opus + reviewer-sol) at d7b2659
Verdict: no findings, and the panel approves the source. Still pending: evidence on both clients and J5 CI.
- Web. As the Captain asked, web's
toggleAgentno longer sets or clearsbusy, so the rest of Agent Setup stays enabled during a toggle. Its permission andbusychecks, typed failure toast andcatalog.refresh()on success are unchanged. The switch is controlled bypersona.enabled, so it shows the old value until the reread lands, as before. A repeat click resends the same value, which does nothing. - Mobile. The client-side ref guard is gone. Toggles on different rows can save together, each row keeps its own pending value, and a same-row second tap is still ignored. A toggle still refuses while another action holds
busy. - No write race. Every persona-library mutation is serialized on the server through
importPermit.withPermit(agentPersonaLibrary.ts), so concurrent toggles, and a toggle beside an import or removal, can't lose a write.
For the evidence. Web now needs before and after too. On both clients: the surrounding rows stay steady, toggles on two different rows save together, and a failed toggle recovers.
Reviewer-run: web src/j5/agents tests pass (9 in 5 files), web and mobile vp run typecheck exit 0, lint and git diff --check are clean (reviewer-opus). reviewer-sol ran 2 targeted compiler checks on mobile and web.
Reviewed by Claude Opus 5.5 (reviewer-opus) and Sol 6.1 (reviewer-sol) in J5 Code.
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 32 minutes for your next included review. View limit details
|
Problem
On mobile Agent Setup, every persona toggle made the Import persona file and Import a folder of personas rows flicker (Jackson, Checkpoint 5). Closes #1027.
What changed
toggleAgentset the screen'sbusyflag for the length of the save. On mobile,busyfeedslocked, which disables those two rows, the source folder rows, Add folder and the header's create menu. A disabled row renders at reduced opacity, so they all dimmed and came back on each toggle. Web's Agent Setup did the same, disabling its other controls while a toggle saved.On both clients a toggle now leaves
busyalone. The server already serializes every persona library write (importPermitinagentPersonaLibrary.ts), so other actions, and toggles on other rows, can run while one saves. A toggle still refuses while another action holdsbusy, and the toggled row keeps its own pending value from #1017.UI changes
Android: the import rows while a toggle is saving:
Android: the import rows and persona library sources while a toggle is saving:
Web: the surrounding controls while a toggle is saving:
After only:
Android before: four toggles and a held toggle:
android-base.mp4
Android after: four toggles, a double tap while saving, and two rows saving together:
android-head-clean.mp4
Web before: the surrounding controls during a held toggle:
web-base.mp4
Web after: two different toggles saving together:
web-head.mp4
Web after: a refused toggle recovering with an error:
web-refused.mp4
Android after: the import file picker opening during a held toggle:
android-import-held.mp4
Live testing
PASS on Android and web at
d7b2659739against base1790b3386f(crew tester, reporttest-reports/pr-1029/d7b2659739.md). The server was held to keep each toggle saving.Not exercised: iOS. The change is the same JS on both platforms; Jackson checks iOS at the next checkpoint.
Checklist
Claude Opus 5.5 in J5 Code (Claude Code harness).
🤖 Generated with Claude Code