Skip to content

ci(j5): give server test shards 25 minutes - #737

Merged
Jacksondr5 merged 1 commit into
j5/mainfrom
j5code/ci-server-shard-timeout
Oct 27, 2026
Merged

Jacksondr5 merged 1 commit into
j5/mainfrom
j5code/ci-server-shard-timeout

Conversation

@Jacksondr5

Copy link
Copy Markdown
Owner

Problem

J5 CI's server test shards keep hitting their 15-minute limit and are cancelled with no failing test. On 26 October that cancelled eleven shards across #660, #662, #663 and #664. On #660's last failure, the "Install Chromium" step took 11.5 of the 15 minutes, which left about four minutes for tests.

What changed

Raise test_server's timeout-minutes from 15 to 25 in .github/workflows/j5-ci.yml, with a comment saying why. No check, test or shard changes. Caching the Chromium install would be the longer-term fix. That is a separate concern and is not in this PR.

Checklist

  • One concern: the description has no "also"
  • Tests cover the changed behavior: not applicable, CI configuration only
  • UI changes: not applicable
  • Live testing: not applicable
  • Upstream-owned files: none; j5-ci.yml is J5's own workflow
  • Upstream product: not applicable
  • Surfaces: CI only
  • Docs: not applicable

Made with Claude Opus 5.5 in Claude Code (J5 Code). The local pre-commit hook was skipped because this worktree has no dependencies installed; CI's format check covers the change.

🤖 Generated with Claude Code

The Chromium install step alone can take over eleven minutes on a cold
runner, so server shards hit the 15-minute limit and were cancelled with
no failing test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
j5-code Ready Ready Preview Oct 27, 2026 1:05am UTC

Request Review

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Oct 27, 2026
@github-actions github-actions Bot added the size:XS 0-9 effective changed lines (test files excluded in mixed PRs). label Oct 27, 2026
@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 882256d and ec365aa.

Files selected for processing: 1
  • .github/workflows/j5-ci.yml

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Walkthrough

The CI workflow increases the test_server job timeout from 15 to 25 minutes. A comment notes that Chromium installation can take over eleven minutes.

Changes: CI server test timeout

Layer / File(s) Summary
Update server test timeout
.github/workflows/j5-ci.yml
The test_server job timeout changes from 15 to 25 minutes. A comment notes that Chromium installation can take over eleven minutes.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related PRs

Merge Risk: Minimal · up to ec365

The CI timeout adjustment addresses reported shard cancellations without changing test behavior.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: increasing the server test shard timeout to 25 minutes.
Description check Passed The description explains the problem, the timeout change, scope, testing status, checklist decisions, and authoring context. It omits the optional UI, live testing, and upstream impact sections becaus…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem, the timeout change, scope, testing status, checklist decisions, and authoring context. It omits the optional UI, live testing, and upstream impact sections because they are not applicable. It does not link a tracking issue, but the description is otherwise complete.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@Jacksondr5
Jacksondr5 merged commit 0944884 into j5/main Oct 27, 2026
31 checks passed
@Jacksondr5
Jacksondr5 deleted the j5code/ci-server-shard-timeout branch October 27, 2026 01:25

This branch was successfully deployed

1 active deployment
Preview — ec365aa6 Deployed Oct 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant