You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs(j5): PR template asks for descriptive screenshot alt text - #826
Before/after screenshots that agents write into PR tables by hand use bare ![Before] and ![After] alt text (#820, #814, #808, #807, #765). When a viewer shows the images on their own, as J5's does, that alt text is all that tells you which state an image shows. The row's first column says the state, but the image tag never gets it.
What changed
The comment in the template's "UI changes" section now points to scripts/j5/pr-evidence.ts, which uploads the images and prints the table. Its output already gets the alt text right (![<caption>, before]), as in #824, #823 and #797. The comment also says that a table written by hand should name the state and side in each image's alt text, with a good example next to a bad one.
The same rule is now in the developer's machine-wide agent instructions, outside this repo, so it applies in every repo.
Checklist
One concern: the description has no "also"
Tests cover the changed behavior: n/a, this changes template text only
UI changes: n/a, no UI change
Live testing: n/a, nothing to run
Upstream-owned files: the template is J5-owned (FORK.md, J5-owned files list)
Upstream product: not touched
Surfaces: only the PR template applies
Docs: docs/j5/process/pull-requests.md and the j5-live-test skill stay accurate; the skill already sends agents to the script
Hand-written before/after tables used bare "Before" and "After" alt text,
which is all a viewer that shows images on their own (like J5's) displays.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reviewing files that changed from the base of the PR and between a0cd096 and dd00d2e.
Files selected for processing: 1
.github/pull_request_template.md
Files skipped from review as they are similar to previous changes: 1
.github/pull_request_template.md
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.
Walkthrough
The pull request template now identifies the screenshot evidence upload script and specifies that manually written screenshot alt text must name the image’s UI state and whether it shows the before or after state.
The template points to scripts/j5/pr-evidence.ts for screenshot uploads. It also requires manually written image alt text to identify the UI state and whether the image is before or after.
Jacksondr5/j5code#698 — The template requires manually written screenshot alt text to identify the state and before-or-after side, and points to the evidence script.
Merge Risk: Minimal · up to dd00d
The screenshot guidance is consistent with the referenced script. No issue identified here needs to be resolved before merging.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title clearly describes the main change: updating the PR template to require descriptive screenshot alt text.
Description check
The description clearly explains the problem, the template change, scope, and checklist status. It omits the optional UI changes, Live testing, and Upstream impact sections, but the checklist explains…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description clearly explains the problem, the template change, scope, and checklist status. It omits the optional UI changes, Live testing, and Upstream impact sections, but the checklist explains why those sections do not apply. The description is sufficiently complete for this template-only change.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
The reason will be displayed to describe this comment to others. Learn more.
Additional comments: 1
.github/pull_request_template.md-13-13: 1
13-13: Minor · Maintainability & Code Quality · Quick win
Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.
Correct the grammar in the guidance.
The phrase as the script's do is ungrammatical. Use as the script does:.
Proposed fix
- yourself, each image's alt text names its state and side, as the script's do:+ yourself, each image's alt text names its state and side, as the script does:
Reviewing files that changed from the base of the PR and between 5e45a79 and a0cd096.
Files selected for processing: 1
.github/pull_request_template.md
Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:XS0-9 effective changed lines (test files excluded in mixed PRs).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Before/after screenshots that agents write into PR tables by hand use bare
![Before]and![After]alt text (#820, #814, #808, #807, #765). When a viewer shows the images on their own, as J5's does, that alt text is all that tells you which state an image shows. The row's first column says the state, but the image tag never gets it.What changed
The comment in the template's "UI changes" section now points to
scripts/j5/pr-evidence.ts, which uploads the images and prints the table. Its output already gets the alt text right (![<caption>, before]), as in #824, #823 and #797. The comment also says that a table written by hand should name the state and side in each image's alt text, with a good example next to a bad one.The same rule is now in the developer's machine-wide agent instructions, outside this repo, so it applies in every repo.
Checklist
docs/j5/process/pull-requests.mdand thej5-live-testskill stay accurate; the skill already sends agents to the scriptClaude Opus 5.5 in Claude Code (J5 Code).
🤖 Generated with Claude Code