Skip to content

feat(mobile): Settings › Personas uses compact settings rows, and its dark-mode text reads - #885

Merged
Jacksondr5 merged 2 commits into
j5/mainfrom
j5code/mobile-personas-compact
Nov 1, 2026
Merged

Jacksondr5 merged 2 commits into
j5/mainfrom
j5code/mobile-personas-compact

Conversation

@Jacksondr5

@Jacksondr5 Jacksondr5 commented Nov 1, 2026 •

Copy link
Copy Markdown
Owner

Problem

Settings › Personas on mobile was far less dense than upstream's other settings pages. Each persona was a tall card with stacked badges (Available, Full access, Folder) and a row of toggle, pencil, menu and delete. In dark mode, the Playbooks section's "No playbooks yet" description was black on the dark background. Jackson raised both at Checkpoint 1. Closes #867.

What changed

  • Upstream's settings page shape. The page uses upstream's SettingsScreen header ("Personas", with Create as its action) and grouped SettingsSection rows, like Scheduled tasks and the environment route list.
  • One row per persona: its name, a one-line status (availability or Removed · origin · Full access · usage), its switch, and an ellipsis menu (Edit, Duplicate as personal persona, Export YAML, Copy to environment, Remove or Restore). An unavailable persona shows its first blocked reason in danger text. Tapping an editable persona edits it.
  • One row per source folder: the path on one line, truncated in the middle (as in fix(mobile): a persona source folder's path stays on one readable line #850), its status and git nudges, and a menu with "Stop reading this folder".
  • Action rows: "Import persona file", "Import a folder of personas" and "Add folder" are rows. The environment choice is a select row when several environments are connected.
  • Section footers: the explanations moved there.
  • Header and insets: the page builds on fix(mobile): J5 screens sit below the header and status bar on iOS #874's ScreenScrollView, so its header and insets are now upstream's.
  • Dark-mode text: PlaybookLibrarySettingsScreen used web-only colour classes that mobile's theme doesn't define (text-muted-foreground, text-destructive), so the text fell back to black. They're now mobile's text-foreground-muted and text-danger-foreground. No other J5 mobile file uses web-only colour classes. fix(mobile): J5's sheets follow the app theme in dark mode #876 had already fixed the J5 sheets.

No behaviour changed: every action calls the same handler as before.

UI changes

Captured by the wave-2 Android tester: before on j5/main (c199a7e), after on this branch (ec60a24). Each pair uses the same device, theme and persona content. A shorter page after the change shows more of the content below.

Android

State Before After
Populated persona library, with Haiku helper disabled and Luna helper available, light Populated persona library, with Haiku helper disabled and Luna helper available, light, Android, before Populated persona library, with Haiku helper disabled and Luna helper available, light, Android, after
Populated persona library, with Haiku helper disabled and Luna helper available, dark Populated persona library, with Haiku helper disabled and Luna helper available, dark, Android, before Populated persona library, with Haiku helper disabled and Luna helper available, dark, Android, after
Unavailable persona and its blocked reason, light Unavailable persona and its blocked reason, light, Android, before Unavailable persona and its blocked reason, light, Android, after
Unavailable persona and its blocked reason, dark Unavailable persona and its blocked reason, dark, Android, before Unavailable persona and its blocked reason, dark, Android, after
Removed Luna helper persona, light Removed Luna helper persona, light, Android, before Removed Luna helper persona, light, Android, after
Removed Luna helper persona, dark Removed Luna helper persona, dark, Android, before Removed Luna helper persona, dark, Android, after
Removed Luna helper persona's menu, light Removed Luna helper persona's menu, light, Android, before Removed Luna helper persona's menu, light, Android, after
Removed Luna helper persona's menu, dark Removed Luna helper persona's menu, dark, Android, before Removed Luna helper persona's menu, dark, Android, after
Empty persona library, light Empty persona library, light, Android, before Empty persona library, light, Android, after
Empty persona library, dark Empty persona library, dark, Android, before Empty persona library, dark, Android, after
Persona source folder and empty Playbooks, light Persona source folder and empty Playbooks, light, Android, before Persona source folder and empty Playbooks, light, Android, after
Persona source folder and empty Playbooks, dark Persona source folder and empty Playbooks, dark, Android, before Persona source folder and empty Playbooks, dark, Android, after

iOS

State Before After
Populated persona library, with Haiku helper disabled and Luna helper available, light Populated persona library, with Haiku helper disabled and Luna helper available, light, iOS, before Populated persona library, with Haiku helper disabled and Luna helper available, light, iOS, after
Populated persona library, with Haiku helper disabled and Luna helper available, dark Populated persona library, with Haiku helper disabled and Luna helper available, dark, iOS, before Populated persona library, with Haiku helper disabled and Luna helper available, dark, iOS, after
Unavailable persona and its blocked reason, light Unavailable persona and its blocked reason, light, iOS, before Unavailable persona and its blocked reason, light, iOS, after
Unavailable persona and its blocked reason, dark Unavailable persona and its blocked reason, dark, iOS, before Unavailable persona and its blocked reason, dark, iOS, after
Removed Luna helper persona, light Removed Luna helper persona, light, iOS, before Removed Luna helper persona, light, iOS, after
Removed Luna helper persona, dark Removed Luna helper persona, dark, iOS, before Removed Luna helper persona, dark, iOS, after
Removed Luna helper persona's menu, light Removed Luna helper persona's menu, light, iOS, before Removed Luna helper persona's menu, light, iOS, after
Removed Luna helper persona's menu, dark Removed Luna helper persona's menu, dark, iOS, before Removed Luna helper persona's menu, dark, iOS, after
Empty persona library, light Empty persona library, light, iOS, before Empty persona library, light, iOS, after
Empty persona library, dark Empty persona library, dark, iOS, before Empty persona library, dark, iOS, after
Persona source folder and empty Playbooks, light Persona source folder and empty Playbooks, light, iOS, before Persona source folder and empty Playbooks, light, iOS, after
Persona source folder and empty Playbooks, dark Persona source folder and empty Playbooks, dark, iOS, before Persona source folder and empty Playbooks, dark, iOS, after

Before, a removed persona's menu offered Duplicate and Export; after, it offers Restore only. The Playbooks description was black on the dark background before and is readable after, on both platforms. On iOS, the dark menu captures were taken by switching to dark with the menu already open, so the native popup keeps its light look; the same method was used on both sides.

Live testing

PASS for the exercised paths on Android and iOS at ec60a24 (wave-2 Android tester, report test-reports/mobile-wave2-android/ec60a2413e.md). No new defect was found.

Check Android iOS
All six states above, light and dark Pass Pass
Switch, disabled → enabled and back Pass Not repeated
Duplicate, then tap the copy's row to edit Pass Not repeated
Export YAML (native share sheet) Pass Not repeated
Import a persona file; an existing id shows the replace sheet Pass Not repeated
Remove (a personal copy goes; a folder persona shows Removed) Pass Pass
Removed row: tap does nothing, menu is Restore only, Restore works Pass Pass
Stop reading a source folder Pass Pass
Add folder Partial: the picker opened, but the rig's keyboard tooling kept typing into system settings Pass: empty library, Add folder, three definitions back
Launch a restored persona Not run Pass: a new Luna helper thread completed a turn in the isolated repo

Not exercised: Add folder end to end on Android (a rig input problem, not a product one; the web workaround isn't counted as a pass), several environments and Copy to environment, folder-import batches, git-backed source nudges, tablet layouts, large libraries, and forced loading or error states. There's no video: the change is static layout.

Checklist

  • One concern: the description has no "also". Both changes are Mobile: compact the Personas settings page to match upstream's settings, and fix dark-mode text #867: the page's layout and its text colours.
  • Tests cover the changed behavior: personaRowActions.test.ts for which actions a row offers (a removed persona: Restore only); layout and colour are shown by the captures; reactCompilerCoverage still compiles the screen
  • UI changes: Android and iOS before/after, light and dark, above; limits under Live testing
  • Live testing: the section above says what ran live and what did not
  • Upstream-owned files: none; both files are J5's (apps/mobile/src/j5/)
  • Upstream product: no change
  • Surfaces: the mobile Personas page and its Playbooks section. Web has its own page.
  • Docs: none

Built by Claude Opus 5.5 in Claude Code (J5 Code crew seat builder-composer).

🤖 Generated with Claude Code

… dark-mode text reads

The Personas page used tall cards with stacked badges and a row of four
controls per persona, far less dense than upstream's other settings pages.
It now uses upstream's SettingsScreen header (title, and Create as its
action) and grouped settings rows: each persona is one row with its name,
a one-line status, its switch and an ellipsis menu (Edit, Duplicate,
Export, Copy to environment, Remove or Restore); each source folder is one
row with a menu; Import and Add folder are action rows; the explanations
are section footers. Tapping an editable persona edits it.

The Playbooks section used web-only colour classes (text-muted-foreground,
text-destructive) that mobile's theme doesn't define, so its empty state
read black on the dark background; they are mobile's text-foreground-muted
and text-danger-foreground now.

Closes #867

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
j5-code Ready Ready Preview Nov 1, 2026 9:19pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 4 billable files and costs up to $1.00.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 26 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 3 included reviews currently available. Your 46 included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between c199a7e and ec60a24.

Files selected for processing: 4
  • apps/mobile/src/j5/agents/AgentLibrarySettingsScreen.tsx
  • apps/mobile/src/j5/agents/personaRowActions.test.ts
  • apps/mobile/src/j5/agents/personaRowActions.ts
  • apps/mobile/src/j5/playbooks/PlaybookLibrarySettingsScreen.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions github-actions Bot added the size:XL 500-999 effective changed lines (test files excluded in mixed PRs). label Nov 1, 2026
@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Nov 1, 2026

@Jacksondr5 Jacksondr5 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combined panel review (reviewer-opus + reviewer-sol) at 2d95a4b

Verdict: no correctness findings, and the panel approves the source. Still pending: device captures of every state #867 lists (several personas, a folder source, unavailable and disabled personas, empty; iOS and Android; light and dark), plus an action pass on device.

  • Handlers unchanged. Every persona action (toggle, edit, duplicate, export, copy to environment, remove, restore) and the folder "Stop reading" still calls the same handler. The locked and busy gates are the same. The folder removal still filters by configuredPath. Create, as an AppBar action, also guards against a missing environment.
  • Layout follows upstream. SettingsScreen and SettingsSection rows, SettingsActionRow, section footers and ThemedSwitch. #874's ScreenScrollView and #876's sheet surfaces are kept.
  • Colours. The Playbooks tokens map to mobile's (text-foreground-muted, text-danger-foreground). No web-only colour classes remain under apps/mobile/src/j5.
  • Reviewer-run: reactCompilerCoverage.test.ts and upstreamSeams.test.ts pass (1063), mobile vp run typecheck exits 0, and lint is clean. It's layout only, so no UI tests are asked for.

Observations for the captures and Checkpoint 2 (not blockers)

  • Descriptions are now only an accessibility hint (both reviewers). A sighted reader no longer sees a persona's description, and folder-source personas have no detail view where it would show. It's a reasonable trade-off for compact rows, but worth Jackson seeing in the captures.
  • Removed personas (reviewer-opus). The old row hid Edit for a removed persona, which showed only Restore. Now a removed imported persona with an edit target can be edited by tapping the row or from the menu. If that's not intended, gating onEdit on !persona.removed restores the old behaviour.
  • Blocked reasons (reviewer-opus). The old row listed every blockedReasons entry. The new one shows the first, up to two lines.

Reviewed by Claude Opus 5.5 (reviewer-opus) and Sol 6.1 (reviewer-sol) in J5 Code.

The compact row let a removed persona be edited by tapping it or from its
menu, and offered Duplicate, Export and Copy beside Restore; the old row
offered only Restore. The row's actions now come from personaRowActions,
which gives a removed persona Restore alone, and tapping the row edits only
when Edit is offered.

Refs #867

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@Jacksondr5 Jacksondr5 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Panel delta check (reviewer-opus + reviewer-sol) at ec60a24

Verdict: the removed-persona observation is resolved, with no new findings. The panel's source approval stands.

  • personaRowActions (pure, J5-owned) returns only ["restore"] for a removed persona. Otherwise it returns edit (when editable), duplicate, export, copy (when another environment exists) and remove, in menu order. The menu maps that list, and tapping the row edits only when "edit" is offered. A removed row already had no switch. The gates (locked, busy, unsupported) are unchanged.
  • personaRowActions.test.ts covers the removed+editable, editable and non-editable cases.
  • Reviewer-run: personaRowActions.test.ts and reactCompilerCoverage.test.ts pass (1020), and mobile vp run typecheck exits 0.

Still pending: device captures of #867's states. The description-as-hint observation still stands for Jackson to judge.

Reviewed by Claude Opus 5.5 (reviewer-opus) and Sol 6.1 (reviewer-sol) in J5 Code.

@Jacksondr5
Jacksondr5 merged commit 2bd99d8 into j5/main Nov 1, 2026
33 checks passed
@Jacksondr5
Jacksondr5 deleted the j5code/mobile-personas-compact branch November 1, 2026 21:45

This branch was successfully deployed

1 active deployment
Preview — ec60a241 Deployed Nov 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500-999 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile: compact the Personas settings page to match upstream's settings, and fix dark-mode text

1 participant