Repository navigation
feat(mobile): Settings › Personas uses compact settings rows, and its dark-mode text reads - #885
Conversation
… dark-mode text reads The Personas page used tall cards with stacked badges and a row of four controls per persona, far less dense than upstream's other settings pages. It now uses upstream's SettingsScreen header (title, and Create as its action) and grouped settings rows: each persona is one row with its name, a one-line status, its switch and an ellipsis menu (Edit, Duplicate, Export, Copy to environment, Remove or Restore); each source folder is one row with a menu; Import and Add folder are action rows; the explanations are section footers. Tapping an editable persona edits it. The Playbooks section used web-only colour classes (text-muted-foreground, text-destructive) that mobile's theme doesn't define, so its empty state read black on the dark background; they are mobile's text-foreground-muted and text-danger-foreground now. Closes #867 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
This review includes 4 billable files and costs up to $1.00.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 26 minutes for your next included review. View limit details
|
Jacksondr5
left a comment
There was a problem hiding this comment.
Combined panel review (reviewer-opus + reviewer-sol) at 2d95a4b
Verdict: no correctness findings, and the panel approves the source. Still pending: device captures of every state #867 lists (several personas, a folder source, unavailable and disabled personas, empty; iOS and Android; light and dark), plus an action pass on device.
- Handlers unchanged. Every persona action (toggle, edit, duplicate, export, copy to environment, remove, restore) and the folder "Stop reading" still calls the same handler. The
lockedandbusygates are the same. The folder removal still filters byconfiguredPath. Create, as an AppBar action, also guards against a missing environment. - Layout follows upstream.
SettingsScreenandSettingsSectionrows,SettingsActionRow, section footers andThemedSwitch. #874'sScreenScrollViewand #876's sheet surfaces are kept. - Colours. The Playbooks tokens map to mobile's (
text-foreground-muted,text-danger-foreground). No web-only colour classes remain underapps/mobile/src/j5. - Reviewer-run:
reactCompilerCoverage.test.tsandupstreamSeams.test.tspass (1063), mobilevp run typecheckexits 0, and lint is clean. It's layout only, so no UI tests are asked for.
Observations for the captures and Checkpoint 2 (not blockers)
- Descriptions are now only an accessibility hint (both reviewers). A sighted reader no longer sees a persona's description, and folder-source personas have no detail view where it would show. It's a reasonable trade-off for compact rows, but worth Jackson seeing in the captures.
- Removed personas (reviewer-opus). The old row hid Edit for a removed persona, which showed only Restore. Now a removed imported persona with an
edittarget can be edited by tapping the row or from the menu. If that's not intended, gatingonEditon!persona.removedrestores the old behaviour. - Blocked reasons (reviewer-opus). The old row listed every
blockedReasonsentry. The new one shows the first, up to two lines.
Reviewed by Claude Opus 5.5 (reviewer-opus) and Sol 6.1 (reviewer-sol) in J5 Code.
The compact row let a removed persona be edited by tapping it or from its menu, and offered Duplicate, Export and Copy beside Restore; the old row offered only Restore. The row's actions now come from personaRowActions, which gives a removed persona Restore alone, and tapping the row edits only when Edit is offered. Refs #867 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Jacksondr5
left a comment
There was a problem hiding this comment.
Panel delta check (reviewer-opus + reviewer-sol) at ec60a24
Verdict: the removed-persona observation is resolved, with no new findings. The panel's source approval stands.
personaRowActions(pure, J5-owned) returns only["restore"]for a removed persona. Otherwise it returns edit (when editable), duplicate, export, copy (when another environment exists) and remove, in menu order. The menu maps that list, and tapping the row edits only when "edit" is offered. A removed row already had no switch. The gates (locked,busy,unsupported) are unchanged.personaRowActions.test.tscovers the removed+editable, editable and non-editable cases.- Reviewer-run:
personaRowActions.test.tsandreactCompilerCoverage.test.tspass (1020), and mobilevp run typecheckexits 0.
Still pending: device captures of #867's states. The description-as-hint observation still stands for Jackson to judge.
Reviewed by Claude Opus 5.5 (reviewer-opus) and Sol 6.1 (reviewer-sol) in J5 Code.
Problem
Settings › Personas on mobile was far less dense than upstream's other settings pages. Each persona was a tall card with stacked badges (Available, Full access, Folder) and a row of toggle, pencil, menu and delete. In dark mode, the Playbooks section's "No playbooks yet" description was black on the dark background. Jackson raised both at Checkpoint 1. Closes #867.
What changed
SettingsScreenheader ("Personas", with Create as its action) and groupedSettingsSectionrows, like Scheduled tasks and the environment route list.ScreenScrollView, so its header and insets are now upstream's.PlaybookLibrarySettingsScreenused web-only colour classes that mobile's theme doesn't define (text-muted-foreground,text-destructive), so the text fell back to black. They're now mobile'stext-foreground-mutedandtext-danger-foreground. No other J5 mobile file uses web-only colour classes. fix(mobile): J5's sheets follow the app theme in dark mode #876 had already fixed the J5 sheets.No behaviour changed: every action calls the same handler as before.
UI changes
Captured by the wave-2 Android tester: before on
j5/main(c199a7e), after on this branch (ec60a24). Each pair uses the same device, theme and persona content. A shorter page after the change shows more of the content below.Android
iOS
Before, a removed persona's menu offered Duplicate and Export; after, it offers Restore only. The Playbooks description was black on the dark background before and is readable after, on both platforms. On iOS, the dark menu captures were taken by switching to dark with the menu already open, so the native popup keeps its light look; the same method was used on both sides.
Live testing
PASS for the exercised paths on Android and iOS at ec60a24 (wave-2 Android tester, report
test-reports/mobile-wave2-android/ec60a2413e.md). No new defect was found.Not exercised: Add folder end to end on Android (a rig input problem, not a product one; the web workaround isn't counted as a pass), several environments and Copy to environment, folder-import batches, git-backed source nudges, tablet layouts, large libraries, and forced loading or error states. There's no video: the change is static layout.
Checklist
personaRowActions.test.tsfor which actions a row offers (a removed persona: Restore only); layout and colour are shown by the captures;reactCompilerCoveragestill compiles the screenapps/mobile/src/j5/)Built by Claude Opus 5.5 in Claude Code (J5 Code crew seat builder-composer).
🤖 Generated with Claude Code