Repository navigation
feat(mobile): an Inbox bell with the open count in the thread list's header - #888
Conversation
…header The thread list's header gets a bell (#830, part 4 of 4) with the open count across every connected server, marked when a server could not be read, that opens the Inbox: beside the filter on Android, in the right toolbar on an iPhone, and beside the filter in the split view's sidebar. It counts open asks only; Crew requests join it with Crews. The bell's text is now one shared function, used by web's bell too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
This review includes 12 billable files and costs up to $3.00.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 6 minutes for your next included review. View limit details
|
Jacksondr5
left a comment
There was a problem hiding this comment.
Combined review: reviewer-opus and reviewer-sol (Claude Opus 5.5 and GPT Sol 6.1), head 69cea90
Both of us reviewed the PR independently and checked each finding against the source. One finding blocks merge.
Blocking
-
iPad has no Inbox bell, and the sidebar seam never renders (found by reviewer-sol, confirmed by reviewer-opus).
- The sidebar seam. On iOS,
ThreadNavigationSidebaralways rendersNativeSidebarContainerwithnativeChromeset (ThreadNavigationSidebar.tsx:112–127), and the pane returns early at:714. The non-native header that holds the new<InboxBell variant="sidebar" />(:885) is therefore never reached on iOS. On Android the:853branch rendersThreadListToolbarinstead. So that seam is dead code in an upstream file. - The toolbar. On iPad, the thread list's chrome is
WorkspaceRootContent'sWorkspaceToolbar(WorkspaceRootScreen.tsx:227), which mounts for the threads tab on every iOS device. The new bell there is gated todeviceType === "phone"(WorkspaceToolbar.ios.tsx:194), so iPad and the Duo layouts get none. - Result. On iPad there is no way into the Inbox.
Fix: show the toolbar bell wherever the iOS threads toolbar shows. The likely change is to drop
&& deviceType === "phone", or limit it to the layouts where the list is visible. Remove the unreachableThreadNavigationSidebar.tsxseam, along with its seam-test row and its FORK case 102 and file-index mentions. The tester should then confirm exactly one bell on iPhone, iPad and Android. - The sidebar seam. On iOS,
Checked and fine
- Bell text.
inboxBellPresentationis web's old inline logic exactly: the badge is the count,count*or?, and the label string is unchanged. Web's bell now uses it. - Count.
inboxCountSourcesAtomuses the same source input.openCountalready rereads on theinboxrevision, so there's no timer, and #887'srefreshAfterAnswerrefreshes it too. - Android. The
ThreadListToolbarseam, gated onhasConnections, covers the phone header and the Android sidebar. - Glyph.
BellGlyphuses SFbellon iOS and Tabler'sIconBellon Android, which is already a mobile dependency. - Scope. Crew requests stay out of the count until #836, as the Captain agreed.
iOS draws its split view's sidebar header natively, through the workspace toolbar, so the bell there was limited to phones and the sidebar's own bell never rendered on iPad. The toolbar now shows it on every iOS thread list; the sidebar's bell is Android's split view. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Jacksondr5
left a comment
There was a problem hiding this comment.
Combined review: reviewer-opus and reviewer-sol, head dfa49be
Fixed: iPad's way in. WorkspaceToolbar.ios.tsx now shows the bell whenever selectedTab === "threads", on every iOS device, so iPad gets one bell in the toolbar its thread list actually uses.
Still blocking: the sidebar seam is dead code, and the new comment and FORK text describe it wrongly
ThreadNavigationSidebar.tsx:853 is Platform.OS === "android" ? <ThreadListToolbar … /> : <View …>. The <InboxBell variant="sidebar" /> at :886 sits in the non-Android branch:
- Android always takes
ThreadListToolbar, which already carries the bell through theThreadListToolbar.tsxseam. - iOS returns at
:714(nativeChrome) before reaching:853.
So the bell is never drawn on any mobile platform. The comment's "Android's split view" is wrong, and so is FORK case 102's account of it. This can be seen from the source alone; no device run is needed.
Fix: remove the InboxBell import and JSX from ThreadNavigationSidebar.tsx, and remove its seam-test row and its FORK case 102 and file-index mentions. Case 102 then has two live seams, ThreadListToolbar.tsx and WorkspaceToolbar.ios.tsx. Nothing else needs to change.
Android's split view takes ThreadListToolbar and iOS draws the sidebar header natively, so the sidebar's own bell never rendered. Two seams remain. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Jacksondr5
left a comment
There was a problem hiding this comment.
Combined review: reviewer-opus and reviewer-sol, head 143628e
Fixed. ThreadNavigationSidebar.tsx is byte-identical to trunk again: its diff against the merge base is empty. Its seam row and file-index row are gone, and FORK case 102 now names the two live seams: ThreadListToolbar.tsx (Android, including its split-view sidebar header) and WorkspaceToolbar.ios.tsx (iPhone and iPad). With the sidebar variant gone, InboxBell drops its variant prop and keeps the header look.
The panel has no open code findings. Before merge it still needs the tester's device run (one bell on Android and iPhone, with the count and the way into the Inbox; iPad has been verified by reading the code only, as the PR says) and green J5 CI.
Problem
Mobile's Inbox (#883, #887) has no way in. Nothing on the phone says something is waiting on the person, and the screen is reached only by deep link (#830; gap A9).
What changed
Part 4 of 4 for #830: a bell with the open count in the thread list's header, which opens the Inbox, as web's rail bell does.
inboxCountSourcesAtom, built like web's). A count some server couldn't refresh is marked3*, or?when nothing is known. The spoken label says so ("Open inbox, last known 3 open; some environments could not be refreshed"). Badge and label come from one shared function,inboxBellPresentationinclient-runtime/src/j5/inbox.ts, which web's bell now uses too; its inline copy is removed, and its test moved toclient-runtime.BellGlyphdraws Tabler's bell there and the SF Symbolbellon iOS (BellGlyph.tsxandBellGlyph.ios.tsx), rather than editing upstream's symbol map.This completes #830 as scoped. Push notifications (#829) and Crew requests (#836) stay out.
UI changes
Android, base
ba3dc4e770(no bell) vs head143628ecb1, cropped to the header, with the same viewport and theme:iPhone, base vs head
143628ecb1, cropped to the header:The iPhone shots of the owner's header show iOS's native scroll-edge blur, which is expected.
Android: the bell's count rises live as asks arrive, the bell opens the Inbox, and answering from web drops it from 3 to 2 while the header stays open.
Android-Inbox-bell-live-count-and-answer.mp4
Live testing
Verdict: PASS on Android and iPhone at
143628ecb1. The crew tester ran it (Sol 6.1) with real Claude Haiku 5.5 asks. Report:artifacts/test-reports/j5code-mobile-tester-sol/143628ecb1.md. The video was checked for a signed-out viewer (200 video/mp4).dfa49be1e1, video).3*, and the spoken label says last-known; a whole-server Viewer has no badge, and the bell opens the Inbox's "not shared with you".2*, with the last-known label.Not exercised:
WorkspaceToolbar, which now shows the bell on every iOS device.?): not exercised; the logic is shared and tested.dfa49be1e1. The later change only removed unused code from a branch no device draws.Upstream impact
FORK.md case 102. One import and one or two lines in each of two files:
apps/mobile/src/features/home/ThreadListToolbar.tsx(Android toolbar, beside the filter, when a server is saved);apps/mobile/src/features/workspace/WorkspaceToolbar.ios.tsx(aToolbar.Customon the thread list, iPhone and iPad);Both are pinned in
upstreamSeams.test.tsand listed in the file index.Checklist
inboxBellPresentation(count, none, marked-incomplete) inclient-runtime, and the seams are pinnedBuilt by Claude Opus 5.5 in Claude Code (J5 crew seat builder-identity).
🤖 Generated with Claude Code