Repository navigation
fix(mobile): an answered question reads as its question, answer and who gave it - #897
Conversation
…ho gave it Opening a resolved native question drew its raw item JSON under the readable answer, and in the folded row a long question pushed the answer out of the one truncating label, leaving only the question. An answered question's opened row now stops at its question and answer, as on web, and the folded row keeps the answer and who gave it outside the label so the question truncates first. Closes #891 Closes #869 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
This review includes 5 billable files and costs up to $1.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 26 minutes for your next included review. View limit details
|
Jacksondr5
left a comment
There was a problem hiding this comment.
Combined review: reviewer-opus and reviewer-sol (Claude Opus 5.5 and GPT Sol 6.1), head 7d7c7e7
Both of us reviewed the PR independently. Neither found anything that blocks merge.
- The JSON blob.
questionAnsweris set only onuser_input_requestitems (threadActivity.ts:789). For that type there's nocall, no fetched detail and no output, sofullDetailwas the only way the raw item reached the row. Skipping it leaves upstream'sQuestionAnswerHistory, and the row can still open (:906). - Folded row.
hasQuestionAnswerstops the question-text fallback being drawn as an answer: with no answer, it stays in the label, as upstream draws it. An opened row passesanswer: null, so the header doesn't repeat what the history shows. - Layout. The label is
min-w-0 flex-1, the answer ismax-w-[45%] shrinkand the name isshrink-0, all on one line, so the question truncates first. - Approvals. They carry no
questionAnswer, so they keep upstream's detail, and "answered by" still comes fromisSettledPrompt. - Tests. The seam test and the
filePreviewmock follow the rename. 158 focused tests pass (140 mobile, 18 shared).
Notes (not blocking):
- With a short question, the
flex-1label leaves the answer and name at the row's right edge. The tester's captures can judge that. - This changes what upstream's row shows. Jackson's decision is linked, and the register entry is deferred to the docs PR, as the checklist says. It needs to land there.
The panel has no open code findings. The proof is the captures, so before merge it still needs those, the tester's run and green J5 CI.
Problem
On mobile, opening a resolved native question drew its raw item as a giant JSON blob under the readable answer. In the folded row, a long question pushed the answer out of the one truncating label, so the row read as only the question. Jackson's direction at Checkpoint 2: minimize it to the question, the answer and who answered. Closes #891. Closes #869: Jackson named this row as what "I only see the question" was about, the folded "before" above shows it, and #869's avatars half shipped in #879.
What changed
QuestionAnswerHistoryalready draws. The raw item JSON goes, as web draws neither. Other work rows, approvals included, keep upstream's detail.An answered prompt keeps its row on the same fixed height; nothing else about the row moves.
UI changes
iOS Simulator: the same real question, answered by Priya on web, at the same size and theme. Before is the code path as on trunk, after is
7d7c7e72d9.A question answered by Priya, opened.
The same question, folded.
Android 16 emulator, 1080×2400 in the light theme: the same stored questions and answers on both sides, cropped to the row. Before is base
105dafde53, after is7d7c7e72d9. Opened questions differ in height because the JSON is gone.With a long typed answer, the question shrinks to "…" so the answer and name stay visible; the opened row has the whole question. The approval's opened detail and the unanswered question are unchanged on purpose.
Live testing
Android: pass at
7d7c7e72d9, by the wave 3 Android tester, on an isolated test server with six real Claude Haiku turns and Priya as a thread Collaborator on web: every row in the table above, collapsing again after opening, and a fresh turn sent from the phone on head. Report: project artifacttest-reports/pr-897/7d7c7e72d9.md.iOS: pass at
7d7c7e72d9, by the Sol iOS tester, on the Simulator: one real question that Priya answered, folded and opened. Report: project artifacttest-reports/j5code-mobile-tester-sol/wave3-ios-105dafde53.md.Not exercised:
No video, because nothing here moves.
Upstream impact
apps/mobile/src/features/threads/thread-work-log.tsx: case 99 (PromptAnswerTailreplacesPromptAnsweredBy; an answered question'sfullDetailis skipped).This changes what upstream's mobile row shows: upstream still draws the raw JSON here, and its web doesn't. Decided by Jackson at Checkpoint 2 (#891). The register entry goes in the docs PR, per the Captain.
Checklist
FORK.mdcase 99, whose file-table row already lists this fileClaude Opus 5.5 in J5 Code (Claude Code harness).
🤖 Generated with Claude Code