Skip to content

fix(mobile): an answered question reads as its question, answer and who gave it - #897

Merged
Jacksondr5 merged 1 commit into
j5/mainfrom
j5code/mobile-question-answer
Nov 2, 2026
Merged

Jacksondr5 merged 1 commit into
j5/mainfrom
j5code/mobile-question-answer

Conversation

@Jacksondr5

@Jacksondr5 Jacksondr5 commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner

Problem

On mobile, opening a resolved native question drew its raw item as a giant JSON blob under the readable answer. In the folded row, a long question pushed the answer out of the one truncating label, so the row read as only the question. Jackson's direction at Checkpoint 2: minimize it to the question, the answer and who answered. Closes #891. Closes #869: Jackson named this row as what "I only see the question" was about, the folded "before" above shows it, and #869's avatars half shipped in #879.

What changed

  • Opened row: an answered question stops at its question and answer, which upstream's QuestionAnswerHistory already draws. The raw item JSON goes, as web draws neither. Other work rows, approvals included, keep upstream's detail.
  • Folded row: the answer and "· answered by Priya" sit together after the label, so the question truncates first and the answer and name stay visible. The answer can take up to 45% of the row, then truncates. An unshared thread's row shows the question and answer with no name.

An answered prompt keeps its row on the same fixed height; nothing else about the row moves.

UI changes

iOS Simulator: the same real question, answered by Priya on web, at the same size and theme. Before is the code path as on trunk, after is 7d7c7e72d9.

A question answered by Priya, opened.

  • Before: the raw item JSON under the answer.
  • After: the question, the answer and who answered.
Before After
An answered question opened on iOS, before: raw JSON under the answer An answered question opened on iOS, after: the question, the answer and who answered

The same question, folded.

  • Before: the question and the name, with the answer cut off.
  • After: the question truncates, and "Small pilot" and "· answered by Priya" stay.
Before After
An answered question folded on iOS, before: the answer cut off An answered question folded on iOS, after: the answer and who answered both visible

Android 16 emulator, 1080×2400 in the light theme: the same stored questions and answers on both sides, cropped to the row. Before is base 105dafde53, after is 7d7c7e72d9. Opened questions differ in height because the JSON is gone.

State Before After
Shared question answered by Priya, folded Shared question answered by Priya, folded, before Shared question answered by Priya, folded, after
Shared question answered by Priya, opened Shared question answered by Priya, opened, before Shared question answered by Priya, opened, after
Long question with a short answer from Priya Long question with a short answer from Priya, before Long question with a short answer from Priya, after
Long typed answer from Priya Long typed answer from Priya, before Long typed answer from Priya, after
Two questions answered by you, folded Two questions answered by you, folded, before Two questions answered by you, folded, after
Two questions answered by you, opened Two questions answered by you, opened, before Two questions answered by you, opened, after
Unshared answered question with no name, folded Unshared answered question with no name, folded, before Unshared answered question with no name, folded, after
Unshared answered question with no name, opened Unshared answered question with no name, opened, before Unshared answered question with no name, opened, after
Command approval answered by Priya, folded Command approval answered by Priya, folded, before Command approval answered by Priya, folded, after
Command approval with its existing detail, opened Command approval with its existing detail, opened, before Command approval with its existing detail, opened, after
Unanswered question Unanswered question, before Unanswered question, after

With a long typed answer, the question shrinks to "…" so the answer and name stay visible; the opened row has the whole question. The approval's opened detail and the unanswered question are unchanged on purpose.

Live testing

Android: pass at 7d7c7e72d9, by the wave 3 Android tester, on an isolated test server with six real Claude Haiku turns and Priya as a thread Collaborator on web: every row in the table above, collapsing again after opening, and a fresh turn sent from the phone on head. Report: project artifact test-reports/pr-897/7d7c7e72d9.md.

iOS: pass at 7d7c7e72d9, by the Sol iOS tester, on the Simulator: one real question that Priya answered, folded and opened. Report: project artifact test-reports/j5code-mobile-tester-sol/wave3-ios-105dafde53.md.

Not exercised:

  • the wider row set on iOS, and iOS on Jackson's phone;
  • the dark theme;
  • non-Haiku providers (no adapter or protocol changed);
  • a clipboard round trip.

No video, because nothing here moves.

Upstream impact

  • apps/mobile/src/features/threads/thread-work-log.tsx: case 99 (PromptAnswerTail replaces PromptAnsweredBy; an answered question's fullDetail is skipped).

This changes what upstream's mobile row shows: upstream still draws the raw JSON here, and its web doesn't. Decided by Jackson at Checkpoint 2 (#891). The register entry goes in the docs PR, per the Captain.

Checklist

  • One concern: the description has no "also"
  • Tests cover the changed behavior: a visual change, proved by captures; the seam test holds the edit
  • UI changes: before/after above (Android and iOS)
  • Live testing: the section above says what ran live and what did not
  • Upstream-owned files: recorded in FORK.md case 99, whose file-table row already lists this file
  • Upstream product: Jackson's decision is linked above; the register entry is pending in the docs PR
  • Surfaces: mobile only, since web already reads this way. The opened row's Copy still copies the raw item, as upstream's does; nothing else in the row changes.
  • Docs: none in this PR, per the Captain

Claude Opus 5.5 in J5 Code (Claude Code harness).

🤖 Generated with Claude Code

…ho gave it

Opening a resolved native question drew its raw item JSON under the
readable answer, and in the folded row a long question pushed the answer
out of the one truncating label, leaving only the question. An answered
question's opened row now stops at its question and answer, as on web,
and the folded row keeps the answer and who gave it outside the label so
the question truncates first.

Closes #891
Closes #869

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
j5-code Ready Ready Preview Nov 2, 2026 2:43am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 5 billable files and costs up to $1.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 26 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 51 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 105dafd and 7d7c7e7.

Files selected for processing: 5
  • FORK.md
  • apps/mobile/src/features/threads/thread-work-log.tsx
  • apps/mobile/src/j5/sharing/sharedConversation.tsx
  • apps/mobile/src/j5/upstreamSeams.test.ts
  • apps/mobile/src/lib/filePreview.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Nov 2, 2026
@github-actions github-actions Bot added the size:M 30-99 effective changed lines (test files excluded in mixed PRs). label Nov 2, 2026

@Jacksondr5 Jacksondr5 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combined review: reviewer-opus and reviewer-sol (Claude Opus 5.5 and GPT Sol 6.1), head 7d7c7e7

Both of us reviewed the PR independently. Neither found anything that blocks merge.

  • The JSON blob. questionAnswer is set only on user_input_request items (threadActivity.ts:789). For that type there's no call, no fetched detail and no output, so fullDetail was the only way the raw item reached the row. Skipping it leaves upstream's QuestionAnswerHistory, and the row can still open (:906).
  • Folded row. hasQuestionAnswer stops the question-text fallback being drawn as an answer: with no answer, it stays in the label, as upstream draws it. An opened row passes answer: null, so the header doesn't repeat what the history shows.
  • Layout. The label is min-w-0 flex-1, the answer is max-w-[45%] shrink and the name is shrink-0, all on one line, so the question truncates first.
  • Approvals. They carry no questionAnswer, so they keep upstream's detail, and "answered by" still comes from isSettledPrompt.
  • Tests. The seam test and the filePreview mock follow the rename. 158 focused tests pass (140 mobile, 18 shared).

Notes (not blocking):

  • With a short question, the flex-1 label leaves the answer and name at the row's right edge. The tester's captures can judge that.
  • This changes what upstream's row shows. Jackson's decision is linked, and the register entry is deferred to the docs PR, as the checklist says. It needs to land there.

The panel has no open code findings. The proof is the captures, so before merge it still needs those, the tester's run and green J5 CI.

This branch was successfully deployed

1 active deployment
Preview — 7d7c7e72 Deployed Nov 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile: a native question's answer shows a giant JSON blob Mobile: shared threads show no author avatar, and answered-by isn't visible on iOS

1 participant