Repository navigation
feat(mobile): Personas rows show just the name, and every row opens on a tap - #899
Conversation
…n a tap Each row's status line truncated and repeated what the toggle shows, and tapping a folder persona did nothing. A row is now the persona's name, plus "Removed" on a removed persona and the blocked reason on an unavailable one. Tapping an editable persona opens the editor; any other opens a new read-only sheet, in upstream's settings rows, with its status, source, access, models, description and usage. The sheet reads the models from the definition, falling back to the catalog's route. The toggle lined up with the row only by accident: React Native's Switch sets alignSelf: flex-start, so it now sets center and sits level with the row's menu button. Closes #893 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
This review includes 6 billable files and costs up to $1.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 19 minutes for your next included review. View limit details
|
Jacksondr5
left a comment
There was a problem hiding this comment.
Combined panel review (reviewer-opus + reviewer-sol) at 095c33a
Verdict: two small should-fixes. The Captain may accept either as a tracked follow-up. The source is otherwise approved. Captures and device checks of the row actions are still pending.
Small should-fix 1: a personal persona's usage is no longer reachable on mobile (raised by reviewer-sol)
Tapping an editable persona opens the editor, and only the read-only sheet shows the usage line. So a personal persona's usage now appears nowhere on mobile, though it was visible before. The smallest fix is a "Details" item in the row's menu for editable rows, since the sheet already shows usage. Showing usage in the editor would also work. Or the Captain can accept a tracked follow-up.
Small should-fix 2: the mobile sentences in the user guide are now wrong (raised by reviewer-opus)
docs/j5/user/personas.md:31 says the usage line is "on mobile, in the status line under its name", and that each persona shows its availability badge and origin. #899 removes that status line, and source and status move to the sheet. The builder assigns the guide edit to the wave-3 docs PR, which is fine. Keeping docs out of the UI PR is what we'd want. Please track it there so it doesn't get lost, whichever option fixes usage.
Checked and fine
- Rows. The name, plus "Removed" or the first blocked reason.
ThemedSwitchgetsalignSelf: "center"to override React Native'sflex-start. - The builder's two calls. A removed persona's tap opens the read-only sheet while its menu stays Restore-only, which matches "every row responds to a tap". A read-only session's tap on an editable persona opens the sheet too, and Edit leaves its menu.
onEditnow requirescanOperate, andlocked = busy || !canOperate, so the row'sdisabled={busy}opens no new way to edit. AgentDetailsModal. The read runs once (useAtomCommandreturns a stable callback), a read still in flight is dropped on close, and a failed read falls back to the catalog's route. It uses the themedViewplus inline-flexSafeAreaViewpattern from #876.ListRowLayoutdescriptions aren't line-limited, so full descriptions and paths show.personaDetailRowsis pure and tested: every blocked reason, source path, access, both models with the fallback, description and usage.
Reviewer-run checks
personaDetails.test.ts,personaRowActions.test.ts,reactCompilerCoverage.test.ts: pass (reviewer-opus 1031 for details plus coverage; reviewer-sol 5 in 2 files for the helpers)- mobile
vp run typecheck: exit 0 - lint: clean on
src/j5/agents
For the device pass: tap a folder persona, a personal persona and a removed persona. The toggle lines up with the ⋯ button. The sheet scrolls with a long description.
Reviewed by Claude Opus 5.5 (reviewer-opus) and Sol 6.1 (reviewer-sol) in J5 Code.
Removing the status line left a personal persona's usage with nowhere to show, since its tap opens the editor. The row's menu now opens the same read-only sheet. Rows whose tap already opens the sheet don't offer it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Jacksondr5
left a comment
There was a problem hiding this comment.
Panel delta check (reviewer-opus + reviewer-sol) at 94d43e7
Verdict: the usage finding is resolved, and the panel approves the source. An editable, non-removed row now has Details beside Edit, which opens the same sheet through onDetails, so a personal persona's usage is reachable again. Folder and read-only rows already open the sheet on a tap, and removed rows stay Restore-only. personaRowActions.test.ts covers it.
The guide's mobile sentences (docs/j5/user/personas.md:31) stay with the wave-3 docs PR, per the Captain's ruling. Captures and device checks are still pending.
Reviewer-run: personaRowActions.test.ts and reactCompilerCoverage.test.ts pass (1028; reviewer-sol also ran the helper tests, 5 in 2 files). Mobile vp run typecheck exits 0.
Reviewed by Claude Opus 5.5 (reviewer-opus) and Sol 6.1 (reviewer-sol) in J5 Code.
Problem
On the mobile Personas page, each row's status line truncated ("Available · Folder · personas · Full a…") and repeated what the toggle already shows. The toggle sat out of line with the row's
...button. Tapping a personal persona opened its editor, but tapping a folder persona did nothing. Jackson found these at Checkpoint 2. Closes #893.What changed
Rows: just the persona's name. A removed persona also says Removed, since it has no toggle. An unavailable persona keeps its first blocked reason, since the toggle can't show that.
Every row responds to a tap: an editable persona opens the editor, as before. Any other opens a new read-only sheet (
AgentDetailsModal). So does an editable persona for someone whose session can't edit.The read-only sheet: upstream's settings rows (
SettingsSectionandListRowLayout) in a page sheet like the editor's, with Status, Reason (every blocked reason), Source (the folder's full path, or Personal), Access, Primary and Fallback model, Description, and Usage when there is any. It reads the models from the definition on open, as the editor does, and falls back to the catalog's route if that read fails.The toggle: React Native's
SwitchsetsalignSelf: 'flex-start', so it ignored the row'sitems-center. It now setscenterand sits level with the....Other menu items are unchanged. A removed persona's menu still offers only Restore.
Details in the
...menu: only on a row whose tap opens the editor, so a personal persona's usage stays reachable. Every other row's tap already opens the sheet.Tapping a removed persona now opens the read-only sheet, per "every row responds to a tap". It used to do nothing, and it still can't be edited.
The personas guide's sentence about the usage line's place on mobile goes out of date with this. The Captain is collecting it for the wave-3 docs PR.
UI changes
Android 16, same data, viewport and theme on each side: before on
j5/main(105dafde53), after on this branch (94d43e7263).The read-only sheet and the menus are new or changed only on the after side:
No video: the change has no motion. iOS isn't captured yet.
Live testing
Android: PASS at
94d43e7263(crew tester, reporttest-reports/pr-899/94d43e7263.md), on an isolated test server with a real Haiku 5.5 task....stay level on every row, including the taller blocked row, and neither triggers the row's tap.Not exercised: iOS, which waits for the checkpoint or the iOS tester. Also the Restore action itself, the no-persona state, the sheet's loading and read-failure states, other font sizes, and remote or relay connections. The editor's pickers are tracked in #896.
Checklist
personaDetails.test.tscovers what the sheet lists, and the fallback when the definition can't be read.personaRowActions.test.tscovers which rows offer Details.reactCompilerCoveragestill compiles the screens.apps/mobile/src/j5/agents/)personas.mdwording goes in the wave-3 docs PR; the Captain has the sentencesBuilt by Claude Opus 5.5 in Claude Code (J5 Code crew seat builder-composer).
🤖 Generated with Claude Code