Skip to content

feat(j5): platform notices and prompts in the timeline on web - #916

Merged
Jacksondr5 merged 6 commits into
j5/mainfrom
j5/698-timeline-notices
Nov 3, 2026
Merged

Jacksondr5 merged 6 commits into
j5/mainfrom
j5/698-timeline-notices

Conversation

@Jacksondr5

@Jacksondr5 Jacksondr5 commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Problem

J5's platform notices had no shared look on web. Three of them (not delivered, Exchange dropped, ask withdrawn) showed their raw envelope in a "Raw A2A delivery" card. Closes #698.

What changed

Groups 4 and 5 of the agreed timeline design, for the messages that actually reach a user row, drawn from the shared classifier.

  • J5's notices (group 4): one grey line on the left with an icon, a plain summary, the time and a chevron. Opening it shows the detail under a thin rule. Names come from the identity read, so no participant id shows. A line with nothing more to say has no chevron.
  • Crew notices: which ones appear is unchanged (Jackson, 2026-10-31). They now draw as lines, with a red or amber icon on a seat in trouble.
  • Prompts (group 5): an outlined pill on the left, using upstream's Automation row moved left with its fill removed.
  • "Raw A2A delivery" is gone. A notice J5 can't read falls back to upstream's row.
  • Find: a match in a folded detail or pill opens it, and a long summary wraps while find is open so its match can be seen. A match in a summary is already on screen, so it doesn't open the line.
Notice Line Opens to
Silence <name>'s turn ended without replying and its variants the facts or the error
Queued message removed <name> never read a queued message: it was removed before it ran the quoted opening, who edited it
Not delivered Message to <name> not delivered / may not have been delivered the reason, the ask, whether it's still open
Exchange dropped / withdrawn Exchange with <name> dropped / <name> withdrew its ask why
Crew seat in trouble <seat> couldn't start, red or amber icon the error, Open seat thread
Crew approved / declined Crew approved · n members / Crew <name> · roster declined by <who> roster / requested seats
Crew context Introduction from J5 / Roster changed from J5 what the model read
Handoff reminder Reminded to write its handoff the reminder
Prompt Label Title
Automation Automation task title
Playbook step Playbook step n of m step title
Native question Question from <title> the situation

This differs from #698 and the design:

  • Upstream's platform messages keep upstream's look. PR-watch updates, restart and provider continuations, delegated and background task completions, delegated-task questions and idle compaction all stay on upstream's rows. The design assumed they were user messages. On today's trunk the server makes them notification turn items (notificationTurnItem), and web draws /compact as a compaction row (MessagesTimeline.logic.ts), so they never reach this row. The live database agrees: 0 PR-watch and 0 restart user rows against 446 and 3 notification rows. Restyling them would be a new edit to upstream's work rows that Jackson never saw, so the Captain chose to follow upstream and is telling Jackson; he can reverse it on reading this.
  • Older rows and worktree continuations don't change. The 94 provider continuations from 2026-09-25 or earlier and the worktree continuation keep today's agent fold.
  • A silence shows the time, not an age. The notice carries no age and the message has no base time for one. AC9 is reworded.
  • Two rows beyond the design's table are lines too: the handoff reminder and Crew context (the "Introduction" card). Otherwise they would draw as the reader's own message or as an off-style card.
  • Not changed: the shared-conversation note keeps its own look.

A bug this fixes: trunk's queued-removed parser never matched the server's real Your message <id> to X, so those notices fell to the raw card. It now reads both forms.

Docs: besides the rewrites, this removes leftover merge conflict markers from the History section of crews.md, with every entry kept as written.

UI changes

Matched captures use the same isolated test home on trunk and head. Unchanged silence, declined roster and automation captures were rechecked on 51afeadb84; playbook captures were replaced for the full-width label fix. Native question, Exchange dropped, amber missing-report and fallback captures are from 51afeadb84. The base lacks folds for several of these rows, so its single before view is reused for folded/open after states.

Before After
Silence notice, folded Silence notice, folded, before Silence notice, folded, after
Silence notice, open Silence notice, open, before Silence notice, open, after
Declined roster, folded Declined roster, folded, before Declined roster, folded, after
Declined roster, open Declined roster, open, before Declined roster, open, after
Automation run, folded Automation run, folded, before Automation run, folded, after
Automation run, open Automation run, open, before Automation run, open, after
Playbook step, folded Playbook step, folded, before Playbook step, folded, after
Playbook step, open Playbook step, open, before Playbook step, open, after
Native question, folded Native question, folded, before Native question, folded, after
Native question, open Native question, open, before Native question, open, after
Exchange dropped, folded Exchange dropped, folded, before Exchange dropped, folded, after
Exchange dropped, open Exchange dropped, open, before Exchange dropped, open, after
Crew report missing, folded Crew report missing, folded, before Crew report missing, folded, after
Crew report missing, open Crew report missing, open, before Crew report missing, open, after
Unknown notice fallback Unknown notice fallback, before Unknown notice fallback, after
Native question with very long title, folded Native question with very long title, folded, before Native question with very long title, folded, after

Opening a playbook step, before:

playbook-expansion-before.mp4

Opening a playbook step, after:

thread-j5-a2a-bdfbb3dc26f227374b81748feacd67912c7847ffc9d77eb81622199e4a2369a0-dfff17a2-1652-4326-af45-f8b6a9c35cd8-mp4.mp4

Uncaptured: queued removed, not delivered, Exchange withdrawn, handoff reminder, red Crew failure. A very long native-question title truncates, by design.

Live testing

Verdict: partial pass; no defect remains demonstrated in the exercised rows. Latest isolated web pass: 51afeadb84; real agent turns used Claude Haiku 5.5. Base was exact trunk b85f2625d8, using the same preserved isolated home. Both test servers were stopped through setup's tracked process groups.

Passed live:

  • Declined roster, silence, automation and playbook folds still work; find opens hidden silence detail and hidden playbook prompt on latest head.
  • Native question from a real Peer Agent: folded/open; “Agent-provided title” absent from UI, Copy and Copy prompt link. Very long title ellipsis is intentional; the full thread title remains reachable.
  • Exchange dropped after stopping and archiving an asked peer: correct named summary and archive reason in open detail.
  • Amber Crew attention line from a persona with declared report output left unwritten through its reminder: folded/open, light/dark, and Open seat thread reaches the right seat. A clean finish remains hidden.
  • Opened Crew approved seat button reaches its seat; playbook Copy actions contain only step words.
  • Unknown template-v999 notice uses upstream's bubble on the left, with no Raw A2A delivery card.
  • Upstream restart divider, delegated completion cards and PR-watch registration retain upstream presentation; these notification items are outside group 4. No actual PR-watch update was generated.

Still not reached live; keep test-only coverage explicit:

  • Queued removed: ordinary and explicit queue-mode messages to a held Claude seat were steered, leaving no removable queue entry. No fabricated queue state.
  • Not delivered and Exchange withdrawn: not forced; clearing an ask closes sender-cleared without notifying its recipient.
  • Handoff reminder prompt and red failed-seat line: no failed run reached; a stopped run does not produce a Crew finish notice. The amber missing-report finish was reached as above.
  • Long-summary wrapping while find is active: no suitable long real notice. Summary matches already visible remain folded, following upstream's find behavior.

No mobile, Electron, second-device, relay/tunnel or production-volume claim. Full report: artifacts/test-reports/j5-698-tester/51afeadb84.md.

Upstream impact

Upstream-owned file FORK case What
apps/web/src/components/chat/TimelineUserMessageRow.tsx 7 Sends J5's prompts to AutomationMessageRow; that row takes J5's text, title, label and icon, and moves left without its fill

That's 5 hunks, one of them the import, against the design's "1–2 + class edit". J5's pills reuse AutomationMessageRow rather than copying it, which keeps its fold, find, copy, steer marker, status and Edit from here without exporting them and avoids an import cycle. FORK case 7 records why.

Product decision: moving the Automation row left and removing its fill is Jackson's design (2026-10-24, revised 2026-10-31), register D38, rewritten here to match what's built.

What mobile should follow

No file under apps/mobile changed, and its tests pass unedited. These are for the mobile orchestrator.

  1. Draw the new fields. Notices gain detail and participantIds; prompts gain label and preview; there are new kinds (not-delivered, exchange-dropped, exchange-withdrawn, handoff-nudge, playbook-step, native-question).
  2. Replace ids with names. Silence summaries still hold participant ids, which mobile shows as they are. Use nameJ5NoticeParticipants with the identity read; participantIdsForJ5UserMessage now returns those ids.
  3. Behaviour that already changes on mobile: a real queued-removed notice moves from the raw card to a silence line, and was rolled_back now reads was rolled back.
  4. Crew lines: crewNoticeLines and crewApprovalSummary are now in client-runtime, and a line's error moved from reason to detail.

The classifier no longer has the kinds restart-continuation, pr-watch, delegated-question and compaction. Mobile doesn't read them, and those messages behave there as before.

Checklist

  • One concern: the description has no "also"
  • Tests cover the changed behavior
  • UI changes: before/after screenshots above; several kinds have no capture, as listed
  • Live testing: the section above says what ran live and what did not
  • Upstream-owned files: each one is recorded in FORK.md (case text and file-table row) in this PR
  • Upstream product: the change has a human decision linked above and a register entry in docs/j5/product/upstream.md
  • Surfaces: entry points (timeline only), clients (web; mobile listed above, desktop wraps web), providers (no adapter change), contracts (none), reverse states (every line and pill folds back), connection modes (client-side only)
  • Docs: thread-a2a-rendering.md, crews.md and upstream.md rewritten

Built by Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

Platform notices are now one grey line that opens to its detail, and platform
prompts an outlined pill, both drawn from the shared classifier. The raw A2A
card is gone: a notice J5 can't read is upstream's row.

Closes #698

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
j5-code Ready Ready Preview Nov 3, 2026 2:49am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The change adds shared J5 notice and prompt classification, renders recognized notices as expandable timeline lines, and routes J5 prompts through the upstream automation row. Crew notices use the shared notice presentation. Unrecognized notices fall back to upstream rows.

Changes: J5 timeline presentation

Layer / File(s) Summary
Shared platform message classification
packages/client-runtime/src/j5/platformMessages.ts, packages/client-runtime/src/j5/userMessagePresentation.ts, packages/client-runtime/src/j5/participantIdentity.ts, packages/client-runtime/src/j5/*test.ts
Shared parsers classify delivery notices, handoff nudges, and prompt types. Notice data includes details and participant IDs. The presentation resolver uses these parsers for system messages.
Crew notice derivation and rendering
packages/client-runtime/src/j5/crewNotices.ts, apps/web/src/j5/crew/*
Client-runtime helpers derive Crew seat lines and approval or decline summaries. Web Crew notices use shared notice components, with optional details and thread links. Tests cover notice states and rendering.
Web notice-line rendering
apps/web/src/j5/a2a/J5NoticeLine.tsx, apps/web/src/j5/a2a/ThreadA2ARenderer.tsx, apps/web/src/j5/a2a/J5NoticeLine.browser.test.tsx, apps/web/src/j5/a2a/timelineRows.test.ts
The timeline renders recognized notices with summaries, optional details, participant labels, and actions. Tests cover expansion, find behavior, and fallback for unrecognized messages.
Platform prompt integration and documentation
apps/web/src/components/chat/TimelineUserMessageRow.tsx, apps/web/src/j5/a2a/ThreadA2ARenderer.tsx, apps/web/src/j5/a2a/ThreadA2ARenderer.test.tsx, docs/j5/product/features/*, docs/j5/product/upstream.md, FORK.md
J5 prompts use the upstream automation row with prompt-specific content and styling. Documentation describes the notice and prompt behavior, upstream-row fallback, and Crew pre-approval rules.

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant TimelineUserMessageRow
  participant renderThreadA2ADelivery
  participant J5NoticeLine
  TimelineUserMessageRow->>renderThreadA2ADelivery: pass timeline message
  renderThreadA2ADelivery->>J5NoticeLine: render recognized notice and optional detail
Loading

Possibly related issues

  • Jacksondr5/j5code#337 — This change updates web notice classification and upstream-row fallback for the notice paths described in the issue.
  • Jacksondr5/j5code#776 — This change updates the timeline presentation of Crew seat-finished notices and handoff details.
  • Jacksondr5/j5code#911 — This change updates how Crew run-finish notices appear in the timeline; the notification policy remains unchanged.

Possibly related PRs

  • Jacksondr5/j5code#715 — The queued-message parser handles the edit wording added by this PR.
  • Jacksondr5/j5code#671 — The not-delivered and queued-removal parsers expect notice wording described by this PR.
  • Jacksondr5/j5code#658 — The delivery parser handles the “may not have been delivered” wording added by this PR.

Suggested reviewers: bryantderosier

Merge Risk: Minimal · up to 51afe

The terminal notices reach the intended timeline classifier. No identified issue needs resolution before merging.

Pre-merge checks: Passed 3 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Linked Issues check Warning Issue #698 is the only active direct link. Its coding requirements are groups 4 and 5 on web, the removal of the Raw A2A delivery card, the fallback to upstream's row, and automated tests.

Met: The J…
Choose one path and record it on #698:
1. Implement group 4 and group 5 treatment for the unmet kinds: restart and provider continuations, PR-watch updates, delegated and background task completions, delegated-task questions, and idle compa…
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: adding J5 platform notices and prompts to the web timeline.
Out of Scope Changes check Passed Each changed area maps to #698 or supports it.
- Notice and prompt UI (J5NoticeLine.tsx, ThreadA2ARenderer.tsx, CrewNoticeRenderer.tsx, TimelineUserMessageRow.tsx, AutomationMessageRow): dir…
Description check Passed The description is complete and follows the repository template. It documents the problem, implementation, UI evidence, live-testing results and limitations, upstream impact, product decision, surface…
Full details: Out of Scope Changes check

Explanation

Each changed area maps to #698 or supports it.

  • Notice and prompt UI (J5NoticeLine.tsx, ThreadA2ARenderer.tsx, CrewNoticeRenderer.tsx, TimelineUserMessageRow.tsx, AutomationMessageRow): direct Group 4 and Group 5 work.
  • Classifier and parsers (platformMessages.ts, userMessagePresentation.ts, participantIdentity.ts): the shared classifier named in #698.
  • crewNotices.ts moved to client-runtime: supports the shared-classifier requirement and removes local duplicates.
  • Queued-removed parser fix: part of the Group 4 queued-message notice.
  • Find expansion for folded rows: part of the notice and prompt design.
  • crews.md conflict-marker cleanup: a documentation fix in a file the issue requires updating.
  • Docs, FORK.md, and upstream.md: required by the Done-when list.

The shared client-runtime change alters mobile wording and behavior, for example was rolled back and the queued-removed notice. The PR description discloses these effects, and they follow from the shared classifier. No change was found that is unrelated to #698. Mobile test results were not run.

Full details: Description check

Explanation

The description is complete and follows the repository template. It documents the problem, implementation, UI evidence, live-testing results and limitations, upstream impact, product decision, surface coverage, documentation updates, tests, and the work model. It also links issue #698 and identifies uncaptured cases.

Full details: Linked Issues check

Explanation

Issue #698 is the only active direct link. Its coding requirements are groups 4 and 5 on web, the removal of the Raw A2A delivery card, the fallback to upstream's row, and automated tests.

Met: The J5 notice kinds silence, not-delivered, exchange-dropped, exchange-withdrawn, and handoff-nudge render as notice lines. Crew gate, seat, and context notices render as lines. The playbook-step and native-question prompts render as pills. The Raw A2A delivery card is absent at head. Unreadable notices fall back to upstream's row. Browser and unit tests cover these kinds.

Unmet: #698 Group 4 names upstream's own platform messages: restart and provider continuations, PR-watch updates, and delegated and background task completions. Group 5 names delegated-task questions and idle compaction. At head, J5NoticeKind in packages/client-runtime/src/j5/userMessagePresentation.ts drops restart-continuation and pr-watch. J5PromptKind drops delegated-question and compaction. These kinds no longer receive group 4 or group 5 treatment. The PR description states that these messages keep upstream's rows, because the server writes them as notification turn items. The PR author gives this as a deliberate deviation. The issue text does not change, so the requirement stays unmet. This revises the prior PASS, which counted these kinds as covered.

Not verified: The userMessagePresentation.ts read was truncated at 16000 bytes. The removal of these kinds was confirmed only through the visible union types. Test results were not run.

Resolution

Choose one path and record it on #698:

  1. Implement group 4 and group 5 treatment for the unmet kinds: restart and provider continuations, PR-watch updates, delegated and background task completions, delegated-task questions, and idle compaction. Apply it to the upstream notification and compaction rows, with tests and FORK.md records for the changed upstream hunks.
  2. Obtain the issue owner's approval to narrow #698. Remove those kinds from the Done-when scope and the Group 4 and Group 5 lists. Record the narrower scope in the register (D38) and in thread-a2a-rendering.md. Then update the linked-issue scope so the PR matches it.
Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ast-grep (0.51.1)

ast-grep could not parse rule config: /ast-grep-rules/ast-grep-essentials/rules/html/security/malformed-erb-end-modifier-html.yml

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 8242e39 and 51afead.

Files selected for processing: 11
  • FORK.md
  • apps/web/src/components/chat/TimelineUserMessageRow.tsx
  • apps/web/src/j5/a2a/J5NoticeLine.browser.test.tsx
  • apps/web/src/j5/a2a/J5NoticeLine.tsx
  • apps/web/src/j5/a2a/ThreadA2ARenderer.tsx
  • apps/web/src/j5/a2a/timelineRows.test.ts
  • docs/j5/product/features/thread-a2a-rendering.md
  • docs/j5/product/upstream.md
  • packages/client-runtime/src/j5/platformMessages.ts
  • packages/client-runtime/src/j5/userMessagePresentation.test.ts
  • packages/client-runtime/src/j5/userMessagePresentation.ts
Files with no reviewable changes: 2
  • apps/web/src/j5/a2a/J5NoticeLine.browser.test.tsx
  • apps/web/src/j5/a2a/J5NoticeLine.tsx
Files skipped from review as they are similar to previous changes: 1
  • FORK.md

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). labels Nov 3, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Upstream's row offers copy on these messages, and long reports fold under
"Background task completed", so they stay copyable. D38 now describes what's
built, and crews.md points to the look and loses stray conflict markers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Upstream draws PR-watch updates, restarts, finished tasks, delegated questions
and idle compaction on its own notification and compaction rows, so they never
reach the user row. Group 4 is J5's notices, and group 5 is automation runs,
playbook steps and native questions. A test now takes each kept kind through
the timeline's own derivation.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@Jacksondr5 Jacksondr5 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combined review at 5e2aab3042 (Opus lead and Sol 6.1)

No blocking code findings. One visual fix to make, and one evidence gap to close or accept. Both reviewers read the source independently and agreed these findings.

Should fix

A folded pill cuts off its own label. The folded playbook capture reads "Playbook step 1 ..." and "Playbook step 2 o..." with room to spare, and opened it reads "Playbook step 1 of 2". The likely cause is that FoldedMessageHeader gives the label max-w-1/2 shrink-0 truncate, and a pill sized to its content has a short half when the title is short. "Automation" fits, so upstream never hits this.

It hides the step count, which is what the label is for. By source reading, "Question from <title>" would lose the sender's name the same way, though no capture shows that.

It's purely visual, so new captures are the proof and no test is needed. The smallest fix we can see stays in the existing case 7 hunk, for example (expanded || j5Prompt) && "w-full" on the pill. Any fix that adds no new upstream hunk is fine. Replace the affected playbook captures afterwards.

Evidence gap

The captures cover four kinds: silence, declined roster, automation and playbook step, each folded and open. None of the three notices that motivated #698 (not delivered, Exchange dropped, ask withdrawn) has an image, and neither does the fallback for an unrecognised notice. The PR says this honestly, and the brief allows tests-only for a kind that can't be reached, so this isn't a code finding.

Two of these look cheap to capture:

  • Exchange dropped: have an agent ask a peer, then archive the peer. LifecycleService sends the asker the notice.
  • Unrecognised notice: the live-test home calls runDevDeliverySeed, which seeds a template-v999 notice.

We'd include both in the extra tester pass. Whatever stays uncaptured is Jackson's call when reviewing the UI.

Checked and fine

  • Design and scope. Groups 4 and 5 match the narrowed scope: J5's notices are lines, and Automation, playbook step and native question are pills. The PR body flags where this differs from #698 and the design. Leaving upstream's rows alone narrows Jackson's 2026-10-24 decision, so that's for Jackson to confirm.
  • Upstream's rows. A notification turn item draws as a work row (session-logic.ts:608), including delegated completions and delegated-task questions. A /compact message with a runId draws as a compaction row. Neither reaches UserMessageRow, and timelineRows.test.ts covers both.
  • #750's rule. isHiddenCrewNotice and withoutHiddenCrewNotices have only import changes. crewNoticeLines keeps its seat and tone logic and only splits reason from detail, so the same notices stay hidden.
  • Nothing raw shows. Participant ids in notices go through the identity read, and an unknown one reads "Unnamed participant". The playbook step's tagged block is stripped from the body, copy and prompt link. Crew context still opens to the text the model read, as designed.
  • Fallback. A notice the classifier can't read returns null and draws as upstream's row, and "Raw A2A delivery" is gone from web.
  • Real data. An earlier version of the classifier ran read-only over all 9,807 user-role messages in a live database with no raw fallback. That shows what the classifier reads, not what gets drawn, and it wasn't re-run after the rework. timelineRows.test.ts covers drawing, from stored turn item through the timeline derivation.
  • Find. A hidden detail stays mounted while find is active and opens on a match. The tester confirmed this live on a silence detail and a playbook prompt.
  • Animation. No continuously repainting animation; the only transition is the chevron rotating.
  • Mobile. No file under apps/mobile changed, timelinePresentation.test.ts passes unedited, and tsc on apps/mobile reports no errors. The PR lists what mobile should follow.
  • Upstream edits. 5 hunks in TimelineUserMessageRow.tsx, one of them the import, all recorded in FORK case 7. That's over the design's estimate, and reusing AutomationMessageRow is a good reason: it keeps fold, find, copy, the steer marker, status and Edit from here without exports or an import cycle.
  • Captures after the rework. The commits since 82f0c24079 only remove upstreamRow and unreachable readers, so the captures still hold for how those rows draw. The label fix will change the playbook ones.
  • Docs. thread-a2a-rendering.md and D38 are rewritten to what's built, crews.md points to the rendering doc, and the leftover conflict markers on trunk are gone.

Tests run on this head: 117 passed across the six focused files. CI was still pending when this was written.

Reviewed by Claude Opus 5.5 and GPT Sol 6.1.

@coderabbitai coderabbitai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix comments: Fix CodeRabbit comments on this PR

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@Jacksondr5 Jacksondr5 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up at 51afeadb84 (Opus lead)

No open code findings. CI is green. This is my own check of the changes since the combined review and of seven new captures. Sol 6.1 reviewed the code up to 5e2aab3042, not these captures.

  • Label fix: confirmed. Folded pills now read "Playbook step 1 of 2" in full. A very long "Question from …" title still truncates inside the pill, which is reasonable, and the full title stays reachable.
  • CodeRabbit fixes: both fine. J5NoticeLine.browser.test.tsx uses the default router, and an unreadable platform message now sits on the left. The template-v999 capture shows its text visibly in upstream's bubble.
  • New captures: native question, Exchange dropped (named, no ids) and the amber "report missing" line with Open seat thread all match the design.

For Jackson's UI review, none of these block merge:

  1. An open native question shows raw ids. The body reads "Placed agent (threadId thread:…, requestId runtime-request:…)", which fills several lines. The design asks for "the thread and request to read", and these aren't participant ids, so it meets AC12 as written, but it reads badly. Tidying it would be a small change in nativeQuestionPrompt if wanted.
  2. Five kinds are tests-only: queued removed, not delivered, Exchange withdrawn, handoff reminder and the red Crew line. That includes two of the three notices that motivated #698. Withdrawn is sent only to a receiver on a peer server (SendService), so it needs a peered setup, which is why a local j5_clear_own_ask didn't produce one.
  3. Scope is narrower than the design. Upstream's platform messages stay on upstream's rows, as the PR body says.

Reviewed by Claude Opus 5.5.

@Jacksondr5
Jacksondr5 merged commit 75ca81e into j5/main Nov 3, 2026
36 checks passed
@Jacksondr5
Jacksondr5 deleted the j5/698-timeline-notices branch November 3, 2026 03:41
Jacksondr5 added a commit that referenced this pull request Nov 9, 2026
…s seat lines (#981)

* fix(mobile): platform notices read as named lines, and Crew notices as seat lines

Mobile follows #916's classifier (#918, #836 piece 2): each J5 notice is one grey
line on the left that opens to its detail, with participants named; a Crew notice
shows its approval or decline and one line per seat that needs the person, each
opening the seat's thread; playbook steps and native questions take upstream's
Automation row under J5's heading. Crew notices with nothing for the person are
dropped after the feed is derived, through the filter web now shares.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(j5): FORK's ThreadFeed.tsx row lists case 104

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(mobile): the Automation row's label no longer truncates beside its summary

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch was successfully deployed

1 active deployment
Preview — 51afeadb Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A2A timeline: notices and platform prompts on web (design groups 4 and 5)

1 participant