Skip to content

fix(j5): each rig test server is named after its host and worktree - #977

Merged
Jacksondr5 merged 1 commit into
j5/mainfrom
j5code/rig-server-name
Nov 9, 2026
Merged

Jacksondr5 merged 1 commit into
j5/mainfrom
j5code/rig-server-name

Conversation

@Jacksondr5

Copy link
Copy Markdown
Owner

Problem

Every rig test server named itself after the host, so at Checkpoint 3 Jackson's app listed three servers called "openclaw" and he couldn't tell which one was stale (#958, item 1). The rig strips any inherited J5CODE_SERVER_NAME, so the live server's name doesn't leak in, and then set none of its own.

What changed

liveTestEnvironment in scripts/j5/setup-agent-live-test.ts now sets J5CODE_SERVER_NAME to <hostname> test (<worktree folder>), for example openclaw test (j5code-mobile-test-rig). This is the setting the server already reads (register divergence D32), so there's no new mechanism. The name comes from the machine and the checkout, with nothing personal configured. Every rig server gets it: web, mobile, phone and upgrade. Peer mode's explicit "Local" and "Remote" names still win, because startServer applies its own environment after this one.

Testing

  • The liveTestEnvironment test now expects the name.
  • Runtime, on openclaw: I started a plain test server from this branch (no device). /.well-known/t3/environment reported "label":"openclaw test (j5code-mobile-test-rig)". Then I stopped it.
  • No device commands. The name appears wherever the app lists a server, and the server is what sets it, so a device adds nothing.

Part of #958 (item 3). #975 covers the "loading" state.

Checklist

  • One concern: the description has no "also"
  • Tests cover the changed behavior: the rig environment carries the name
  • UI changes: none in code. The app shows the server's name, now distinct per test server.
  • Live testing: the runtime check above
  • Upstream-owned files: none
  • Upstream product: no change. It uses J5's existing D32 setting.
  • Surfaces: every server the rig starts
  • Docs: none needed

Built by Claude Opus 5.5 in Claude Code (J5 Code crew seat).

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
j5-code Ready Ready Preview Nov 9, 2026 4:08am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 2 billable files and costs up to $0.50.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 8 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 5 included reviews currently available. Your 29 included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 067d732 and fbbd2b0.

Files selected for processing: 2

  • scripts/j5/setup-agent-live-test.test.ts
  • scripts/j5/setup-agent-live-test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 effective changed lines (test files excluded in mixed PRs). labels Nov 9, 2026
@Jacksondr5
Jacksondr5 merged commit 3abc2ea into j5/main Nov 9, 2026
31 checks passed
@Jacksondr5
Jacksondr5 deleted the j5code/rig-server-name branch November 9, 2026 04:40

This branch was successfully deployed

1 active deployment
Preview — fbbd2b09 Deployed Nov 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant