Repository navigation
fix(mobile): the persona form's model menu, Instructions capitalization and Save above the keyboard - #978
Conversation
…ove the keyboard without dead space Instructions turned off auto-capitalization. The form stacked a KeyboardAvoidingView's padding on top of its bottom inset; it now uses upstream's automaticallyAdjustKeyboardInsets, as GitCommitSheet does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The submenu's native transition looked broken at Checkpoint 3. Inline sections keep the provider grouping in one level on iOS; Android keeps its drill-in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
This review includes 4 billable files and costs up to $1.00.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 28 minutes for your next included review. View limit details
|
Jacksondr5
left a comment
There was a problem hiding this comment.
Combined panel review (reviewer-opus + reviewer-sol) at b3b12d0
Verdict: no findings, and the panel approves the source. Still pending: captures and device checks on Android and iOS, and J5 CI.
- Model menu.
displayInline: truemaps to UIMenu's.displayInline, which the installed menu bridge supports, so iOS shows each provider as a section and the submenu transition goes away. Android'sAndroidAnchoredMenufollows onlysubactionsand ignores the field, so Android keeps its drill-in menu unchanged. An inline provider with no models has no items to choose. - Instructions. Create and Edit both now use
autoCapitalize="sentences". - Keyboard.
- On Android, the old
KeyboardAvoidingViewhadbehaviorundefined, so it was a plainflex: 1view. Removing it leaves theflex: 1scroll view with the same insets and content sizing, so nothing changes on Android. - On iOS, the frame now matches upstream's
GitCommitSheet.tsx:96–104:contentInsetAdjustmentBehavior="automatic"plusautomaticallyAdjustKeyboardInsetsand the same bottom padding. React Native works out the keyboard overlap once, then sets bottom to the larger of that overlap and the explicitcontentInset.bottom(RCTScrollViewComponentView.mm,_keyboardWillChangeFrame). With noKeyboardAvoidingViewpadding left, nothing adds the keyboard twice. - Whatever gap remains below Save is the content's own bottom padding plus whatever bottom inset the safe area adds, the same as upstream's commit sheet. Whether that's small enough for #961's "dead space" is the device check.
- On Android, the old
- Reach.
SettingsFormScreenalso frames the Playbook conversation page (#906), so it gets the keyboard change too. - PR body (minor). Four J5 files change, not three: the two Instructions fields, the model menu and the form frame.
Reviewer-run checks
reactCompilerCoverage.test.ts: 1081 passed (reviewer-opus); 4 targeted compiler checks (reviewer-sol)- mobile
vp run typecheck: exit 0 for both reviewers, after refreshing a stale worktree install - lint: clean on the changed files;
git diff --check: clean
For the device pass:
- On iOS, the model menu shows providers as sections, including a long provider list.
- On Android, the drill-in menu still works.
- With the keyboard up, Save sits just above it without a large gap, on both persona forms and the Playbook page.
- Instructions capitalizes after a full stop and on a new line.
Reviewed by Claude Opus 5.5 (reviewer-opus) and Sol 6.1 (reviewer-sol) in J5 Code.
iOS's automatic content inset already covers the home indicator area under the keyboard, so the form's own bottom padding doubled it, about 80pt in the tester's captures. With the keyboard up, the padding is dropped on iOS and kept small on Android. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Jacksondr5
left a comment
There was a problem hiding this comment.
Panel delta check (reviewer-opus + reviewer-sol) at fdf588b
Verdict: no findings, and the panel's source approval stands. The exact gap is for the iOS device run to confirm.
- The inference holds. React Native puts the keyboard overlap, which includes the home-indicator area, into the scroll view's
contentInset. WithcontentInsetAdjustmentBehavior="automatic", UIKit then adds the bottom safe area on top. The old content padding (Math.max(insets.bottom, 18) + 18, about 52 pt) stacked on both, so about 34 + 52 ≈ 86 pt matches the tester's 80–85 pt. - Expectation for the re-test. With the padding at 0 while the keyboard is up, the gap under Save should drop to about 34 pt (the safe area UIKit still adds), not to zero. That's reasonable breathing room, but it's what the tester should measure.
- Android changes too. While the keyboard is open, the padding is now 18 instead of
Math.max(insets.bottom, 18) + 18, so the tester should cover Android as well. useKeyboardState(react-native-keyboard-controller, as upstream uses) updates on show and hide, and handles a keyboard that's already open when the page mounts. The closed-keyboard padding is unchanged, and the Playbook conversation page shares the frame.
Reviewer-run: reactCompilerCoverage.test.ts passes (1081), mobile vp run typecheck exits 0, and lint and git diff --check are clean.
Reviewed by Claude Opus 5.5 (reviewer-opus) and Sol 6.1 (reviewer-sol) in J5 Code.
…eyboard The Android tester found Save hidden behind the keyboard at the end of the form, on base and head alike: Android never avoided the keyboard there. Android now uses keyboard-controller's KeyboardAwareScrollView, as the Inbox does; iOS keeps upstream's scroll view. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Jacksondr5
left a comment
There was a problem hiding this comment.
Panel delta check (reviewer-opus + reviewer-sol) at 4fe087b
Verdict: no findings, and the panel's source approval stands. Still pending: the device runs and captures.
- iOS is unchanged. It keeps
ScreenScrollView, which registers with the header, plusautomaticallyAdjustKeyboardInsetsand the same padding: 0 with the keyboard up, the usual padding with it down. Expect about 34 pt under Save as before. - Android now uses react-native-keyboard-controller's
KeyboardAwareScrollViewwithbottomOffset={80}, the same pattern asInboxScreen.tsx:166–176. It keeps the 720-wide content cap and the usual bottom padding. It adds scrollable space for the keyboard, so Save can scroll clear of Gboard.bottomOffsetis the clearance above the focused input, not a promised 80 pt gap under Save. The AndroiduseKeyboardStatepadding branch is gone, so nothing pads twice. - Styling on Android.
classNameandcontentContainerClassNamego throughKeyboardAwareScrollViewto the underlying scroll view, the same as on the Inbox screen. Since the earlierSafeAreaViewclass-dropping bug, it's worth confirming on device that the form's gap and padding render on Android. - When this rebases over #990, keep #990's removal of the Playbook conversation route.
For the device pass: on Android, with Gboard open on Create and Edit, Save is reachable and tappable at the end of the form, and the layout resets when the keyboard hides. On iOS, the gap under Save is about 34 pt.
Reviewer-run: reactCompilerCoverage.test.ts passes (1081), mobile vp run typecheck exits 0, and lint and git diff --check are clean.
Reviewed by Claude Opus 5.5 (reviewer-opus) and Sol 6.1 (reviewer-sol) in J5 Code.
Problem
At Checkpoint 3, Jackson found three things on his iPhone in the mobile persona form. Closes #961.
What changed
displayInline), so there's no submenu and no transition. Android keeps its drill-in, which nobody flagged.ThreadSettingsPickerScreen). Moving the persona form to that screen would need an adapter from persona routes to upstream's model options. The Captain will show Jackson both at Checkpoint 4.autoCapitalizeis nowsentencesin both Create and Edit. The ID field stays unchanged.KeyboardAvoidingView, whose padding stacked on the bottom inset. It now uses upstream'sautomaticallyAdjustKeyboardInsetson iOS, asGitCommitSheetdoes. While the keyboard is up, the form's bottom padding is dropped on iOS. On Android, where Save stayed hidden behind the keyboard on base and head alike, the form now uses keyboard-controller'sKeyboardAwareScrollView, as the Inbox does, so it scrolls clear of the keyboard. This also covers the Playbook conversation page, which uses the same frame.UI changes
iOS Simulator, iOS 26.5, same test home on each side: before on
j5/main(067d732e1a), after onb3b12d01e4. Android captures are pending from the Android tester.The keyboard captures above were taken before
fdf588ba4d. Onfdf588ba4d, with the same fixture:Android 16, same test home: before on
091dfb9f3d(persona code identical toj5/main), after on4fe087b02a.After only:
Create's model menu on
j5/main:ios-model-menu-before.mp4
Create's model menu with this PR, scrolling to Codex and choosing Luna:
ios-model-menu-after.mp4
Edit's model menu on
j5/main:ios-edit-model-menu-before.mp4
Edit's model menu with this PR:
ios-edit-model-menu-after.mp4
Live testing
iOS: PASS at
b3b12d01e4(crew tester, reporttest-reports/pr-978/ios-b3b12d01e4.md).The gap under Save: the tester measured about 80–85pt between the button and the keyboard on base and on that head alike, so
b3b12d01e4didn't reduce it. From code, the cause is double counting. iOS's automatic content inset already covers the home-indicator area under the keyboard, and the form's bottom padding (that area plus 18) added it again.fdf588ba4ddrops the padding while the keyboard is up on iOS and keeps 18 on Android. Re-measured on iOS atfdf588ba4d(reporttest-reports/pr-978/ios-fdf588ba4d.md): the gap went from about 87pt to 35pt. The 35pt left is the home-indicator inset UIKit adds; that last part is inferred.Android: PASS at
4fe087b02a(crew tester, reporttest-reports/pr-978/4fe087b02a.md).fdf588ba4d, and4fe087b02afixes it.Not exercised yet: dark mode, tablets and a physical iPhone.
Checklist
Built by Claude Opus 5.5 in Claude Code (J5 Code crew seat builder-composer).
🤖 Generated with Claude Code