Prefactor: the Pass lock and its skip line name any Pass #536

Parent

#427

What to build

Some code is written for exactly two kinds of Pass, the Architect run and the Pickup run:

• the per-repository lock that lets only one Pass run on a repository at a time;
• that lock's skip reason;
• the Activity log's per-kind skip lines;
• the words a Pass hands to the run it dispatches;
• the help text and module docs that list the kinds of Pass.

Rewrite them for any kind of Pass, so that the Security run (#427) can join as a third without each place being touched again. Behaviour stays the same, apart from the skip reason's wording.

Acceptance criteria

• An Architect run or a Pickup run started while another Pass on the same repository is running is skipped with the reason "another Pass is already running on /". That reason replaces "an Architect run or a Pickup run is already running on …", both in what it prints and in its Activity log line.
• The Activity log still writes a skipped Pass's line only when its reason differs from the last one recorded for its kind.
• The words a Pass takes for the run it dispatches are defined once, for every kind of Pass.
• Help text and module docs that list the kinds of Pass say "a Pass" where they mean any of them.
• The existing Architect run and Pickup run tests pass, with the reworded line.