Repository navigation
Allow Security runs to fix one reproduced finding - #578
Merged
Merged
Conversation
Preserve both branches' Security-run regression tests, including fix dispatch safeguards and safeguard refusal and Model logging coverage.
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security runs can fix one reproduced finding when the command or User config allows it, and finish with the dispatched Run's outcome.
Closes #543
Evidence
cargo test --test security_run fixing_selects_the_most_severe_record_then_dispatches_one_ticket_before_auditing -- --exactfailed:unexpected argument after secure: security-fix.After: passes, selecting the first critical finding and dispatching exactly one Ticket before any audit.
After: the Ticket title is checked for copied private text; a reproduced finding still waits without fixing permission until its Ticket closes.
After: all four behavioral regressions are retained and pass. The original short-statement test also passes after allowing ordinary identifiers.
cargo testpasses (1,577 passed, one ignored);cargo fmt --checkandcargo clippy --all-targets -- -D warningspass.Merge Danger
Door: two-way
Reverting restores report-only behavior. Published Tickets and private record links remain on GitHub.
Blast Radius: factory
Adds shared command/config words and carries the resolved choice into dispatched and child Runs. Existing Runs default to fixing disabled.
Unaddressed findings
Standards
None. Both Standards findings are addressed: the private fix link survives later reproduction, and Severity parsing and ordering share the domain type.
Spec
None. All three Spec findings are addressed: short private statements are rejected, current Day-shift severity decides priority, and ordinary bare identifiers do not block valid fix prose.
Review coverage: both axes left
src/setup.rsunread. Its sole change addsfix = falseto an existing complete-config test fixture; the focused existing Setup test passed. Every other changed file appears in both final files-read lists.Built with codex · gpt-6.1-sol · xhigh