Repository navigation
Ask about Security fixing during Setup - #580
Merged
Merged
Conversation
This was referenced Oct 8, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Setup now asks whether Security runs may fix reproduced findings, off by default. Rerunning Setup uses the saved answer.
Closes #548
Evidence
cargo test --test setup setup_asks_once_about_security_fixing_with_off_as_the_default_and_writes_yes -- --exactfailed: the terminal never showed the fixing question.After: the same regression passes, including writing
fix = trueand a blank, commented Harness setting.cargo check --all-targets,cargo fmt --check,cargo clippy --all-targets -- -D warnings; fullcargo test(1592 passed, 1 ignored). All passed.Test seams
thirdshift setupcommand on a terminal or without one, observing its questions and written User config.Review
thirdshift-code-reviewagainstissue-427, pinned at1bff3a03089b81435fc456eb2a2f8089e394bde6: Standards 0 findings; Spec 0 findings. Each axis read all eight changed files. Changed files left unread: none.Unaddressed findings
Standards
None.
Spec
None.
Merge Danger
Door: two-way
Blast Radius: Setup
Changes Setup's questions and config writing; reverting restores the previous interaction.
Built with codex · gpt-6.1-sol · xhigh