Repository navigation
fix(protocols): range-check option-list codes in MH, IPv4, TCP, DCCP, SCTP and PCAP-NG makers #2693
Description
Left out of #2692, which settles registry codes in the main make() fields. Option-list codes are still handled inconsistently across families:
- Range-checked: HOPOPT/IPv6-Opts option types, HIP parameter codes, TLS extension types and HTTP/2 settings.
- Not range-checked, so the code wraps: MH, IPv4, TCP, DCCP, SCTP and PCAP-NG. For example, MH writes option code 300 as
0x2c.
Under #2617, a code that does not fit its field raises ProtocolError. Route these through the #2692 resolver.
Also from that work: MH _make_msg_be's status is typed StatusCode, but its schema holds BindingError.
blocked until #2692 merges, since it edits the same makers.
Activity
JarryShaw commentedon Nov 2, 2026
Folded into #2692's fix round: its review asked for option-list codes to be range-checked at every tuple-list option loop, as HOPOPT does. #2692 will close this issue. It stays
blockeduntil then.refactor(protocols)!: make() takes an enum member or an int, with no …
JarryShaw commentedon Nov 3, 2026
This folds into #2692, whose fix round now range-checks option-list codes in every family. #2692 closes it.
refactor(protocols)!: make() takes an enum member or an int, with no …