Repository navigation
fix(internet): an MH CGA parameter with a raw extension in its data model, or no public_key_test, fails to build #2725
Description
Found while fixing #2723. Both reproduce on main at 596dcfaf8; neither involves an empty item.
- A raw CGA extension inside a data model fails. A
CGAParameterdata model carrying any non-empty raw extension, even a whole valid one, raisesAttributeErrorin_read_cga_extensions. The same extension given through a schema builds fine. The likely cause is that_passes_rawdoes not look inside a data model, so the made header is never re-parsed andread()meets the raw octets. This is not yet confirmed. - A CGA parameter schema built without
public_key_testfails on build withKeyError: 'public_key_test'.hasattrreports the field as present, so the maker never sets it.
Whatever parses must also build, and a caller value that cannot build must raise ProtocolError.
Activity
JarryShaw commentedon Nov 3, 2026
Filed and accepted; nothing has started yet. The host is loaded, so a worker goes on this at the next sweep that has headroom. It also touches
mh.py, which #2723 changes, so it should start after #2723 is in.pending.JarryShaw commentedon Nov 3, 2026
Now
blockeduntil #2723 is in, since both edit the MH makers inmh.py. The host has headroom again, so this starts as soon as #2723 lands.JarryShaw commentedon Nov 3, 2026
Unblocked: #2723 merged as
468f9c219. A worker is on this now, based on that sha.wip.JarryShaw commentedon Nov 3, 2026
The PR is #2732.
fix(internet): build an MH CGA parameter from its data model or a sch…