Repository navigation
refactor(protocols): reorder the remaining class members to the member-order convention - #2613
Merged
Merged
Conversation
…r-order convention (#2490) Move members only; each member's text is unchanged. - OSPF: _read_encrypt_auth directly before _make_encrypt_auth. - IGMPv3: _make_group_record after _make_data, under Utilities. - IGMPv3, Query and Report schemas: the TYPE_CHECKING __init__ after get_payload or post_process. - IPv4, TCP: each options maker directly after its reader. - IPX: _read_ipx_address before _make_ipx_address. - IP_Pseudo: _is_ipv6 first among the helpers. - SCTP: _decode_next_layer after the chunk reader and maker. - Empty the member-order guard's KNOWN_EXCEPTIONS of its ten entries.
JarryShaw
added
refactor
Owner
Author
|
GOOD TO GO at |
JarryShaw
removed
the
review: good-to-go
JarryShaw
added a commit
that referenced
this pull request
Nov 2, 2026
…s latest wave into 1.6.0 (#2449) - Added: every whole HTTP/2 frame in a TCP segment is a further HTTPv2 layer, the previous frame's payload, as with TLS (#2609). - Folded into unreleased entries: SSLv3 lives in pcapkit.protocols.application.sslv3 (#2602), and a reassembled DTLS Datagram's packet holds the deferred handshake decode (#2605). tls.SSLv3 is in no release tag, so the entry records no move. - Changed: the remaining xdist jobs at -n logical (#2606) join the CI entry, and the member-order entry cites the last reorder (#2613). - No entry for the test-only #2611 and #2612, or for #2610's private registry sentinel, which changes no behaviour. - CHANGELOG.md regenerated; util/changelog_md.py --check passes.
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
refactor— changes neither behaviour nor performanceDescription of your pull request and other information
The last classes the member-order guard had excused are now reordered to the convention, and the guard's
KNOWN_EXCEPTIONStable is empty. They are OSPF, IGMPv3 with itsIGMPv3/Query/Reportschemas, IPv4, IPX, IP_Pseudo, SCTP and TCP. Only the out-of-order members move.The reorder is pure. For every changed module, against the merge base, these are identical: each class's member
ast.dumpset, the module-level nodes, and the multiset of source lines. I re-ran that check independently. With thepcapkit/diff reverted, the guard fails on exactly these classes.Tests: the touched protocols' modules pass, and so do the
protocols/transportandprotocols/applicationlegs. The oneprotocols/interneterror istest_mh_timestamp_info_1886_unit, a local dictdumper/plistlib issue that fails identically onmain.Still to do under #2490, and not checked by the guard yet: rule c (option readers in their registry's declaration order), subgroup d (helpers that
read/makedo not reach go last), and registry-map entry order.Part of #2490