Repository navigation
fix(util): match the PR template's changelog box in issue_pr_kinds.body - #2788
Conversation
JarryShaw
added
chore
|
GOOD TO GO at
One thing for you, not blocking: the suffix the fix now applies reads "N/A — centralised in #657". #657 is the 1.5.0 changelog PR, and later releases centralise in their own PR. A version-neutral "N/A — centralised" may read better, so say if you want it changed here. CI: the one failed check, Project tests ( |
JarryShaw
added
review: good-to-go
|
Coverage: 94.46% (unit tier, Python 3.15,
Per-file detail: the |
#2483 reworded the template's changelog box, so the `Added a` pattern matched nothing and the refresh pull request's box never got its N/A suffix. Find the box by its link instead; a new test feeds the real template through body() and fails without the fix.
f140b48 to
61bb1e8
Compare
|
Rebased onto |
JarryShaw
removed
the
review: good-to-go
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
fix— corrects a defectDescription of your pull request and other information
util/issue_pr_kinds.bodyis meant to mark the PR template's changelog box "N/A — centralised". Its regex still looked for the box's old wording ("Added a [changelog entry]"), which #2483 reworded. As a result it matched nothing and the suffix was never applied.The regex now finds the box by its
[changelog entry]link, so rewording the text around it cannot break it again. A new test runs the real template throughbody()and checks that the suffix appears exactly once. It fails onmainand passes with the fix.The #2786 sweep found this. No issue tracks it.