Repository navigation
fix(contract): emit audit events from admin and configuration setters (#1635) - #1694
Merged
Junirezz merged 3 commits intoOct 19, 2026
Conversation
|
@zakarimaureen1-blip Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Description
What changed
set_per_user_cap,set_dao_threshold,set_emergency_approvers,set_emergency_dispute_window,configure_korean_strategy,set_relayer,set_gasless_relayer) to report previous and updated values.invest,divest, and strategy whitelist modification paths.vault/src/event_tests.rsasserting event emissions for each configuration setter.Why
Security-critical state transitions and asset allocations were occurring silently on-chain without event emissions. This prevented indexers, security tools, and auditors from tracking parameter modifications and protocol balance shifts.
How tested
cargo test -p vaultto confirm all contract tests and event assertions pass.event_tests.rsfor each newly emitted audit event.Closes
Closes #1635