Skip to content

fix(contract): emit audit events from admin and configuration setters (#1635) - #1694

Merged
Junirezz merged 3 commits into
Junirezz:mainfrom
zakarimaureen1-blip:feature/issue-1635-emit-events-admin-config-setters
Oct 19, 2026
Merged

Junirezz merged 3 commits into
Junirezz:mainfrom
zakarimaureen1-blip:feature/issue-1635-emit-events-admin-config-setters

Conversation

@zakarimaureen1-blip

Copy link
Copy Markdown
Contributor

Title

Description

What changed

  • Added contract event emissions for admin/configuration setters (set_per_user_cap, set_dao_threshold, set_emergency_approvers, set_emergency_dispute_window, configure_korean_strategy, set_relayer, set_gasless_relayer) to report previous and updated values.
  • Integrated audit event emissions into invest, divest, and strategy whitelist modification paths.
  • Documented event schemas across audit definitions.
  • Added comprehensive unit tests in vault/src/event_tests.rs asserting event emissions for each configuration setter.

Why

Security-critical state transitions and asset allocations were occurring silently on-chain without event emissions. This prevented indexers, security tools, and auditors from tracking parameter modifications and protocol balance shifts.

How tested

  • Executed cargo test -p vault to confirm all contract tests and event assertions pass.
  • Verified test coverage in event_tests.rs for each newly emitted audit event.

Closes

Closes #1635

@drips-wave

drips-wave Bot commented Oct 19, 2026

Copy link
Copy Markdown

@zakarimaureen1-blip Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Junirezz
Junirezz merged commit c9eaf0f into Junirezz:main Oct 19, 2026
9 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[contract] Emit events from admin and configuration setters

2 participants