Repository navigation
fix(macos): include owned popovers in window references - #4942
Merged
Merged
Conversation
tyler-dane
marked this pull request as ready for review
October 30, 2026 00:46
tyler-dane
added
the
agent-automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4941
Independent native window-reference captures now include visible app-owned popovers. Each selected window is captured separately by the window server and composited with source-over alpha at relative window coordinates before cache-display changes. Canonical exports, titlebar captures, and product styling are unchanged.
Validation: normal native full suite 40967316015 PASS. Complete capture 40967333143 PASS; both date/time references inspected with full window, visible popovers, clean corners, and no clipping. Actual native and web strict logs from 40977549550 both report VERDICT: PASS and Checks skipped: (none). First strict attempt had a diagnosed palette Escape event failure outside the capture path; the unchanged-head retry passed. Lint, Swift contracts, and desktop export checks pass.