Repository navigation
Conversation
…appid yubikey_authenticate took the WebAuthn client origin only from the appid extension. keeperapp omits appid when its host is local (localhost, as on a default Self-Managed Keeper install), so Commander signed an empty origin and 2fa_validate rejected the assertion with two_factor_code_invalid. Use https://<rpId> instead, as the biometric client already does. The legacy U2F retry still uses appid as before.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security-key login from Commander fails with
two_factor_code_invalidagainst a Keeper server onlocalhost, which is how a default Self-Managed Keeper install runs.yubikey_authenticatetakes the client origin only from theappidextension. keeperapp leavesappidout when its hostname starts withlocal(WebAuthnUtil.createRelyingParties), so Commander signs"origin":""and the server rejects the assertion. The web vault sendshttps://localhoston the same server and passes.With no
appid, the origin is nowhttps://<rpId>, the same thing the biometric client already does. Whenappidis present nothing changes, and the legacy U2F retry still usesappidfor its RP ID.I checked with fido2 2.2.1 that the collector now produces
https://localhostfor that case and still usesappidwhen one is sent. I haven't tested it with a hardware key against SMK yet.