Repository navigation
fix(rest_api): register custom server public key with the KSM SDK - #2447
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KEEPER_SERVER_PUBLIC_KEY was only loaded into Commander's own key table. The embedded KSM SDK keeps a separate one, so
slack-app-setup, service-mode docker setup andksm app client addfailed against SMK at the firstsm/v1/get_secret. The server asked for key_id 7 (401), the SDK encrypted with Keeper's hard-coded key 7, and SMK returned 400encrypted transmission key is invalid.This change writes the same key into
keeper_secrets_manager_core.keeper_globals.keeper_public_keys, whichcore.pyreads directly. I checked locally that with the env vars set the SDK's key 7 becomes the SMK key and transmission keys are built with it, and that without them the table is unchanged. I haven't yet re-runslack-app-setupend to end against SMK.