Anthony Calabrese Dev Team application - #541
Conversation
adds a standalone, additive route at /anthony_calabrese with an animated intro curtain, gear/vine/conveyor decorations, and links to resume/linkedin/github/portfolio. scoped entirely to its own route (page.tsx, page.module.css, local font, public assets) with no changes to shared blade files (layout, globals.css, root page). Co-authored-by: Claude <claude@anthropic.com>
📝 WalkthroughWalkthroughAdds a new Next.js page for Anthony Calabrese. The page includes metadata, a local font, a curtain overlay, the KHIX logo, animated factory, piping, gear, and vine backgrounds, a title banner, and four external links. CSS modules define the page layout, opacity transitions, background movement, and gear rotations. Merge Risk: 🟡 Moderate · up to The new application page may leave profile links inaccessible on some viewport sizes or behind decorative layers, while its animations and image labels create accessibility problems. It also contains CSS naming that can fail lint checks, so the page is not ready to merge unchanged. 🚥 Pre-merge checks | ✅ 6 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (6 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
apps/blade/src/app/anthony_calabrese/page.module.cssESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. apps/blade/src/app/anthony_calabrese/page.tsxESLint skipped: the matched ESLint configuration already failed (missing-dependency). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Warning |
There was a problem hiding this comment.
Actionable comments posted: 2
Note
Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.
🟡 Other comments (3)
apps/blade/src/app/anthony_calabrese/page.tsx-59-59 (1)
59-59: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winMark decorative images as decorative.
The gear and vine images have nonempty
alttext, so screen readers announce them repeatedly. Set theiraltvalue to"". Usealt="KHIX logo"for the logo image.apps/blade/src/app/anthony_calabrese/page.module.css-8-8 (1)
8-8: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winProvide a reduced-motion end state.
Add a
prefers-reduced-motionrule that disables animations, sets.curtain1and.curtain3toopacity: 0, and sets.curtain2toopacity: 1.Also applies to: 27-27, 46-46, 68-68, 90-90, 118-118, 139-139, 156-156, 168-168, 181-181, 194-194
apps/blade/src/app/anthony_calabrese/page.module.css-118-121 (1)
118-121: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winUse kebab-case keyframe names.
Stylelint rejects these camelCase keyframe names. Rename each
animationreference and matching@keyframesidentifier to kebab-case.
apps/blade/src/app/anthony_calabrese/page.module.css#L118-L121: renamepipeMovetopipe-move.apps/blade/src/app/anthony_calabrese/page.module.css#L138-L142: renametkMovetotk-move.apps/blade/src/app/anthony_calabrese/page.module.css#L155-L159: renamegearMoveRighttogear-move-right.apps/blade/src/app/anthony_calabrese/page.module.css#L167-L171: renamegearMoveRightBottomtogear-move-right-bottom.apps/blade/src/app/anthony_calabrese/page.module.css#L180-L184: renamegearMoveLeftBottomtogear-move-left-bottom.apps/blade/src/app/anthony_calabrese/page.module.css#L193-L197: renamegearMoveLefttogear-move-left.Source: Linters/SAST tools
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: QUIET
Plan: Team
Run ID: 9947bbc1-bdc3-45e7-af41-c6499702dbff
⛔ Files ignored due to path filters (9)
apps/blade/public/gear.pngis excluded by!**/*.pngapps/blade/public/khix-logo-white.svgis excluded by!**/*.svgapps/blade/public/pipefactory.pngis excluded by!**/*.pngapps/blade/public/sidewalk.svgis excluded by!**/*.svgapps/blade/public/tkgreen.pngis excluded by!**/*.pngapps/blade/public/vines.pngis excluded by!**/*.pngapps/blade/public/vines2.pngis excluded by!**/*.pngapps/blade/public/vines2invert.pngis excluded by!**/*.pngapps/blade/src/app/anthony_calabrese/fonts/animeace2_reg.ttfis excluded by!**/*.ttf
📒 Files selected for processing (2)
apps/blade/src/app/anthony_calabrese/page.module.cssapps/blade/src/app/anthony_calabrese/page.tsx
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
| height: 100dvh; | ||
| overflow: hidden; |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Allow the link list to scroll.
height: 100dvh with overflow: hidden clips links on short or zoomed viewports. Use min-height: 100dvh, overflow-x: hidden, and overflow-y: auto.
| <div | ||
| className={cn( | ||
| styles.boxPulse, | ||
| "z-10 flex h-[60dvh] w-[100dvw] flex-col items-center justify-center md:h-[40dvh]", |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Layer the link container above the decorations.
z-10 has no effect on this non-positioned block. The fixed z-10 decorations can cover and intercept the links. Add relative z-20 here.
adds a standalone, additive route at /anthony_calabrese with an animated intro curtain, gear/vine/conveyor decorations, and links to resume/linkedin/github/portfolio. scoped entirely to its own route (page.tsx, page.module.css, local font, public assets) with no changes to shared blade files (layout, globals.css, root page).
Why
PR made for dev team application for Anthony Calabrese
What
A small, mini portfolio for the dev team application, modeled under own blade route.
Note
As always, thank you for your time and have a wonderful day.