Repository navigation
test(desktop): drop a stray link book save and spell out merge notices - #3796
Merged
Merged
Conversation
resetForTests now drops the link book's pending save, which fired after the next test had no engine and printed a 'The server is not connected' stack trace in four files. The merge notice test names each expected line instead of rebuilding it with the code's own expression, and covers the state and empty fallbacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
projects.test.tsand others). It read like a failure in CI logs.resetForTestsnow calls a newresetLinkBook()that drops the pending save and the engine flag.str(result.detail) || str(obj(result.error)?.message)expression asmergeResultNotice. It now names each expected line as a literal, and adds the state-only and empty-result fallbacks the code has but the old test never reached.Changelog
none
Testing
bun run check: all tests pass, andbun test srcno longer prints the link book stack traces.