Repository navigation
fix(desktop): share the engine in Linux system WebKit installs - #3802
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Linux installs still selected AppImage after the smaller system-WebKitGTK archive shipped, and downloaded a separate CLI engine. Prefer the verified archive when system WebKitGTK 4.1 is available, install the app in a writable stable directory, and link the CLI to its engine. A server installed from this app uses that same engine through the existing non-AppImage service path.
Add explicit
--system-webkitand--appimagechoices, check actual shared-library dependencies before installation, and retain AppImage fallback when WebKitGTK or an older release archive is unavailable. Existing AppImage and service files stay intact, with migration instructions, so running processes and service definitions remain valid.Changelog
Use smaller Linux desktop downloads when system WebKitGTK is installed and share the app engine with the CLI.
Testing
bash -n scripts/install.sh,git diff --check, andbash scripts/test-ci-relevant-changes.sh.