Repository navigation
fix(desktop): take a seen failure out of Needs you - #3803
Merged
Merged
Conversation
Opening a thread cleared its failed mark, but Needs you also builds a failed row from a transcript whose last turn failed, so the row stayed after the thread was opened and its banner dismissed. Opening the thread or dismissing its banner now records the failure as seen, the thread on screen has no row for its replayed failure, and a later failure is a row again. The question card's Esc tooltip says Decline, which is what it does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The error banner's Dismiss only hid the banner, and opening a failed thread cleared its failed mark while Needs you rebuilt the row from the transcript's failed last turn. Either way the row stayed.
seeFailure), quietly, from both sources.Changelog
Opening a failed thread or dismissing its error now takes it out of Needs you.
Testing
bun run check; new tests instate/store.test.tsandstate/inbox.test.ts.