Repository navigation
feat(desktop): add a sidebar toolbar with search, sort and filter - #3806
Merged
Merged
Conversation
The sidebar's view options lived only in ⌘K, and Only this project hid other projects' threads with nothing on screen saying so. A toolbar under Needs you now holds a search field, a Sort and filter menu (Activity, Last updated, Title; the four view options) and New thread. An active project filter shows as a chip with a clear button. The toolbar can be turned off, and how many idle days settle a thread (or never) is a setting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The sidebar's view options could only be changed from ⌘K, nothing on screen pointed to search or New thread, and "Only this project" hid other projects' threads without saying so.
ui/SidebarToolbar.tsx), on by default:docs/design.mddescribes the sidebar as it now is.Changelog
The sidebar has a toolbar again: search threads, sort and filter the list, and start a new thread. Idle threads can settle after a chosen number of days, or never.
Testing
bun run check;state/sidebarToolbar.test.tscovers the sorts, the search match and the settle rule. Checked in the mock window: the toolbar, a search narrowing to one row, the menu, and the project chip.