Repository navigation
fix(desktop): keep icons on the design scale and say this computer - #3809
Merged
Merged
Conversation
Icons were drawn at 8 to 22px, with 11px used 128 times though the scale in docs/design.md has no 11. Every icon now takes a size from the scale (10, 12, 13, 14, 16, 18, 24), and a design test keeps it there. Visible strings that called this computer 'this machine', or environments 'machines', use the words docs/terminology.md gives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Icons. Icons were drawn at 8–22px; 11px alone was used 128 times though the scale in
docs/design.mdhas no 11, so neighbouring buttons were a pixel apart. Everysize={n}inui/now takes a size from the scale:docs/design.mdnames 10 (glyph in a status dot, caption spinner) and 24 (a page's mark), and says no others.design.test.tsfails on any off-scale size.Words. Visible strings follow
docs/terminology.md: the local computer is this computer, other ones are environments (Capabilities, Computer use, Remote connect, Text generation, Project generators, Settings scope, Environment settings).Changelog
Icons share one size scale across the app, and settings say "this computer" and "environments" consistently.
Testing
bun run check(new icon scale test); looked at the home view and a thread with an approval card in the mock window.